From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C9FC433DF for ; Sat, 4 Jul 2020 10:24:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C91B20870 for ; Sat, 4 Jul 2020 10:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wskyW9Md" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C91B20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X1ETIsbGQh3C7Yz2GC/0Q8pA7ZPnzUhoNLjN5LS5bY8=; b=wskyW9Md1qPZASN1GYxR2rzMT Zke/rLFQejIlu7Dcrzs4g2T9o+CsONruksZlWMMQWKP8ZCTBHxWTPEtZ58RrTy1HckNgEotYDgrLs HNJXi78K+i+B697nbIRbXAJLGWg6osOPLAmqpmMSM8MYHYSmK1hYX9+dqgKpUKg2JFdamFtzbPjEo 6vd5pAvHmV9WqD4Ic3PDYdFqBgX32HeeWnGTrOCl9B0rY6HhRwrydoow48SGzsx2B6mMsE8p5Orco opuazpkGYAgL+4kLbXhShTHtUVCpTnk3DwYlBZ0pmDjZfTD0bEZ/UbR72Y1LkyrXhcSqe6JFHb0tF TWwm/kWZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrfJt-0001g5-C5; Sat, 04 Jul 2020 10:22:53 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrfJr-0001fk-BH for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2020 10:22:52 +0000 Received: by mail-ed1-f68.google.com with SMTP id dm19so23730094edb.13 for ; Sat, 04 Jul 2020 03:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+jrV0HqUbkt9Cx5rpAJlhzgehxEYGZ5fXXCayKBNA8w=; b=CT6jvNt+PLBWUKeeJgguOqKXMtYi7h9mZZUobURpHcWIipquq0CPznXv9yxtIHqv3w FXfSjslSzv7gYxmhK17ZEq7tV3WuIMj7My/4aLlOkwQsrg1bLHc219KQPUzs19My5C/4 YJsRkTkQMEMpjshjxsEJYODBvBlamqDrczq/RrJq3IB7jCkyrQi9UNqwXmDD8dOhj0su 5wn8VqHLTI9sNEzCmyNVSWOxTIpXRlgEvX5rOp4mO30NqJvzxrmlJyCM9pl/xva0lGY5 g1GnJ7iq+qMdHVFACMHdsIbFs9gpGAHNvGGsC1BJkvc7gImjsXVDnSW3l2FOtmsGSwxt rpGg== X-Gm-Message-State: AOAM533UYHCM6HzBTbxLLbXuYry0/uzmwG6p5hzvvbpJ3PJid2TGHylB KBk39urLOpbZTrpaDjKK/94JULYl X-Google-Smtp-Source: ABdhPJydT2qa3CL2K8I9FiDko44uIMNxsxpERrU9lCToYFS85q0/39Ygxmz7gRja65rU5l2pJFMR+Q== X-Received: by 2002:a05:6402:31ad:: with SMTP id dj13mr2189528edb.88.1593858169754; Sat, 04 Jul 2020 03:22:49 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id ck6sm14236971edb.18.2020.07.04.03.22.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Jul 2020 03:22:48 -0700 (PDT) Date: Sat, 4 Jul 2020 12:22:46 +0200 From: Krzysztof Kozlowski To: Alim Akhtar Subject: Re: [PATCH] arm64: dts: exynos: Add minimal bootargs Message-ID: <20200704102246.GA5975@kozik-lap> References: <20200703182536.9190-1-alim.akhtar@samsung.com> <000801d6516a$b6efcb40$24cf61c0$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <000801d6516a$b6efcb40$24cf61c0$@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200704_062251_424293_FEF0FCCE X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 04, 2020 at 12:19:40AM +0530, Alim Akhtar wrote: > Adding Krzysztof's correct email address. > Sorry about noise. > > > -----Original Message----- > > From: Alim Akhtar > > Sent: 03 July 2020 23:56 > > To: rzk@kernel.org > > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; > > robh+dt@kernel.org; Alim Akhtar > > Subject: [PATCH] arm64: dts: exynos: Add minimal bootargs > > > > Add minimal bootargs to enable earlycon and console. > > This really useful in case kernel has crashed early in boot process. > > > > Signed-off-by: Alim Akhtar > > --- > > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > index 790f12ca8981..d7b42d5a3b2d 100644 > > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > @@ -24,6 +24,7 @@ > > > > chosen { > > stdout-path = &serial_2; > > + bootargs = "earlycon=exynos4210,0x14c30000 > > console=ttySAC0,115200n8"; Hi, The console is already chosen by stdout-path and earlycon would use it as well, so no need for the address. It should be just "earlycon" if you want to enable it unconditionally. Also, why did you use different serial for console? However the question is, are you sure you want earlycon on every, including successful boot? On most of the boards we do not enable by default. If developer needs, he can choose it for example via U-Boot "setenv opts earlycon". However it's a development kit so it could be enabled on default... Best regards, Krzysztof > > }; > > > > memory@40000000 { > > > > base-commit: 9e50b94b3eb0d859a2586b5a40d7fd6e5afd9210 > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel