From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D24C433DF for ; Sat, 4 Jul 2020 13:39:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E85FD20826 for ; Sat, 4 Jul 2020 13:39:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G+FapM8i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="hj8UUCwp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="PtRC86pL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E85FD20826 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=WjT7/UwdsBl9r9EDtETtLfRnz0SGZQJsGacqcwozovg=; b=G+FapM8idkpCldPxgcztAHeR0k BH+8TrkEInomvcpefO8+boN+7XmI3+09iwcdxibGEQ1OY14gcikPYAEK9fr2l31p7WV+u7LJkIDmv 44IFHFkL2Z3oNlqRh3Y1Ko5wJxai53VwfOGfz5Xz9cNAiyxInTTm1iigE3UqQ2Qz5/C/s6HdWXG1d 7WvNi30xvYhAo/K5N/tTbnqzi3lGta/lCaxrh0+zyS+zaqEtc6o0EGX7pQRPS3PHNHDe+614qo0lq oLbkldiP5i4wZ0MgGAQAokd1vd8n/onHL9T01sFgLBf8t4lkvq3psxCGN5hAmBQF+zaZYha+NuqBm zrmDWx1Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jriMv-0007sb-6b; Sat, 04 Jul 2020 13:38:13 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jriMs-0007sB-1c for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2020 13:38:10 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 75DB05C00BF; Sat, 4 Jul 2020 09:38:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 04 Jul 2020 09:38:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=awwlzHSud02pzpUia/C+VkZ8dj FnBAxJFReM6NFKbSY=; b=hj8UUCwpWlqb4Z0Pmt3wd0TpS4QVMgKFJ0S3VzAP++ BFEfaScj+DzYOMgAM1gCh1SaeD5BwHpxFoYJ4YaOICTYGYuOfJHrW286PhMO0rZ1 rt+ZMeBMm/Zo+jqnqJLu3NOh9HT60WVvbwyLsbfa3XAN+OYibQ6C0b4Jpvxjt237 PWhZEv8X4EgAD4wOaUHMsYc/SqycunJCVXeB6KpZSFJePel+YvMrb/Z8LTXgA5Z+ XBTrfIC9yq9lM/TVC5/IjRzLSHnjemHrxQ1hTWwCjbvQbGhNQXTp5Ln5wvhFjKko lJMCJvTgv+3yZUtTTdcGQNULgWOwlHnVBJK3Z0c4ia2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=awwlzHSud02pzpUia /C+VkZ8djFnBAxJFReM6NFKbSY=; b=PtRC86pLPUimBOcnypAwOvQcALrPIZf6x jH+xOnMtkcbxwgeP5rGQws8NtLBkdk4uhYudbXsC99D6NBAYDi8zu/bLKjqi7T4t upVo5zI7q2zglxC8dpmgXMZ6ngqD7+E31v+6/3BxUJYVME3cPRlvxxAwNPk3TM/8 zX4DxpkG7PlOWszOkFXCz7JdGI0vxwFSOwRBTJbTlqRj7blSVfMTNgNFTmsApTSv nb7zkAOolUwQpZVtUbG29MbMoClE4ORDSEnsgH/DAR9jQziMRD2e0fpQ4R5+KSAb NoNQIDmiqf9giWG5IUlLpJxAFKR6zyaGXGO0uBHEstOclsU1J1pOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdekgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpeforgigihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhho rdhtvggthheqnecuggftrfgrthhtvghrnhepjeffheduvddvvdelhfegleelfffgieejvd ehgfeijedtieeuteejteefueekjeegnecukfhppeeltddrkeelrdeikedrjeeinecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvse gtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 005F43280064; Sat, 4 Jul 2020 09:38:05 -0400 (EDT) From: Maxime Ripard To: Chen-Yu Tsai , Maxime Ripard Subject: [PATCH] drm/sun4i: lvds: Invert the LVDS polarity Date: Sat, 4 Jul 2020 15:38:03 +0200 Message-Id: <20200704133803.37330-1-maxime@cerno.tech> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200704_093810_304085_3115D50F X-CRM114-Status: UNSURE ( 8.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The LVDS controller can invert the polarity / lanes of the LVDS output. The default polarity causes some issues on some panels. However, U-Boot has always used the opposite polarity without any reported issue, and the only currently supported LVDS panel in-tree (the TBS A711) seems to be able to work with both settings. Let's just use the same polarity than U-Boot to be more consistent and hopefully support all the panels. Cc: Ondrej Jirman Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 359b56e43b83..e44635ebd510 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -474,9 +474,7 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon, SUN4I_TCON0_BASIC2_V_TOTAL(mode->crtc_vtotal * 2) | SUN4I_TCON0_BASIC2_V_BACKPORCH(bp)); - reg = SUN4I_TCON0_LVDS_IF_CLK_SEL_TCON0 | - SUN4I_TCON0_LVDS_IF_DATA_POL_NORMAL | - SUN4I_TCON0_LVDS_IF_CLK_POL_NORMAL; + reg = SUN4I_TCON0_LVDS_IF_CLK_SEL_TCON0; if (sun4i_tcon_get_pixel_depth(encoder) == 24) reg |= SUN4I_TCON0_LVDS_IF_BITWIDTH_24BITS; else -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel