From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74A7C433DF for ; Sat, 4 Jul 2020 19:33:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B108820890 for ; Sat, 4 Jul 2020 19:33:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fQ9Fk8C/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="WckZLzj5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B108820890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0hpDCDD6bfAyaIXEIkbWXCZM95KRlsc5eeT02zoaieA=; b=fQ9Fk8C//6DgAR80CU+vT0FpJ BV4KyEeffU469rWld/cg6Db8/IZlSzbjC98+sMmKMtN/dqvKEhzbplhhWaeNG4b29x4PzNVdUBwMU x5+13IjD95aEsmPiZa61Vsvhhb8+X8DwE04PQcYXqJsqEUkyRA/VLuiU7UWZZeswfIPzc/vGPCAJx MjymCfg14Epzr1geou1HvYiJguXmyimTPw7XUtIooURqpODfp4+8MuUyqbZuFrF57JcPAFrh4srL1 TWqqhGs9rgA52YkK2noGLAEx3w5/HuymTO9gzyxwLf0ipVMZmL7s8CLGdyn9KMcw5IPnm4LfJprnF 4VczrkxBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrnre-0001KW-Q4; Sat, 04 Jul 2020 19:30:18 +0000 Received: from mout.gmx.net ([212.227.15.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrnrc-0001Jc-ED for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2020 19:30:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1593891011; bh=WAD5QQlP0LCkmso8s+gKUS7M0lXvNdxkqPNyUPummWA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=WckZLzj5zO4amkQZXROZtQ0IuxE5EWMjT8DfhOLJKhueZFzz+RNnLl6m4aq9d6NU5 6/96ZNuNcYB8Yk9n+KC8TVe5JJssNLxC0UKT2Mre2rIUxAXvpZNN/fb6fnMPtoNiQk tXQyp2A8FCz6fx5Ty5SV7MOKnl1EcQjysTMTyw6o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.195.26]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWih0-1kOkyA3Zvs-00X0R7; Sat, 04 Jul 2020 21:23:31 +0200 Date: Sat, 4 Jul 2020 21:23:23 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Alexandre Belloni Subject: Re: [RFC PATCH 08/10] rtc: New driver for RTC in Netronix embedded controller Message-ID: <20200704192323.GC2578@latitude> References: <20200620224222.1312520-1-j.neuschaefer@gmx.net> <20200620224222.1312520-7-j.neuschaefer@gmx.net> <20200621001106.GC131826@piout.net> MIME-Version: 1.0 In-Reply-To: <20200621001106.GC131826@piout.net> X-Provags-ID: V03:K1:DMqWrUZO9WvfwP5GHEh60ZFeADf5FrliknlidT+JUvSoso7C0AO 7MW0Tsc9rRZy85HRmMyausOcHHg5ACqV3x2iHCabh8I85A6vvvw+nQZNqTwQ8KwSFyvd3DY qADu0PJkUy9H+ni38N2KVI3fhPnR6KEBZ9eTOiyHnsujTpSxcrQpTa6UayqX+6ezHFvxPy1 ceSsoyvzbC3cSZqkmvszA== X-UI-Out-Filterresults: notjunk:1;V03:K0:pbn7NnG+pYo=:PqxyV5QqX0xh4J6r1KxalF FY5mNgDJkK8NTmKQblKBXHiwt15Z3neYaztxfZXsGo605HTQcr5jk6bX4BFY/pNIuBI8S0A6M j2UeiPw2DtXy5MqfEzndWW57AVtJFtk70csy5a1mCmaCoNEXrVMigCqz5I8qmOIWP1ALs/JMs uQlRcHyDYSOUtnguxnGMpo26wx8NFGUjkBDn5ruYkrRNv9BOg1r2+ME/A/vbKIShD/KRbGzRp EW9373AQwkbfSeGwljqNEMfUQ29YdsZrgEC9beEDqR7e/TaSxDODXo0vOY6jyNT7isx3+3S1v CShfo3rzYdKJNj3dQuTi+atIHNlAXfOl34v398C6uWPtEXMVkYywoDcLT20O3h5xMsBa/D4MD H2I2XWwdfBQ6+o3AdKRPw2NZvDsMoSXgHoMyBhCFBdbPQ+rSypDt8KHvBFXYs6j73YRSdqYYc SXrHykzHDNus3cwGXCOK+98SqqmjlWIQx3NEBnKYuzSlYUujplGDEgpq/gc1gOV7XwTrQf+mH RJoXjIRobP350XOt/e6XoQXMxYT4Wh3JNviCNMzEp8/93Q+L56/7j54LLMNcvbC1HuZVp9UV6 GycpsxDEZb/SGhfivFHLUp2/yAZFYOYzS81o7CbqF0iRMzvhlXASecsZgMQOqF5HHoRcEwFUq PI9XNOGD7fGr7rcavkIbHZP8xWba2LUCndTPT38EdSUcgFqe3jIs6sfVl/OGJvWvsBMD4O34s FIU73Y8xbCzbYz9FI9TNtzCUehLu0q1xt6DkjXwMyd2jp3IT2V3lAoNdJXMOvkLQf2bKawz3Q EndwpDR7olL38nQYxyY2QiHwLYEFOKSG9hFWuLn1Ib9zHWyIrklbTky/co4iBhGsFVTyal7CO K2l5/XL/M5CIcQFiikNxMwpaYBAlcNcCZcNOCDHrlOgDbj/obhO4u40QUqHQ0w9EyAxpSQA2x QrMqWNZ6BtGZvO48H4d1ix5oocopqEe1ykkBPPaWWfnkSkXLxw7vnBCi4dZ4//X+aBbGAMlEP qTU5wKz/7D30ztPC3/AS/o4Hh+ZVx/FsnbIgHIEK1J4DsGWd2YpeMAPkDXT/hLKp3y/yYYEnz mDNFXDEvSpuMQBbFjghHNUxxDk5zTk/dwrpfAFLs6AZ9rcuNAAFC317n8H5Q6DzzuMHlNnbsl Y9eYX2YCg43m+LfGyfJS+vOjswDNMzF8M9fZOw4kBumbQI48WA54yIKHkeVcoaniML1ITjfLQ VUSctFOONVMxlTDID X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200704_153016_715644_7D3078C5 X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Mauro Carvalho Chehab , Sam Ravnborg , Andreas Kemnade , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============2010159366646115536==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2010159366646115536== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eRtJSFbw+EEWtPj3" Content-Disposition: inline --eRtJSFbw+EEWtPj3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Jun 21, 2020 at 02:11:06AM +0200, Alexandre Belloni wrote: > On 21/06/2020 00:42:19+0200, Jonathan Neusch=C3=A4fer wrote: > > With this driver, mainline Linux can keep its time and date in sync with > > the vendor kernel. > >=20 > > Advanced functionality like alarm and automatic power-on is not yet > > supported. > >=20 >=20 > Please report the results of rtctest (from the kernel tree) [...] # ./rtctest [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] Running 7 tests from 2 test cases. [ RUN ] rtc.date_read ../../tools/testing/selftests/rtc/rtctest.c:49:date_read:Current RTC date= /time is 11/04/2006 23:11:23. [ OK ] rtc.date_read [ RUN ] rtc.uie_read [ 180.651355] random: crng init done uie_read: Test terminated by timeout [ FAIL ] rtc.uie_read [ RUN ] rtc.uie_select ../../tools/testing/selftests/rtc/rtctest.c:98:uie_select:Expected 0 (0) = !=3D rc (0) uie_select: Test terminated by assertion [ FAIL ] rtc.uie_select [ RUN ] rtc.alarm_alm_set ../../tools/testing/selftests/rtc/rtctest.c:129:alarm_alm_set:skip alarms= are not supported. [ OK ] rtc.alarm_alm_set [ RUN ] rtc.alarm_wkalm_set ../../tools/testing/selftests/rtc/rtctest.c:185:alarm_wkalm_set:skip alar= ms are not supported. [ OK ] rtc.alarm_wkalm_set [ RUN ] rtc.alarm_alm_set_minute ../../tools/testing/selftests/rtc/rtctest.c:231:alarm_alm_set_minute:skip= alarms are not supported. [ OK ] rtc.alarm_alm_set_minute [ RUN ] rtc.alarm_wkalm_set_minute ../../tools/testing/selftests/rtc/rtctest.c:287:alarm_wkalm_set_minute:sk= ip alarms are not supported. [ OK ] rtc.alarm_wkalm_set_minute [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] 5 / 7 tests passed. [ FAILED ] > [...] and rtc-range > (https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/t= ree/rtc-range.c) # ./rtc-range =20 Testing 1970-01-01 00:00:00. KO Read back 2226-01-01 00:01:00. =20 Testing 2000-02-28 23:59:59. KO Read back 2000-02-28 23:28:23. =20 Testing 2020-02-28 23:59:59. KO Read back 2020-02-28 23:28:23. =20 Testing 2038-01-19 03:14:07. KO Read back 2038-01-19 03:19:03. =20 Testing 2069-12-31 23:59:59. KO Read back 2069-12-31 23:31:23. =20 Testing 2079-12-31 23:59:59. KO Read back 2079-12-31 23:31:23. =20 Testing 2099-12-31 23:59:59. KO Read back 2099-12-31 23:31:23. =20 Testing 2255-12-31 23:59:59. KO Read back 2255-12-31 23:31:23. =20 Testing 2100-02-28 23:59:59. KO Read back 2100-02-28 23:28:23. =20 Testing 2106-02-07 06:28:15. KO Read back 2106-02-07 06:07:06. =20 Testing 2262-04-11 23:47:16. KO Read back 2006-04-11 23:11:23. Something is very wrong here. I'll try to fix the failures in rtctest and the problems in rtc-range before version 2 of the patchset. (The 2255 date was my addition, because I suspect this to be the upper limit of the RTC's range.) [...] > > +config RTC_DRV_NTXEC > > + tristate "Netronix embedded controller RTC driver" > > + depends on MFD_NTXEC > > + >=20 > This should get an help section. Ok, I'll add one. [...] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >=20 > Please sort the includes. Will do. [...] > > + rtcdev =3D devm_rtc_device_register(&pdev->dev, "ntxec-rtc", > > + &ntxec_rtc_ops, THIS_MODULE); >=20 > Please use devm_rtc_allocate_device and rtc_register_device. Also, set > the supported range (->range_min and ->range_max). Ok, will do. Thanks for the review and the testing tips. Jonathan Neusch=C3=A4fer --eRtJSFbw+EEWtPj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl8A1yAACgkQCDBEmo7z X9tNnA/9H+BT9wwk5LCwgYRQGaCp/1zm7d962UhBAu5F59rAP2Ho8ioQNoJcCc0/ xwAaeJYaRm7iOWjVdlL0wfnv8kJRDjYs4ml0arpTPFW4dmz4+zvFoZfIVIlUHy+1 t/cY1k/KCTXqAXUmyVMMZ6b3Q7/mwjKYLQV2nRgW3sHiBoQI2q6cV69XQZM1JVo0 NV+m7HGvL5AmPZGjLmbSC8PiOMlS35Tm6v0IKrYXHt3ASOF7ukMqTMT3+1aRCrzs zqtZHJdUfGA3DpkZTiLK+m8t5L4t6qsiyd+QX9jFg1KaSXapVF5nV+wNYgdebcqQ UqeA5ylgENA6WaYv5N8xl1MO6UZhYiH5Qw/mJZ0rG4pyf0Ad6nZJxd+l8eWseMFX LCOtTqRIKC6Oa2sKPUI/TN56GafA1cK+ZHljn/FjpI5CUQfHlcAz/QEkACPIs1S8 WtMdsBfP3cjqGPapGbknlBi8KGnyL/qFj42PCOApXdNOczJAXMRfvvXYHfdnVxUx 9pw9oAc06PijFOB72FUMYA3U2aiNz5Qk+zMmmsTFDAnRJmsnFc8hhooewHn4Ha3I AiJVhLvGrzVlSS8Yq7O2jm1SsRYKAO93YctBIxMfRJvd2a+72++4X7oPc1qKxCkQ U5YIMEbe4JyTCq0Bj6rbOd1k4+36LVMRT/jyGg7DK66PUgfB2dI= =jCx0 -----END PGP SIGNATURE----- --eRtJSFbw+EEWtPj3-- --===============2010159366646115536== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2010159366646115536==--