From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A03C433DF for ; Sun, 5 Jul 2020 21:11:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C91420739 for ; Sun, 5 Jul 2020 21:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TWNHEIrI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hVbmiwgQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C91420739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bWNA+CZi56amfamDbTq7G/Kj3efTkQbDwJ075ZqUKiM=; b=TWNHEIrI/gu3g6AzD18MzDtz6 SCIYlUsNxe4v8ZIwsM9SNJDj1t53yjuA9uA5QpFqVYyp1pz1sCzfVPaOdOZHDkrBP9UClkaOMzTXV a68M92+YW1WS+0yhFSDbcaOpWsgUyS9+KP9htVxNtArPJYgT2hWTGn450CxbqIiayorr0MWhJ29LC +ZAtL6J4mNvY6kGfpTpA4dCRmoaNkl3xQmIzyeq9yNp8pw2JaniROsgHrjdkfjzLOF3j6hePR+9ot Gt97ZJA8vM1qmO+OU0BvqorC3KYPJebRpJ1rwbIP7G3dRm1bSf/fFkrvW8RI66SXUMD0wBamm5+t6 byDUWC+1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsBti-000446-50; Sun, 05 Jul 2020 21:10:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsBtf-000438-Fk for linux-arm-kernel@lists.infradead.org; Sun, 05 Jul 2020 21:10:00 +0000 Received: from localhost (p54b33111.dip0.t-ipconnect.de [84.179.49.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66BD920708; Sun, 5 Jul 2020 21:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593983397; bh=/CSI7abxLv8Pc3WAATfmk0MQHaUctOQmqgjenee+WS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hVbmiwgQ+gyxLGOWmEQrsr/+QFj3HrZ6kILQ9SdqDqD71MSP+avP5cp+0NXZ5WGKy mtCciswcqwa+VB1OpLoiH016DRJ6IVwEJNbsJOWE8rurmnkR8oPHVWzogfLVXoEarj 8dbk6u7VMdQYtjR3ZVUwIMYq+k9ZppWVGZuh2rL8= Date: Sun, 5 Jul 2020 23:09:42 +0200 From: Wolfram Sang To: Codrin Ciubotariu Subject: Re: [RFC PATCH 0/4] i2c: core: add generic GPIO bus recovery Message-ID: <20200705210942.GA1055@kunai> References: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 In-Reply-To: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200705_170959_640511_51A949B3 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1911466935518231748==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1911466935518231748== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 19, 2020 at 05:19:00PM +0300, Codrin Ciubotariu wrote: > GPIO recovery has been added already for some I2C bus drivers, such as > imx, pxa and at91. These drivers use similar bindings and have more or > less the same code for recovery. For this reason, we aim to move the > GPIO bus recovery implementation to the I2C core so that other drivers > can benefit from it, with small modifications. > This implementation initializes the pinctrl states and the SDA/SCL > GPIOs based on common bindings. The I2C bus drivers can still use > different bindings or other particular recovery steps if needed. > The ugly part with this patch series is the handle of PROBE_DEFER > which could be returned by devm_gpiod_get(). This changes things a > little for i2c_register_adapter() and for this reason this step is > implemented in a sperate patch. > The at91 Microchip driver is the first to use this implementation, > with an AI to move the rest of the drivers in the following steps. Thanks for doing this! On a first high level review, this looks very good. I have one question in patch 1. From Tuesday on, I'll be off-the-net for two weeks. Still I think it will be all good for the 5.9 merge window unless we encounter an unexpected problem. But as said, so far it is looking good! --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8CQZIACgkQFA3kzBSg KbZSFw//V/RqkgvKSxNeOBqifHvPPJFZFRuqwrFgRyi0NpSS8q7zgZBRvd1uVk9Q eRLfGCd6DPjbpi8M2FfNaPHoROvZEQ6pFdQw61Uqd2Z1ELrTBpG2Pvq0J9FFaWbl U6U5MA+9EaAXSKAA/ylVU3kyCFDgaqpqSRBGGYydIQsUOSf5Bj3lJs1ep4Jtpuq/ nBjbGhuKUP7kegTM8MwRcQuHTG/vX+2FBssKtsqgULgeBwuNjS4BHsXTcE7cJIeV Egz0998d1vTQsy4GvUc1qfHtcYivCsoG7NKsKA8reos5aPrIjlhMWQ5/YPJDma65 ePGye2rMUdH2bUPBtZ01Px6+4DSJmON6vlAtbseay21yvWr0PaDgpuPTD7jvvMwq VjHdCEE1EapZTEVySj1plRiPX80wcKlR8RqQZErpdQxEsG911lKEuItG2ppZodOv 25hGQr+R0Cm91WzHvtgKibHoBmauGhHhJWx1yvc+h6S0ZHCE+IeskqEUzetNbZqw XaJCsD0l1iUY6o5ph5z2NrD1GZ4aCxvNlt/8oyIUvxzyUk8KrQKwXAZW02saIiu+ p87dpYOYLWp/IDri/JZ6tNoehnoeX355UqVb1Wqhk0gfWqQZTIOGmbsLU1D2cTJa Ti108H0CVqSfuAmkwdUIJAe1BjIVYnaB9INhiYHBgGLzuaX9ft4= =jI5N -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q-- --===============1911466935518231748== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1911466935518231748==--