From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC6DC433DF for ; Mon, 6 Jul 2020 08:14:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB232206E6 for ; Mon, 6 Jul 2020 08:14:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R67z1k+B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB232206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IRP30QdUlJKWbDsluJFgXTFwy1x5ZzJ39NClVN3yoOs=; b=R67z1k+BR5+S8jyIwI3KTXi8n sNqx1mc6fPZ0jVnvPtrKE073riUAFVs+1VQUw4EeLcH+bQ0alPEBoppQI/5b4dSdUDzp6On4yhNAZ Wj5xim1/pphoiaTcEpN82mcZ4V0Az1Ul/wPtbpLTbgRDYx2v5OMwxx8wBW3hOneYxuUR78iJ9Hxbw ZBrolTxABm0eJufofPxQUOwH7i6hSMcpXK9kcx6of/FrRaRraoKEaBKm0JRsCgxAwjKq7yphKs0bc a1RtbmZxhAWqvVK9VaI9o8imj0n7xkQzrx7w3deGc98FBCRpyuUR6pOtn+JmJlDQqZQq8xQ2yVf+B ANLWqzpUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsMFW-0005Cz-DF; Mon, 06 Jul 2020 08:13:14 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsMFU-0005C7-2a for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 08:13:12 +0000 Received: by mail-wr1-f66.google.com with SMTP id a6so39787152wrm.4 for ; Mon, 06 Jul 2020 01:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TUKUTjO33DX82247t1T1Yew5fhk3nmz220YuXhRhADc=; b=jvhhRK6I0GUX5z8lBOzUX6IeNkvvqgRQzPzioHNNfpbnbsZu58Z6sVoU8Uz2aR+p23 cJcC8ib8gnawsw7SXPSru92ygJBm8fFRiC3rdyho54MwvKiR9GMb04qNizUPn71PeRUY Hq3zQUnYYMGE53SHyUKSH/7+oPomDw4cbydhU4jTFnfXFWy3DJHzUq3ySn12eLmpsTkx ll81l0KcuJcfBpWAfSG3MxxGgTIxnOijey9pAqUGT3fifK2DJ0ieI8zNqrRjH5OKk6Q5 F2M+53+5F1oWzlu/HXgPBPheF9Yzqs5jUP4KhhA6AuZNwGS+wKPTofFLHxaOosa6feGz 5QcA== X-Gm-Message-State: AOAM531/BudWpV1qAtHGFy9UzSAb+Yn1w67Bzx2e67R8668F+xma49CA loTanLdMZkC1wnYyHsLTVvnQvKBc X-Google-Smtp-Source: ABdhPJzyJLT0CQOJhMf7/BN92VF7E6LpQaMaK9rgLW0mqz5ccWXizBMna/VaEldxg5y18H3HXfxLPA== X-Received: by 2002:a5d:6045:: with SMTP id j5mr46637840wrt.209.1594023190618; Mon, 06 Jul 2020 01:13:10 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id f12sm23767680wrj.48.2020.07.06.01.13.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Jul 2020 01:13:09 -0700 (PDT) Date: Mon, 6 Jul 2020 10:13:07 +0200 From: Krzysztof Kozlowski To: Tamseel Shams Subject: Re: [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC Message-ID: <20200706081307.GA13025@kozik-lap> References: <20200704140646.66528-1-m.shams@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200704140646.66528-1-m.shams@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_041312_185945_81C3CDAD X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kgene@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 04, 2020 at 07:36:46PM +0530, Tamseel Shams wrote: > In few older Samsung SoCs like s3c2410, s3c2412 > and s3c2440, UART IP is having 2 interrupt lines. > However, in other SoCs like s3c6400, s5pv210, > exynos5433, and exynos4210 UART is having only 1 > interrupt line. Due to this, "platform_get_irq(platdev, 1)" > call in the driver gives the following warning: > "IRQ index 1 not found" on recent platforms. > > This patch re-factors the IRQ resources handling for > each platform and hence fixing the above warnings seen > on some platforms. > > Signed-off-by: Tamseel Shams > --- > Removed the logic of irq_cnt and directly using > s3c24xx_serial_has_interrupt_mask() to check for > number of interrupt lines. > > drivers/tty/serial/samsung_tty.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 6ef614d8648c..8a955f3d8975 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -1908,10 +1908,13 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > else { > port->irq = ret; > ourport->rx_irq = ret; > - ourport->tx_irq = ret + 1; > + if (s3c24xx_serial_has_interrupt_mask(port)) > + ourport->tx_irq = ret; Hi, I don't understand: Why do you assign here the same interrupt as RX? Best regards, Krzysztof > + else > + ourport->tx_irq = ret + 1; > } > > - ret = platform_get_irq(platdev, 1); > + ret = platform_get_irq_optional(platdev, 1); > if (ret > 0) > ourport->tx_irq = ret; > /* > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel