linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: ulf.hansson@linaro.org
Cc: Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 15/15] mmc: host: sdhci-iproc: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
Date: Tue, 7 Jul 2020 07:47:01 +0100	[thread overview]
Message-ID: <20200707064701.GC3500@dell> (raw)
In-Reply-To: <20200701124702.908713-16-lee.jones@linaro.org>

Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI,
'struct sdhci_iproc_acpi_ids' becomes defined but unused.

Fixes the following W=1 kernel build warning:

 mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=]

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 225603148d7de..e2d8dfe90077e 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -294,12 +294,14 @@ static const struct of_device_id sdhci_iproc_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match);
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id sdhci_iproc_acpi_ids[] = {
        { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data },
        { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data },
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(acpi, sdhci_iproc_acpi_ids);
+#endif
 
 static int sdhci_iproc_probe(struct platform_device *pdev)
 {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-07  6:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 12:46 [PATCH 00/15] Clean-up MMC's W=1 build warnings Lee Jones
2020-07-01 12:46 ` [PATCH 01/15] mmc: core: quirks: Mark fixups as __maybe_unused Lee Jones
2020-07-01 12:46 ` [PATCH 02/15] mmc: core: sdio_io: Provide description for sdio_set_host_pm_flags()'s 'flag' arg Lee Jones
2020-07-01 12:46 ` [PATCH 03/15] mmc: core: regulator: Add missing documetation for 'mmc' and 'ios' Lee Jones
2020-07-01 12:46 ` [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties Lee Jones
2020-07-05 23:53   ` Jaehoon Chung
2020-07-01 12:46 ` [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Lee Jones
2020-07-01 13:09   ` Matthias Brugger
2020-07-01 12:46 ` [PATCH 06/15] mmc: host: atmel-mci: Provide 2 new and correct 1 existing property description Lee Jones
2020-07-01 12:46 ` [PATCH 07/15] mmc: core: queue: Correct misspelling of 'mq' in mmc_init_request()'s docs Lee Jones
2020-07-01 12:46 ` [PATCH 08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args Lee Jones
2020-07-05 23:53   ` Jaehoon Chung
2020-07-01 12:46 ` [PATCH 09/15] mmc: host: rtsx_pci_sdmmc: Remove set but unused variable 'err' Lee Jones
2020-07-01 12:46 ` [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: " Lee Jones
2020-07-01 12:46 ` [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and provide missing function arg(s) Lee Jones
2020-07-08  7:53   ` Michal Simek
2020-07-01 12:46 ` [PATCH 12/15] mmc: host: sdhci-msm: Staticify local function sdhci_msm_dump_vendor_regs() Lee Jones
2020-07-01 12:47 ` [PATCH 13/15] mmc: host: sdhci-msm: Demote faux kerneldoc header down to basic comment block Lee Jones
2020-07-01 12:47 ` [PATCH 14/15] mmc: host: cqhci: " Lee Jones
2020-07-02  6:43   ` Adrian Hunter
2020-07-01 12:47 ` [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used Lee Jones
2020-07-02 19:42   ` Scott Branden
2020-07-02 20:13     ` Lee Jones
2020-07-02 20:49       ` Scott Branden
2020-07-07  6:47   ` Lee Jones [this message]
2020-07-07 15:47     ` [PATCH v2 15/15] mmc: host: sdhci-iproc: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Scott Branden
2020-07-08 13:20     ` Ulf Hansson
2020-07-07  6:50 ` [PATCH 00/15] Clean-up MMC's W=1 build warnings Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707064701.GC3500@dell \
    --to=lee.jones@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).