From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF6DC433DF for ; Tue, 7 Jul 2020 18:10:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F3A32065D for ; Tue, 7 Jul 2020 18:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hLngqnzB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JSXqRKqz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F3A32065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0DmhDGdDzHqnh+y7vElQFuoVyjnsS5ny6Q55zIu8Xb0=; b=hLngqnzBjcpbv0X2g8qu37rqk UjXlIDDNTPZovQAxJYLY1za4u+Teqlt5VCwEUCRiRH8+67lPaQQsJb6yg2BShWOESWI/5Ukww8qBm PZaINR7mP9WfECwycowiRAYUaAlBPRIwR0a6rN7iVijuqovpZpDNencBk2FKgKOYeZ+35FbrVg9v7 I7nO9gmF8g1A7KXXBz5/9qGTL2XbKtVjJG852xD8DiBYixzVsicbtvWJzBnECXArhdcjRwQZAq0Fk wMXouIW7bw2NwCemKAWGbwNt+2Am72PD8tV0ptWc4li+1qqKqv3Ylaz8K8YmPIX/QpQWlGbad7Ur4 AjwYZiZhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jss1z-00062U-6g; Tue, 07 Jul 2020 18:09:23 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jss1w-00061i-6n for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 18:09:20 +0000 Received: by mail-wr1-x444.google.com with SMTP id k6so46234196wrn.3 for ; Tue, 07 Jul 2020 11:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0m2aoBIP5GJAb10zyANIdy2YC3UULtv1aWEwGmldE04=; b=JSXqRKqzNi8wby85ZOPYM8+WlbCbPrGifr8g3X3OVWXFVbASCxiEVbote2kigrv8wv JQD7OBWXUBKKot5/flogEoaBHkhPsvwOwkfD207E+UwGA7Miz0eMQoJ7zQzwhPL61Rre EuI9y+FhVrM1NKYullsJN25lGamvzcwlqp6z4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0m2aoBIP5GJAb10zyANIdy2YC3UULtv1aWEwGmldE04=; b=TbqpUW2qW3S0RVWUNKgg3ZFKiVlnzBdJUou3BRGSV9NmrHDjW4i2qyLDAAgFPD5x4L mRL0T55+lHv8kaLK17AP3RWpPMNqVImY8az0Fdwg2fGSQHHvXCWsPsCHh/7991OaMupV xAID8QC+RvyTTzjefVr91U9H1GCTKc+VGE1GBqBndfZAm1RAKAH+ZhFEPEQ3z8YndwWH bMqjjChlIpKvIstcE/fufruFar4XGgKTth0s/L4Zz4XpJOn3CYy2qWWECgqJKkm1yhma ANGQI8SsYIn4irBe8kDJ04bp/KKwDIX7PkT9+IlYaYuhsc4RUkkK3Xrym4siwZw9SwYJ 34RA== X-Gm-Message-State: AOAM533d8WSTO/ro45eLJhmpAZBiyQ0lTr8mks32p7fAZ2uJxcUSH01H Ba13AtOCdKFxNiR0kHgkfuSZQ8Av6N6gXg== X-Google-Smtp-Source: ABdhPJyQWxqFc1PHki3J/nn4kM+S8X1Xh3twrKQaB7PZs8HSIA+iXCuj+fKvvuYm4me4y3tj/6LZ2g== X-Received: by 2002:a5d:664a:: with SMTP id f10mr54971954wrw.300.1594145359012; Tue, 07 Jul 2020 11:09:19 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id v12sm2026423wrt.31.2020.07.07.11.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:09:18 -0700 (PDT) Date: Tue, 7 Jul 2020 18:09:17 +0000 From: Tomasz Figa To: Jonathan Bakker Subject: Re: [PATCH 04/11] media: exynos4-is: Correct missing entity function initialization Message-ID: <20200707180917.GD2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_140920_306831_5D94633A X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:43PM -0700, Jonathan Bakker wrote: > Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function > initialization") tried to suppress the warnings such as > > s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized! > > However, this didn't work in all cases. Correct this by calling the set > function earlier. > > Fixes: bae4500399c4 ("exynos4-is: Add missing entity function initialization") > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/fimc-capture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thank you for the patch. Please see my comments inline. > diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c > index 705f182330ca..86c233e2f2c9 100644 > --- a/drivers/media/platform/exynos4-is/fimc-capture.c > +++ b/drivers/media/platform/exynos4-is/fimc-capture.c > @@ -1799,7 +1799,6 @@ static int fimc_register_capture_device(struct fimc_dev *fimc, > vid_cap->wb_fmt.code = fmt->mbus_code; > > vid_cap->vd_pad.flags = MEDIA_PAD_FL_SINK; > - vfd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER; Isn't vfd->entity above a different entity than sd->entity below? If so, this line must stay. > ret = media_entity_pads_init(&vfd->entity, 1, &vid_cap->vd_pad); > if (ret) > goto err_free_ctx; > @@ -1898,6 +1897,7 @@ int fimc_initialize_capture_subdev(struct fimc_dev *fimc) > return ret; > > sd->entity.ops = &fimc_sd_media_ops; > + sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER; My understanding is that this is the capture subdev and not the scaler. Looking at the other drivers, MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER could be the right function to use here. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel