From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC531C433E0 for ; Tue, 7 Jul 2020 18:14:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B0762065F for ; Tue, 7 Jul 2020 18:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="crEZ4rdG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bCRBoKrb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B0762065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1XXHoA9hoF93aOlJUY6BW0wCEhHMqLDJ2g/gH2l2C/w=; b=crEZ4rdGYd8PS111LJI/PoC78 tmRANYUQSlDAlvDzHu7q26Kt5N52ADssogiOAOPLFyNDEmKTc/pS0L0uo6CQYjgAj0xvhbaRCXbP8 hYldnU6frYdl0R22D6wSdwxSbKfuPI2RvV2lcEVGrdlnC76jOJDlJ3H1xj+gHLJdbCTZ3cvJS4T0s wkx/D/RivHVHHqQjmsXEURJhi33MqvO7FVAQgypCFPI2B2J63lSSUJn0BT4oH/ClzGecfs27xTcaq 8PBu18gh0UoRVPtaBBHAZh94ZxH16CuvrfRNvW+M3Z0Df4Tuhp05RRqOt8dte8iWCKQYNWE4MRc14 moXqiBPmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jss5k-0006eH-L1; Tue, 07 Jul 2020 18:13:16 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jss5h-0006d6-Sr for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 18:13:14 +0000 Received: by mail-wm1-x341.google.com with SMTP id o8so64584wmh.4 for ; Tue, 07 Jul 2020 11:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v3SJG/oKrNkhQPAH5DvCsSZIxftjRT3Cf/rO54lasVQ=; b=bCRBoKrbpz2rdJ2nV9KaHR11LkMNbRQZQEVMoGlk92r+cnRoIKV0xwny5KmjnouEw2 PGjjYvz0cp3e4NPnqvT2tAUoOV3Naj9K1Bd7pMl4clrjmtJMAhJxBsb4OagAywJxhw0O vIc+B7bV6kYwba5VmkvKBqZXiZQCl4gWoOjho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v3SJG/oKrNkhQPAH5DvCsSZIxftjRT3Cf/rO54lasVQ=; b=Okd1jMGauVpMcbqJtFtnNhkOLicmExJbmfLXV1carUvobWfhWBFiIWbRYiAg7qoC1q HS/AmodYXbJAjDNq2t292lTIYJYXTOl6J8SUo1NNguQLkfhi6kcFDd7c6KLXv4V5wq9k ttIaWNr6MNBovLSaZnDR/NPgA42XGDzjvBDI4slNPkBmhA+vyToijl6YzLHG4YvDN9lo p1A1hPTssLuDcajiSeYfCmK7CLx7Bps8KJwqsL3B6kYe5l18tZAhJrqi5ZO9bQIZHDwf wbDBKEHnNTP6RFRIKs+dOUVB/+DmWxpyBOXMGQJ/akDjqZyZlK5cnuKQsxjshN4Nz1M0 lbhw== X-Gm-Message-State: AOAM531sY46alu+dJhu2YfsXBRxySFxeYvj3HL1MRwIV30wJUYctCJeK 0y61x6mcaG2F3dRJeWWoK0f6Pw== X-Google-Smtp-Source: ABdhPJyY4ArGzU3O1VyBKhNP66gJlaXeKhOfIGNgIYcjZ8G2lNPTEGosc7euLKL3vZCGs4EG+Vg8/Q== X-Received: by 2002:a1c:1d04:: with SMTP id d4mr5754189wmd.156.1594145592650; Tue, 07 Jul 2020 11:13:12 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id q3sm1942110wmq.22.2020.07.07.11.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:13:12 -0700 (PDT) Date: Tue, 7 Jul 2020 18:13:10 +0000 From: Tomasz Figa To: Jonathan Bakker Subject: Re: [PATCH 05/11] media: exynos4-is: Improve support for sensors with multiple pads Message-ID: <20200707181310.GE2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_141313_940257_0C992044 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:44PM -0700, Jonathan Bakker wrote: > Commit 1c9f5bd7cb8a ("[media] s5p-fimc: Add support for sensors with > multiple pads") caught the case where a sensor with multiple pads was > connected via CSIS, but missed the case where the sensor was directly > connected to the FIMC. > > This still assumes that the last pad of a sensor is the source. > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/media-dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Thank you for the patch. Please see my comments inline. > diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c > index 5c32abc7251b..b38445219c72 100644 > --- a/drivers/media/platform/exynos4-is/media-dev.c > +++ b/drivers/media/platform/exynos4-is/media-dev.c > @@ -991,7 +991,8 @@ static int fimc_md_create_links(struct fimc_md *fmd) > > case FIMC_BUS_TYPE_ITU_601...FIMC_BUS_TYPE_ITU_656: > source = &sensor->entity; > - pad = 0; > + /* Assume the last pad is the source */ > + pad = sensor->entity.num_pads - 1; Is 0 really any worse than num_pads - 1? This sounds like quite an ugly hack. Could you iterate over the pads of the sensor entity and explicitly find a source pad instead? Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel