From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97966C433E0 for ; Tue, 7 Jul 2020 18:24:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A12020675 for ; Tue, 7 Jul 2020 18:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dNc8NM+v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bou7iSLd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A12020675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O8FkRZ8Il6VsFwaaS2B37dF64lpPWlaxlzJV6PaeBUk=; b=dNc8NM+v3SxJS1r/Uqih/8gFM QdE+bF8xT9nh6R1DFP+5XJrA8qH85hhc0X++le3+PnWwkM5c7S6AYoYYJOjNyXfHkG5rH0cFytYFe 1xpVeYEUsb+woW+kjjCJFuw9slIHZYkaFQLbzycGgadRUOWfGiQN3bW0Y/ekPhkCmVA9hycPUY6QD kjDGspru8pmooqfsqomC6e97GlforpstYDRR4OzkUQJ9KyNUssF777BLjk0qihV9Dmex+GBMaKtZq msPu5VxXnRBOp83X/03XiMyxgKkcJo0hec+zWSpQELTHjZTHlDMiSaPtKzJc51lRbi/xeQZSWR6tQ N9mvI57lg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jssFb-0007yv-G2; Tue, 07 Jul 2020 18:23:27 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jssFZ-0007yL-JF for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 18:23:26 +0000 Received: by mail-wm1-x344.google.com with SMTP id o8so97721wmh.4 for ; Tue, 07 Jul 2020 11:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZsyQ8jMmYQ+//eOLMX7VRN1oDXj4f3bVCThH0/4XXdI=; b=bou7iSLdxedN67z05Kvhn0bs7V/62M4RXxRpMjNmYppJ6OiFUT3bFt+dlqI9wxOoFd ziojgyBhqT6sjphLhpJOXanj/zqXQY0Nmw+RmdXwtetXmbWNgFKsPf2+2lCda8LhjDlH vweKLhivpqVwBDGPKb+MLxvg+0fGKKu3X3RGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZsyQ8jMmYQ+//eOLMX7VRN1oDXj4f3bVCThH0/4XXdI=; b=tufGJ7qQwfZc7Lnzq6zjqL4ArgYUe0Dli1sG3cLrgPhp1agnN885d/444QYD3aGDfx 3eUnY4LC6i7dQMkHzF7VcPZpfWlezT/Ycz2praBErPH8K5MnomW1kOe/SjXekqS/Y3I9 veoEnlGbLitD3Mq8pYfZlx9KWmo35hCMLcp3+K9zlshArf8o4sCKCf+A1txrWYRb281w x1xRHbvhiYyLSMuholy3mXXMg720GMe20lfo2clJxXx4vqXQ1qlq7wsn0WX96gAs3Zkg /4KcSS2In0Ju4xSD2K507G+LVlaO3u0mn1a4pzQE7DdcVnQgqhiQh3vXJLBECqkK50n1 Z9kA== X-Gm-Message-State: AOAM5325fF0dEjHlaEohgSm3b4JC3rUt6xrfl3Zg+7SVc6+o7RxZREZu dLQB3MYFg0HHBquI92LwcJuC4g== X-Google-Smtp-Source: ABdhPJyjT0eHd4DtTyp0akzx5TjoI2cPq4orG1mC4OS1LTjXrelYXyIhn6aUWELC3RkHTK1QvI9Tpg== X-Received: by 2002:a1c:9e06:: with SMTP id h6mr5160615wme.45.1594146204616; Tue, 07 Jul 2020 11:23:24 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id p17sm1849785wma.47.2020.07.07.11.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:23:24 -0700 (PDT) Date: Tue, 7 Jul 2020 18:23:22 +0000 From: Tomasz Figa To: Jonathan Bakker Subject: Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS Message-ID: <20200707182322.GF2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_142325_702786_4D6D806B X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: > Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") > added support for JPEG capture, but missed setting a register when the > CSIS device wasn't in use. nit: Since this isn't really about using the CSIS device or not, but rather about the interface that the sensor is connected with, could we instead say "when a parallel interface is used"? > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/fimc-reg.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/exynos4-is/fimc-reg.c b/drivers/media/platform/exynos4-is/fimc-reg.c > index 5ce2bdebd424..269a98fca1e8 100644 > --- a/drivers/media/platform/exynos4-is/fimc-reg.c > +++ b/drivers/media/platform/exynos4-is/fimc-reg.c > @@ -606,6 +606,11 @@ int fimc_hw_set_camera_source(struct fimc_dev *fimc, > switch (source->fimc_bus_type) { > case FIMC_BUS_TYPE_ITU_601: > case FIMC_BUS_TYPE_ITU_656: > + if (fimc_fmt_is_user_defined(f->fmt->color)) { > + cfg |= FIMC_REG_CISRCFMT_ITU601_8BIT; > + break; > + } > + > for (i = 0; i < ARRAY_SIZE(pix_desc); i++) { > if (vc->ci_fmt.code == pix_desc[i].pixelcode) { > cfg = pix_desc[i].cisrcfmt; > @@ -707,6 +712,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, > case FIMC_BUS_TYPE_ITU_601...FIMC_BUS_TYPE_ITU_656: > if (source->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */ > cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A; > + if (vid_cap->ci_fmt.code == MEDIA_BUS_FMT_JPEG_1X8) > + cfg |= FIMC_REG_CIGCTRL_CAM_JPEG; Should we also handle MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8 as in the CSI case? The S5C73M3 sensor supports the parallel interface as well. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel