From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B36C433E0 for ; Wed, 8 Jul 2020 12:32:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB0D20720 for ; Wed, 8 Jul 2020 12:32:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KxkAQrDt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB0D20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i5SCYbc1R7ZLTsSXqP2NCUlLF7iT2qqYVoApomwJgy8=; b=KxkAQrDtlPyKxsChHBr+O5/K7 5M9pxI+LXS8YtB4Pri1wgUin13I6LEBoXF7GDQLEQrquYfh4ArnOIV1JQFUe8xu8Ipf43CGKagWd4 Juitm+2xPvVpHmzDIPOKfMv2Dl7zcdSu+JKLvkOX/Ce07x+IkfDAJCICHISAwebUomDzkobMnZVXI uIjzplSyUvK+rwLbNsjJfW8TItEx4YDVLgJSyzrOwwyv5fpTbSjvc0DwkTUUIrVlAOc2pqnvT07MO Vo0zJwUmquToiNgRTCP4vnHcR7lSSazR5yyFPle7st1XGDM5FpZ65eTcvJ9tB+d6WuxywiwxJkYc0 vzzkENnhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt9Ed-00083a-AU; Wed, 08 Jul 2020 12:31:35 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt9EZ-00081o-TN for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 12:31:32 +0000 Received: by mail-ej1-f65.google.com with SMTP id f12so24110958eja.9 for ; Wed, 08 Jul 2020 05:31:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ygzArpvH7RPCySBUWiISobL+c+Ql9Y19rwAtWfABm8U=; b=MQcjyMMNDR0L7nNQ3ROBs5Ee/HS87holpuz3kDEDGDbGxpad0yWxV1L+JvQ3x18bM7 K9nV1664p7qhnFJpON4E56fveSYjawOj3QjS416E2kpoUk21XtLDG3t2EuCBSj27rudl T4BbneNtpZMp0QIeZe5ZPgopb683SbzAzdmZbUTAilWTafDOSE+4g/uzg5cpJgfcMMuj s1oFtxVXY5P1y+xG3h4nazEzbUTHfmNBFJkeOGEjm6Yd7r/iE2VGE1wW3OXxbPQgcdf7 9NIXDEnQFjZBzExUmZ4cjaFZM/uMw2//jDTwH+mHewMEGytymMABKj6chN+Bi/CiaWZk KyCQ== X-Gm-Message-State: AOAM530s9fODfrI1DJkN8Rl4R3ZCz6s5u9Kxl2xoIFSJfoVowXFTn9oH qCT1W9i+AUXtg9Pkrm9C2vmcda+x X-Google-Smtp-Source: ABdhPJx5kRIHY/+y31r0ade1Fiq6aBAnXwe+tb2On86JyklMR4m3oRE71PGbxQPALItMwlHHg+k/VQ== X-Received: by 2002:a17:907:1190:: with SMTP id uz16mr50778637ejb.385.1594211489188; Wed, 08 Jul 2020 05:31:29 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id q3sm23853098eds.41.2020.07.08.05.31.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Jul 2020 05:31:28 -0700 (PDT) Date: Wed, 8 Jul 2020 14:31:26 +0200 From: Krzysztof Kozlowski To: Anand Moon Subject: Re: [PATCH v3] phy: samsung: Use readl_poll_timeout function Message-ID: <20200708123126.GA29033@kozik-lap> References: <20200707095908.372-1-linux.amoon@gmail.com> <20200707113645.GA27280@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_083131_965256_69A6050D X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Linux Kernel , Kishon Vijay Abraham I , Vinod Koul , Kukjin Kim , linux-arm-kernel , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 08, 2020 at 01:59:46PM +0530, Anand Moon wrote: > > Still you did not mention that you convert the function to use sleeping > > primitive. You also did not mention whether it is actually allowed in > > this context and I am not sure if you investigated it. > > > OK, I am not sure how to resolve your query. > I learned some new things. > > So here are some points. > -- Yes read_poll_timeout internally used might_sleep if sleep_us != 0 > under some condition. > -- None of the code in phy-exynos5-usbdrd.c is called using kernel > synchronization > methods like spinlock / mutex. More important is rather the call to calibrare() as this is the place where affected code is used. It is not only about synchronisation primitives used in the driver but also in the phy core. I guess there should not be a problem. I just stated the fact that you did not mention anything about it. > -- I have checked this function is called non atomic context. Great! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel