From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B9BC433DF for ; Wed, 8 Jul 2020 13:27:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A026D20720 for ; Wed, 8 Jul 2020 13:27:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pXXoevPO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A026D20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MnUBhRfoTFTe8TEuBcUkoqNEZvmZj72OmhNQO6O5HCM=; b=pXXoevPODn55+8EAqToeY0hmc 7BPQ0zkAq4RU2wDopYPrga2EfUVdL9jV58nSRR/OBv3DAA2fwc8cjnLfVe4JLvlZoOvcHUhIWo/eN 6qDl2GVyyIszlIN0B9j30mAwMXXObsNyOG+vQNUidnl/1Tj+yz4YWza5Ts+r37v9rUvyDxJEqES0c U2PH0OIZ6UR4LPc0RwfruvkNrQ3p9QhJT9nzMtu4iSyHCb5oivmm1sYeU2PsPMpV4twgVqjDcT/Fc X8YdOmjozkPZNFRbRHhC9NdxUYRS2n1DQCiqn9knpbQNyMf86BYZUFkJWUV5fzQr62Ug1relpYWNG f/NzGem1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtA4o-0007CU-C4; Wed, 08 Jul 2020 13:25:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtA4k-0007B6-Vi for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 13:25:28 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFB1820720; Wed, 8 Jul 2020 13:25:22 +0000 (UTC) Date: Wed, 8 Jul 2020 14:25:20 +0100 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH V4 2/3] mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf() Message-ID: <20200708132520.GD6308@gaia> References: <1594004178-8861-1-git-send-email-anshuman.khandual@arm.com> <1594004178-8861-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1594004178-8861-3-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_092527_366462_51FC5321 X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, justin.he@arm.com, linux-doc@vger.kernel.org, Jonathan Corbet , Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , "H. Peter Anvin" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Paul Mackerras , Andy Lutomirski , Michael Ellerman , Borislav Petkov , akpm@linux-foundation.org, Will Deacon , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2020 at 08:26:17AM +0530, Anshuman Khandual wrote: > There are many instances where vmemap allocation is often switched between > regular memory and device memory just based on whether altmap is available > or not. vmemmap_alloc_block_buf() is used in various platforms to allocate > vmemmap mappings. Lets also enable it to handle altmap based device memory > allocation along with existing regular memory allocations. This will help > in avoiding the altmap based allocation switch in many places. To summarize > there are two different methods to call vmemmap_alloc_block_buf(). > > vmemmap_alloc_block_buf(size, node, NULL) /* Allocate from system RAM */ > vmemmap_alloc_block_buf(size, node, altmap) /* Allocate from altmap */ > > This converts altmap_alloc_block_buf() into a static function, drops it's s/it's/its/ > entry from the header and updates Documentation/vm/memory-model.rst. > > Cc: Jonathan Corbet > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Andrew Morton > Cc: linux-doc@vger.kernel.org > Cc: x86@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Tested-by: Jia He > Suggested-by: Robin Murphy > Signed-off-by: Anshuman Khandual With the fallback argument dropped, the patch looks fine to me. Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel