From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D393FC433DF for ; Wed, 8 Jul 2020 16:21:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A10372067D for ; Wed, 8 Jul 2020 16:21:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qQ9DNbdy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A10372067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2ISTbE9rdwq4txJPixv2oUeLw/LHkIAa0kJ7De8sHd4=; b=qQ9DNbdyTDr27rgAJwU1Ji9Fe hV889TX6xgpoeWjNsVqQyROVa3wulN4lKWqE8f7HiyPzOKaog1S0otRmiQTo48bdKRn6i0wko9QUc Kh3iT16/8gZoyYXxe2SE0Xlk9ylMZU98/3eQuvUP9ELEmFwpaRg+IH/dmhlmGSE377ipWiThg+crA kmrvpVElCXQN63jDqUu9HuXYlBgKehj1Pu0u1nYU8nkYO87zMALG1D0IDnik5WqHzYDazrnXIXyZY 3MWnRXlF3piK+sqe431I86GEnqKowffUCiV8NjYRYlNvz0yvZwCpx2KPZeWACHZtV88M1D1/xfF1x dA67Lf8iQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtCo7-0001Pe-Uu; Wed, 08 Jul 2020 16:20:28 +0000 Received: from mga17.intel.com ([192.55.52.151]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtCo4-0001Ny-DU for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 16:20:25 +0000 IronPort-SDR: 46jeo58H6HeZYZawcupZ9Vl2oGmKn/uLtfucn5DHenBm+ceJB3/fPB/LyBH97MnEOcoYZODhi1 QKMhGQP4dCgw== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="127925525" X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="127925525" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 09:20:22 -0700 IronPort-SDR: gNf7C9Z2YX16Oxep5C8FDryKYcNh04YCXz9q1EE5RqNXBD0PzTqhyFoji8C62lK+bDl3ZWfBux m0qh6WBLiqrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="283846524" Received: from jschirra-mobl.ger.corp.intel.com (HELO localhost) ([10.249.47.201]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2020 09:20:18 -0700 Date: Wed, 8 Jul 2020 19:20:17 +0300 From: Jarkko Sakkinen To: Masahisa Kojima Subject: Re: [PATCH v3 0/2] synquacer: add TPM support Message-ID: <20200708162017.GB549022@linux.intel.com> References: <20200708131424.18729-1-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708131424.18729-1-masahisa.kojima@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_122024_662304_E6EDEC4B X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ardb@kernel.org, jgg@ziepe.ca, peterhuewe@gmx.de, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > This adds support for driving the TPM on Socionext SynQuacer platform > using the driver for a memory mapped TIS frame. > > v3: > - prepare new module to handle TPM MMIO access on SynQuacer platform > > v2: > - don't use read/write_bytes() to implement read/write16/32 since that uses > the wrong address > > Cc: jarkko.sakkinen@linux.intel.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: ardb@kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-integrity@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: peterhuewe@gmx.de > Cc: jgg@ziepe.ca > > Masahisa Kojima (2): > tpm: tis: add support for MMIO TPM on SynQuacer > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > .../devicetree/bindings/trivial-devices.yaml | 2 + > drivers/char/tpm/Kconfig | 12 ++ > drivers/char/tpm/Makefile | 1 + > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > 4 files changed, 211 insertions(+) > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > -- > 2.20.1 > Overally the code looks great. You've run it through checkpatch.pl? /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel