From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51BDC433E0 for ; Thu, 9 Jul 2020 08:42:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A23FD20672 for ; Thu, 9 Jul 2020 08:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qv8LhYd8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A23FD20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R2WTA1cJp9YM2nj9aUMizpeeIQkFpe4nb1cLo0mV/hE=; b=qv8LhYd8HCzcrs8tr5nnLIZud XyQ2Yi+jvYyXRdR/vxhzq3IBFr6ZOFjebcNDQJMs0GlyYZ+Vy6uqqS4ZrctqVghcMwiyMxD3mGx0w Fv4WJKl1c7mcBD8ge8gQXovhJ/ggwhvNvJ4dFlkxYzSAqLTM99Qva4xbtycUXAUpVRh/Rf/IKnX01 Ue6DjgIjqGn/fdJqk+GAb7Jit3D+AI+FDaIjmXovnFmRCRhE6J4Y/Yy5493F6Pnv7SenrBGn1vWGc WL29mwU0eWGdNO2YEQM5E4bB/xDwe0a1Rf9cWYtscJCwj8Eznvpvn3rvi0fnzMk5Zg2z7uvpYdkL2 nAoKhVX0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtS5e-0003Ov-Da; Thu, 09 Jul 2020 08:39:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtS5b-0003OI-UW for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 08:39:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4F1131B; Thu, 9 Jul 2020 01:39:30 -0700 (PDT) Received: from bogus (unknown [10.37.8.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CE393F887; Thu, 9 Jul 2020 01:39:28 -0700 (PDT) Date: Thu, 9 Jul 2020 09:39:25 +0100 From: Sudeep Holla To: Dien Pham Subject: Re: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Message-ID: <20200709083925.GC31544@bogus> References: <20200709081705.46084-1-sudeep.holla@arm.com> <20200709081705.46084-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_043932_043474_5D52FFB8 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , "linux-kernel@vger.kernel.org" , Sudeep Holla , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2020 at 08:26:54AM +0000, Dien Pham wrote: > Hi Sudeep, > > Thanks for your patch. > > >-----Original Message----- > >From: Sudeep Holla > >Sent: Thursday, July 9, 2020 3:17 PM > >To: linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org; Stephen Boyd > >Cc: Sudeep Holla ; linux-kernel@vger.kernel.org; Michael Turquette ; Dien Pham > >Subject: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates > > > >Currently we are not initializing the scmi clock with discrete rates correctly. We fetch the min_rate and max_rate value only for clocks with ranges and ignore the ones with discrete rates. This will lead to wrong initialization of rate range when clock supports discrete rate. > > > >Fix this by using the first and the last rate in the sorted list of the discrete clock rates while registering the clock. > > > >Link: https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com > >Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") > >Reported-by: Dien Pham > >Signed-off-by: Sudeep Holla > >--- > > drivers/clk/clk-scmi.c | 22 +++++++++++++++++++--- > > 1 file changed, 19 insertions(+), 3 deletions(-) > > > >Hi Stephen, > > > >If you are fine, I can take this via ARM SoC along with the change in firmware driver. However it is also fine if you want to merge this independently as there is no strict dependency. Let me know either way. > > > >v1[1]->v2: > > - Fixed the missing ; which was sent by mistake. > > I tested the patch, > I is ok and can fix my issue. > Thanks for testing. Can I add ? Tested-by: Dien Pham -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel