From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84554C433DF for ; Thu, 9 Jul 2020 09:20:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 514E8206A1 for ; Thu, 9 Jul 2020 09:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hUnpJEIW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 514E8206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k1kRYmeHBhwOZ8UlwgHbHRXRIdM2Vf7H5n8hoCiARZ0=; b=hUnpJEIWxNujW7fnQgRrr1aD9 YscgHNRqLsNAqX/V6C0K5sGpoxJ+/QeOIe3cIabJ8oeGfID+RzJRA/AMGIE0+25kLMPgmMJ/thLHl Vyqsfy6wpo/0GlMISQpGWEzDZVMgPVbqHEHoyK3KOCUIwulAssGIVBQlSMQ4FtcaSuk5a+4NnTvUj 9YGNVetp8USyqI4aitCGwUZhfFs6Bfk+3itn0wjGD5C62T2LX87nnU/8s7gwucJ49nLK02lm2Xuri tGvT25xL3wucBE/piPz6s5u8bN2aWtN2H9HUnvqHmzD+EnwpASNEABsr6K7h66L+EEqChBVOWCimZ n1RURP57Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtSiJ-00053l-Dr; Thu, 09 Jul 2020 09:19:31 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtSiG-00052i-Pk for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 09:19:29 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06992P92149548; Thu, 9 Jul 2020 05:18:25 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 325n5eh6s2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 05:18:25 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 06992TWC149958; Thu, 9 Jul 2020 05:18:24 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 325n5eh6r2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 05:18:24 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0699A2Fw014205; Thu, 9 Jul 2020 09:18:22 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03ams.nl.ibm.com with ESMTP id 325k1vgqjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 09:18:22 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0699IJQc54919672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Jul 2020 09:18:20 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB9DCAE05A; Thu, 9 Jul 2020 09:18:19 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5DF8AE045; Thu, 9 Jul 2020 09:18:16 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.204.222]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 9 Jul 2020 09:18:16 +0000 (GMT) Date: Thu, 9 Jul 2020 12:18:15 +0300 From: Mike Rapoport To: Matthew Wilcox Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory Message-ID: <20200709091815.GF781326@linux.ibm.com> References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-5-justin.he@arm.com> <20200709021104.GZ25523@casper.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200709021104.GZ25523@casper.infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-09_04:2020-07-08, 2020-07-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 spamscore=0 impostorscore=0 mlxscore=0 adultscore=0 suspectscore=1 mlxlogscore=603 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007090068 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_051928_911432_FB726745 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, Michal Hocko , "H. Peter Anvin" , Will Deacon , Thomas Gleixner , Jia He , Yoshinori Sato , linux-nvdimm@lists.01.org, linux-sh@vger.kernel.org, Vishal Verma , Masahiro Yamada , x86@kernel.org, Kaly Xin , Ingo Molnar , Fenghua Yu , Chuhong Yuan , Borislav Petkov , Andy Lutomirski , Jonathan Cameron , Dave Jiang , Dan Williams , linux-arm-kernel@lists.infradead.org, Tony Luck , Baoquan He , linux-kernel@vger.kernel.org, Andrew Morton , Logan Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Moreover, I think that patches 1-4 can be merged into one. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel