From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022DDC433DF for ; Thu, 9 Jul 2020 13:05:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C28F52073A for ; Thu, 9 Jul 2020 13:04:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CDK+PIEL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sh7ZUwSl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C28F52073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cj4FfXEist2wc7fAMjC+Fil2OtjyuReTnZN9EL6k8l8=; b=CDK+PIELdnl2d29NIdpp+TnPq KGAYTDo/9smHP7gaFCXQUzVFOP7qDys0Q/NopSod/iZDzwydL5ERw+9wmKzvFVS+Fikj3Sl1VsPya JnVeQ5aqYwW25TjNOKxq0C8qdZDEAMOL0ONWtPAtgehi4V2nnQQR9KjD706veePAEsl71w53CbIZi t3G3DtywXThALjB10GKd3TM1VtwhNaUcRvYU/KsruqxiDpC3AATR8356FqC9ZKOWzT/6N5K+ewb2X /KwYTiyWW2Mrq/37kMzbdJ6k/xEkUkIO3GNIydBpLCFSG6a4kt0VpHs7Sfjt/neW2ZsYaG8JdW0EI BtQyVnjQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtWDS-00028b-LA; Thu, 09 Jul 2020 13:03:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtWDQ-00027z-U3 for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 13:03:53 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F3A32073A; Thu, 9 Jul 2020 13:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594299832; bh=UTe8ysn/7BxBU5gjUJrUUfNemC796N0wEdffOVvVwgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sh7ZUwSliDHdJhxoMt/FEVMLE8gsRUpI2ueidTuqhakXh3hRLziviFHdt3gwGVJqZ chA3hs1uKNPZKhGA8rI5m+xOQLTD8OiJ6F7xIDafXbj7P17uJbwFECdWkqHkHXb0gU HIXsvQMGmHt6yZKPp1ZvS69d+CwYldlBQqeoa+4c= Date: Thu, 9 Jul 2020 14:03:48 +0100 From: Will Deacon To: Kevin Hao Subject: Re: [PATCH v2 0/2] arm64: Fix the call trace when running kgdb test suite Message-ID: <20200709130346.GC28772@willie-the-truck> References: <20200417103212.45812-1-haokexin@gmail.com> <159424108956.2036212.1249632670220812634.b4-ty@kernel.org> <20200709125504.GA244448@pek-khao-d2.corp.ad.wrs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200709125504.GA244448@pek-khao-d2.corp.ad.wrs.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_090353_146464_F0018275 X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2020 at 08:55:04PM +0800, Kevin Hao wrote: > On Wed, Jul 08, 2020 at 11:02:34PM +0100, Will Deacon wrote: > > On Fri, 17 Apr 2020 18:32:10 +0800, Kevin Hao wrote: > > > This fixes a call trace when running the kgdb test suite: > > > # echo kgdbts=V1 > /sys/module/kgdbts/parameters/kgdbts > > > > > > v2: > > > - Add a patch to fix a typo in el1_dbg() > > > - Use the method as suggested by Mark. > > > > > > [...] > > > > Applied to arm64 (for-next/fixes), thanks! > > > > [1/1] arm64: entry: Fix the typo in the comment of el1_dbg() > > https://git.kernel.org/arm64/c/b8c1c9fe6a04 > > How about patch 2 ("arm64: debug: Always update the IRQ tracing in debug_exception_enter())"? > It has been dangled in the mail list for almost 3 months without any explicitly objections. No, sorry, I really think it's the wrong direction of travel. Its adding bodges to try to handle the fact that we disabled interrupts during the step, and we really shouldn't be doing that (See my reply to Doug). As I said, I would prefer some feedback on my proposal for dealing with this properly [1] rather than more futile attempts to build on top of the mess that we have at the moment. Will [1] https://lore.kernel.org/r/20200626095551.GA9312@willie-the-truck _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel