From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B8FC433E0 for ; Thu, 9 Jul 2020 21:47:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C982E20774 for ; Thu, 9 Jul 2020 21:47:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="difmB/+g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C982E20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fMFA3jduhhK4T95khUgtq/R5+zE8kfpVH5/1kJW6dZY=; b=difmB/+gc6ySQeeAs2e/aFu/q agtq5kQ8KlNdGYyFWyMegfnygP0sexPAVboEyjxtTeouXablFWu+sPRaYFqZ4FOHLiR/7Id/GEp3Y lGjMSZ+/UwpIeniEWNaxmd3wnN+QSdiwIj+69NlNyw5tFKXsxs3po9WtTbHtABlMt0wxD1GLYDxWZ ZVLG9f8vf8ncnMEZMmdqD7j6gUmitXcYaZ1+pqZ/q1JxPobOvi7iUaUnwdQ5GJLrdR6SN0+PI4dMK clBbeLY2PP+kFFtDvJJ5HqnGKRQkQbs5fAEESkcE1IVUF8gUsk3QSG82DKPv5tXLFyAR4XGFgyMc1 oCQtokKYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jteMh-0004LH-5W; Thu, 09 Jul 2020 21:45:59 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jteMf-0004Kv-HZ for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 21:45:58 +0000 Received: by mail-io1-f67.google.com with SMTP id k23so3903089iom.10 for ; Thu, 09 Jul 2020 14:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cm4M9dwes8x03niEEdU7bFOP7a6MNWa2UIuDCHSOETA=; b=D0H5pe3lnvyYBkewqX7j5EWirXoE3MLHFq5ZeuULospvwzDHSjnF1HsbCYLPWNyHd+ o33+fKjjMNsomg50p0mjXPLRcBn5g54ZfAZsO03i0wUKji0KxEW1mB1L1AXbu892Aski uYRdfHxgRdnzsOeLr9ANdo4Juitr2e7IalzUWa9fxhZWODT/UpYQ4YlXzrkJwX36R7Gr dz6U+//yre7gr7ZKlmvchHqYUmZA7dPZKf5tk/SI42r7FdNfLzKnlTFlN0WUaTuBZmqH AP+VzFxSsL8PkKROQgOnmmGkKpc6GX8rABieq55BLIsUGb7n4QxNLqGUKLk5wi52XPlt 3GRQ== X-Gm-Message-State: AOAM5316PVb0joJykwkQpn5nan8av2S4szVPOSzDQsh/F29VfBLBSWjn GUGBVH1i/z7qIZ91o0l8Bg== X-Google-Smtp-Source: ABdhPJxMyLOsUDzCdfKL53+BYbKXk7Kr9ScXgbUfbqOa4CSYjACMyINv95ZFOb6Qxjd9sFBEAddj1Q== X-Received: by 2002:a05:6638:25cf:: with SMTP id u15mr65297352jat.19.1594331156767; Thu, 09 Jul 2020 14:45:56 -0700 (PDT) Received: from xps15 ([64.188.179.254]) by smtp.gmail.com with ESMTPSA id t6sm2725359ioi.20.2020.07.09.14.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 14:45:56 -0700 (PDT) Received: (nullmailer pid 942496 invoked by uid 1000); Thu, 09 Jul 2020 21:45:55 -0000 Date: Thu, 9 Jul 2020 15:45:55 -0600 From: Rob Herring To: Kishon Vijay Abraham I Subject: Re: [PATCH v6 08/14] PCI: cadence: Fix updating Vendor ID and Subsystem Vendor ID register Message-ID: <20200709214555.GA939109@bogus> References: <20200708093018.28474-1-kishon@ti.com> <20200708093018.28474-9-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708093018.28474-9-kishon@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_174557_613940_6764263F X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tom Joseph , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 08, 2020 at 03:00:12PM +0530, Kishon Vijay Abraham I wrote: > Commit 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe > controller") in order to update Vendor ID, directly wrote to > PCI_VENDOR_ID register. However PCI_VENDOR_ID in root port configuration > space is read-only register and writing to it will have no effect. > Use local management register to configure Vendor ID and Subsystem Vendor > ID. > > Fixes: 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe controller") > Reviewed-by: Rob Herring > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/cadence/pcie-cadence-host.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c > index 10127ea71b83..8935f7a37e5a 100644 > --- a/drivers/pci/controller/cadence/pcie-cadence-host.c > +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c > @@ -82,6 +82,7 @@ static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc) > { > struct cdns_pcie *pcie = &rc->pcie; > u32 value, ctrl; > + u32 id; > > /* > * Set the root complex BAR configuration register: > @@ -101,8 +102,12 @@ static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc) > cdns_pcie_writel(pcie, CDNS_PCIE_LM_RC_BAR_CFG, value); > > /* Set root port configuration space */ > - if (rc->vendor_id != 0xffff) > - cdns_pcie_rp_writew(pcie, PCI_VENDOR_ID, rc->vendor_id); If this is read-only, then... > + if (rc->vendor_id != 0xffff) { > + id = CDNS_PCIE_LM_ID_VENDOR(rc->vendor_id) | > + CDNS_PCIE_LM_ID_SUBSYS(rc->vendor_id); > + cdns_pcie_writel(pcie, CDNS_PCIE_LM_ID, id); > + } > + > if (rc->device_id != 0xffff) > cdns_pcie_rp_writew(pcie, PCI_DEVICE_ID, rc->device_id); ...isn't this read-only too? > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel