From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD705C433E0 for ; Thu, 9 Jul 2020 22:12:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A809420672 for ; Thu, 9 Jul 2020 22:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3K8LgCdS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A809420672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ePqCphExYZ1HyYzeUPdVFuWBnsCGNvlzOtqelh/Q6Yc=; b=3K8LgCdSWjWXb2AA9DzP8gm3U aPNqmIP5GE7qCGQB8S4m2CdptJeHWeRbKyMxaxIszo7QIJg3j9uRxeE2/5pJMpv9qSA2YI49MAFt6 mIPPdSFFB1Qv9BowUzTPRos3aCd9d9YUTFN0jj2Fs7Iyl6TXe5iroHOuXp5ClHw8/KY/Oz6bjNEwC Dvq/UbLU0Gbmimab+je55mKBjdXNATwrlYO/kbtKXtCgy5ywNIa2kBqxE8vhH2yKnrvRb+fnEPJUm oHxn6LowAxyipqwYCkJ9aVyJTW6bTqSnQ6fs5lnlac4ukncBznvxCvKOxMOvj0H5i1hMHpT9LypXO XKIfrtCLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtel7-0006vY-R2; Thu, 09 Jul 2020 22:11:13 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtel4-0006us-H7 for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 22:11:11 +0000 Received: by mail-io1-f66.google.com with SMTP id q74so4021407iod.1 for ; Thu, 09 Jul 2020 15:11:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=bT3++BEYrjJIhXhzxTXtHnkKclhpqH+T88s6CFRclJo=; b=ERD6VsEmdTzXsnxieTliEuC/E0XPKmp8BSFbFwyQJB49y5nkrsiXeIOcolx9mOHBDO oN7PX8enMM+9saluFKkBW4iOzOHZeA16b1T1v4hZo+yfBcqZNAIlUxDhMyEvHICMVryU BRuEU90vNBCb9hVITR95AWIwYUVWsoY+P2H3UwqffC4a5/0YoceUFS5zUFbqYGxovofr QgKaKWjOFFd7lxjPb8Mb+3KFP3PKTeTr9dmDAsAfxGl2clZ0rDuUsbBpentQCpk4YvcX wgVQWWowgdmE0D+Uyx4K2SEP3yc2fwPMels3xqp3iut36AYnhh+h6I7ooT39O2KQMhzJ 3gaQ== X-Gm-Message-State: AOAM530hKFEIbzHbHdWLUopsQHuX1U3JxQivmcYfD0nbzY2yaQDJVnJm EDkyR6XOhwMnEQyV4yOjg71Vr7uL7A== X-Google-Smtp-Source: ABdhPJz4lRiz70zmxalQUoUYbGE8Rm547bR48XMoyyuw4D0hqYCx9U1AiTKXy2iCcGXC/viEMPy/cA== X-Received: by 2002:a02:b0d5:: with SMTP id w21mr63608081jah.27.1594332669694; Thu, 09 Jul 2020 15:11:09 -0700 (PDT) Received: from xps15 ([64.188.179.254]) by smtp.gmail.com with ESMTPSA id o7sm2824483ioo.4.2020.07.09.15.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 15:11:09 -0700 (PDT) Received: (nullmailer pid 982246 invoked by uid 1000); Thu, 09 Jul 2020 22:11:05 -0000 Date: Thu, 9 Jul 2020 16:11:05 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Subject: Re: [PATCH v5 1/2] dt-bindings: phy: add bcm63xx-usbh bindings Message-ID: <20200709221105.GA976808@bogus> References: <20200619100035.4032596-1-noltari@gmail.com> <20200619100035.4032596-2-noltari@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200619100035.4032596-2-noltari@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_181110_592149_DCF253D6 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com, gregkh@linuxfoundation.org, simon@fire.lp0.eu, alcooperx@gmail.com, linux-kernel@vger.kernel.org, krzk@kernel.org, kishon@ti.com, vkoul@kernel.org, bcm-kernel-feedback-list@broadcom.com, p.zabel@pengutronix.de, jonas.gorski@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 19, 2020 at 12:00:34PM +0200, =C1lvaro Fern=E1ndez Rojas wrote: > Document BCM63xx USBH PHY bindings. > = > Signed-off-by: =C1lvaro Fern=E1ndez Rojas > Reviewed-by: Florian Fainelli > --- > v5: no changes. > v4: conditionally require 1/2 clocks and fix clock/reset values. > v3: no changes. > v2: phy-cells changed to 1. > = > .../bindings/phy/brcm,bcm63xx-usbh-phy.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/brcm,bcm63xx-us= bh-phy.yaml > = > diff --git a/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.= yaml b/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml > new file mode 100644 > index 000000000000..f267da6193a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/brcm,bcm63xx-usbh-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: BCM63xx USBH PHY > + > +maintainers: > + - =C1lvaro Fern=E1ndez Rojas > + > +properties: > + compatible: > + enum: > + - brcm,bcm6318-usbh-phy > + - brcm,bcm6328-usbh-phy > + - brcm,bcm6358-usbh-phy > + - brcm,bcm6362-usbh-phy > + - brcm,bcm6368-usbh-phy > + - brcm,bcm63268-usbh-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: usbh > + > + resets: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - "#phy-cells" You need: additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - brcm,bcm6318-usbh-phy > + - brcm,bcm63268-usbh-phy > + then: > + properties: > + clocks: > + maxItems: 2 This doesn't work. The main schema will also be applied and it says = there's 1. The main schema has to cover all the cases and then if/then = schemas add constraints. > + clock-names: > + items: > + - const: usbh > + - const: usb_ref > + - if: > + properties: > + compatible: > + enum: > + - brcm,bcm6318-usbh-phy > + - brcm,bcm6328-usbh-phy > + - brcm,bcm6362-usbh-phy > + - brcm,bcm63268-usbh-phy > + then: > + properties: > + power-domains: > + maxItems: 1 > + required: > + - power-domains > + > +examples: > + - | > + usbh: usb-phy@10001700 { > + compatible =3D "brcm,bcm6368-usbh-phy"; > + reg =3D <0x10001700 0x38>; > + clocks =3D <&periph_clk 15>; > + clock-names =3D "usbh"; > + resets =3D <&periph_rst 12>; > + #phy-cells =3D <1>; > + }; > -- = > 2.27.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel