From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC38EC433DF for ; Fri, 10 Jul 2020 08:03:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD8482078D for ; Fri, 10 Jul 2020 08:03:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I7amvdGP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD8482078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EfdVEuSCs26ZjuzU95/8tNXSH55cCYHtSC33pT1BymQ=; b=I7amvdGPxu5bXUQeO4gE/E9o/ yTWpG1XvrGszrRzKnXjjpA3bDKNACwzucdTYAqlwr6hcKRlNUe7N9xhb2pVOQsjPkxx2lukADInlG 6A5kg4QhrzMgYTvAi5vrjIZc0JoDAkAJCAP2ccQqMf6fqikYI2+Sm6ptJgCv09QFJGjsUyu4aOg51 A8coxJCTiZUMfIICk9LIwEKFMZOFCUNwQwgFD6SvYEieRvrCmd8XT8WWTdR2v7K4DM2HT9xxGwpkm 6VuPE9p/HchpFGH2O2wBm1v5clipWwPbPjB8zXDpyFsyEzzykTznPCpr1eCeiZ8JqFnoGTEMEFqTb WsxfTjkwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtnyN-0005Yh-8u; Fri, 10 Jul 2020 08:01:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtnyE-0005WB-GI for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 08:01:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0958031B; Fri, 10 Jul 2020 01:01:22 -0700 (PDT) Received: from bogus (unknown [10.37.8.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B2FB3F9AB; Fri, 10 Jul 2020 01:01:18 -0700 (PDT) Date: Fri, 10 Jul 2020 09:01:16 +0100 From: Sudeep Holla To: Paul Murphy Subject: Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem Bay mailbox Message-ID: <20200710075931.GB1189@bogus> References: <20200616155613.121242-1-daniele.alessandrelli@linux.intel.com> <20200616155613.121242-3-daniele.alessandrelli@linux.intel.com> <20200708203428.GB31671@bogus> <491f994c6f87a542e49fe37c8a75ab46f1b3712b.camel@linux.intel.com> <537a4c$cobr4j@orsmga004-auth.jf.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <537a4c$cobr4j@orsmga004-auth.jf.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_040122_647726_3EDCA1BF X-CRM114-Status: GOOD ( 33.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Paul Murphy , Arnd Bergmann , Catalin Marinas , Jassi Brar , linux-kernel@vger.kernel.org, Dinh Nguyen , Rob Herring , Sudeep Holla , Olof Johansson , Daniele Alessandrelli , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2020 at 02:28:10PM +0100, Paul Murphy wrote: > > On 7/9/20 13:23, Daniele Alessandrelli wrote: > > Hi Sudeep, > > > > Thanks for your review. > > > > On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote: > > > On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli > > > wrote: > > > > From: Paul Murphy > > > > > > > > Keem Bay SoC has a ARM trusted firmware-based secure monitor which > > > > acts > > > > as the SCP for the purposes of power management over SCMI. > > > > > > > > This driver implements the transport layer for SCMI to function. > > > > > > > Please use the smc transport support in > > > driver/firmware/arm_scmi/smc.c > > > for this. You don't need mailbox support for SMC/HVC. Basically you > > > don't need this driver at all and you have everything you need to > > > support > > > what you want. > > > > > > Let me know if you face issues. > > > > > Sorry, we didn't know about the SMC transport support for SCMI. Looks > > like it was added only recently, while our driver was already developed > > and waiting to be upstreamed. > > > > I agree that we can drop this driver and switch to the SMC transport as > > you suggested, but I think we'll have to modify our bootloader SiP > > service slightly. Paul, can you elaborate? > > > > Just one question. > > In our patch, we pass the shared memory address as the second argument of > the SiP service, as it means we don't have to hardcode that in our firmware. > Sudeep, do you know if it was intentional in smc_send_message() to leave > that out? If we leave it out, we are requiring the secure monitor to > hardcode the shared memory address. > Please post a patch adding the address as 2nd parameter. Cc Peng Fan from NXP who is the original author of the file. I was also wondering why have I not added the address when I extended support for multiple channel/shmem with smc/hvc. One key point here is that firmware *must not* return INVALID PARAMETER and *must* ignore it. May be we can add a note while adding that the firmware can ignore that parameter if it supports only one channel && hardcoded in the firmware. It needs to be PA as obtained from the DT. Since it is custom SIP id, it needs to be well documented. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel