From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
thellstrom@vmware.com, willy@infradead.org,
yang.shi@linux.alibaba.com, anshuman.khandual@arm.com,
aneesh.kumar@linux.ibm.com, thomas_os@shipmail.org,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
linux-mm@kvack.org, peterx@redhat.com,
kirill.shutemov@linux.intel.com,
Dmitry Osipenko <digetx@gmail.com>,
akpm@linux-foundation.org, vbabka@suse.cz
Subject: Re: [Patch v4 0/4] mm/mremap: cleanup move_page_tables() a little
Date: Fri, 10 Jul 2020 11:14:36 +0300 [thread overview]
Message-ID: <20200710081436.3f75omeq5xpjeoc6@box> (raw)
In-Reply-To: <20200710011410.GC51939@L-31X9LVDL-1304.local>
On Fri, Jul 10, 2020 at 09:14:10AM +0800, Wei Yang wrote:
> On Thu, Jul 09, 2020 at 10:38:58PM +0300, Dmitry Osipenko wrote:
> >08.07.2020 12:50, Wei Yang пишет:
> >> move_page_tables() tries to move page table by PMD or PTE.
> >>
> >> The root reason is if it tries to move PMD, both old and new range should be
> >> PMD aligned. But current code calculate old range and new range separately.
> >> This leads to some redundant check and calculation.
> >>
> >> This cleanup tries to consolidate the range check in one place to reduce some
> >> extra range handling.
> >>
> >> v4:
> >> * remove a redundant parentheses pointed by Kirill
> >>
> >> v3:
> >> * merge patch 1 with 2 as suggested by Kirill
> >
> >> * add patch 4 to simplify the logic to calculate next and extent
> >
> >Hello, Wei!
> >
> >Unfortunately you re-introduced the offending change that was fixed in
> >v2 and today's next-20200709 on ARM32 is broken once again:
> >
> >BUG: Bad rss-counter state mm:db85ec46 type:MM_ANONPAGES val:190
> >
>
> Ah, my bad, I forget the error we met last time. It is the different format of
> pmd_addr_end.
>
> Sorry for that.
>
> @ Kirill
>
> If you agree, I would leave the extent/next calculation as it is in patch 3.
Okay.
--
Kirill A. Shutemov
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-10 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200708095028.41706-1-richard.weiyang@linux.alibaba.com>
2020-07-09 19:38 ` [Patch v4 0/4] mm/mremap: cleanup move_page_tables() a little Dmitry Osipenko
2020-07-10 1:14 ` Wei Yang
2020-07-10 8:14 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710081436.3f75omeq5xpjeoc6@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=digetx@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=sean.j.christopherson@intel.com \
--cc=thellstrom@vmware.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox