From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EE0C433DF for ; Fri, 10 Jul 2020 12:46:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 704942077D for ; Fri, 10 Jul 2020 12:46:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vMStjjaX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 704942077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D8Yl4IHHkDRx4bTWL1EAcbfV5VAcAIXN65fHEVYVRaI=; b=vMStjjaXhrqJOPYrE5EhCl03K sW+7QRzGVqSFmyQ9GMszXbjsJ3DdLSM0rnFDavkB/YfOA9RKAHKY1dXwSYE/WNC+whv9SV1ia70XZ RR7QKBHtFMCpBqRwkLgesC1p9goR1Vm9wEuV6Q5OEM3i6o+IeyIREJCDbegIgL3yFG19Ft553tZE4 9Z/KnqckVDPpvmmbAaCLs70d1wnkhN9wmwWNWGUP4bSuMdB3YUtyKus94Yu90UyqbWLG6s//6zUOH 79joqKHOq6uU5fv1DQVX/Ir+vFx2rNW24+XXRZsMcGXUAW6TzY/8j1VmxS9Vve1DsOQ2aiXmuKWNV +5Z77rvFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtsOx-0004g0-1G; Fri, 10 Jul 2020 12:45:15 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtsOu-0004fQ-74 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 12:45:13 +0000 Received: by mail-ed1-f68.google.com with SMTP id g20so4557708edm.4 for ; Fri, 10 Jul 2020 05:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ABCar9XaLCL6nQFaJkwQvjmy7wFbtvMLNqM9yovrz04=; b=cz7f2025K7tdR7LRUlySSyjZDNTR8YnFYndK3NhrBv84Rp1032FjXA1DkhArqiukIi lufWSeEk1F6FYL0J/1e00sRiUhIWcOU/HKXmmRUL5JUyLCHSZTDsHiIQQ0faCWsw0sh6 +y61AH60OpnQLOjwASHlI1JsB0S66UUUE+yc7IxNVmP0jsjSdTr7X3kSO3azO68Xae4F zoie41Wo0zz1MxV4znNtDmIllw1riBkV8JZAUjKHCB28PfudQidqCY9EuSbB4LD6p9sg wPXSIrQ9FBv+nLE+0pn5sqcQDNl6Fqzp/q3zuTPwHeAMZlTXM9X/p9VxLE/6qa1ILf3m xGEw== X-Gm-Message-State: AOAM532xpB8RlAp4XRrCeO7pFtfpjWDVsrF7QJNT0cESW8aln+rj5UTV JCA4LAyPlKZsUuhoZc77RAI= X-Google-Smtp-Source: ABdhPJwaB+c1mORjF8jaO+c/+QMJ0GE5nK3K8F4mfLhSS6Mvk1IPL6raXjJal+9PnCv8TJGdi0CJSA== X-Received: by 2002:a05:6402:1c10:: with SMTP id ck16mr60633676edb.72.1594385106109; Fri, 10 Jul 2020 05:45:06 -0700 (PDT) Received: from pi3 ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id d12sm4379131edx.80.2020.07.10.05.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 05:45:05 -0700 (PDT) Date: Fri, 10 Jul 2020 14:45:03 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Message-ID: <20200710124503.GB22897@pi3> References: <20200708153420.29484-1-lukasz.luba@arm.com> <20200708153420.29484-2-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_084512_344784_DD7C2DD4 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, s.nawrocki@samsung.com, linux-pm@vger.kernel.org, k.konieczny@samsung.com, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, willy.mh.wolff.ml@gmail.com, myungjoo.ham@samsung.com, chanwoo@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 09:34:45AM +0100, Lukasz Luba wrote: > Hi Chanwoo, > > On 7/9/20 5:08 AM, Chanwoo Choi wrote: > > Hi Lukasz, > > > > On 7/9/20 12:34 AM, Lukasz Luba wrote: > > > In order to react faster and make better decisions under some workloads, > > > benchmarking the memory subsystem behavior, adjust the polling interval > > > and upthreshold value used by the simple_ondemand governor. > > > > > > Reported-by: Willy Wolff > > > Signed-off-by: Lukasz Luba > > > --- > > > drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > > > index 93e9c2429c0d..e03ee35f0ab5 100644 > > > --- a/drivers/memory/samsung/exynos5422-dmc.c > > > +++ b/drivers/memory/samsung/exynos5422-dmc.c > > > @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev) > > > * Setup default thresholds for the devfreq governor. > > > * The values are chosen based on experiments. > > > */ > > > - dmc->gov_data.upthreshold = 30; > > > + dmc->gov_data.upthreshold = 10; > > > dmc->gov_data.downdifferential = 5; > > > - exynos5_dmc_df_profile.polling_ms = 500; > > > + exynos5_dmc_df_profile.polling_ms = 100; > > > } > > > > > > > Reviewed-by: Chanwoo Choi > > > > Thank you for the review. Do you think this patch could go through > your tree together with your patches? > > I don't know Krzysztof's opinion about the patch 2/2, but > I would expect, assuming the patch itself is correct, he would > like to take it into his next/dt branch. In the cover letter you mentioned that this is a follow up for the Chanwoo's patchset. But are these patches really depending on it? Can they be picked up independently? The DTS patch must go through arm soc, so I will take it. If it really depends on driver changes, then it has to wait for next release. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel