From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D513AC433E6 for ; Fri, 10 Jul 2020 13:09:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3B2C2077D for ; Fri, 10 Jul 2020 13:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="owk4NRw9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3B2C2077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wSSVXv0a+dLHRjsozoU/XjBLZQyyHHTyzS1hkglOTV0=; b=owk4NRw9D76+n4WLi3ldL4DHe o7LZkwimYRsskC2f3NwupQxzmH7uJR46FtwF6rqD2HypaQuBvixelx01FEc5Abcrgsob6WaX8gZpe /DA1GkU/Tdsgr4+delbpQcCALihIwe//ULUJCv3A4eQRT0IBfmw0vANHG8tNvatM2MHyjE4ukgQRO bR8q2ZndJgqcEz9LcLv8quYmPZWkDTespHnY5EDimKnquI8jTmU2aE97s/M/5D/HxhQ0iOWYGWjXp g60mRVKaqL7GLAhR1GRrLjArbPXXnMaLgU96vhCFq0p04kGFT5VGCnp4CLKx8Wlp8MqZbJqh7dsc6 Tp5PFvZEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtskp-00018c-D5; Fri, 10 Jul 2020 13:07:51 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtskW-0000zt-EM for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 13:07:34 +0000 Received: by mail-ed1-f67.google.com with SMTP id d18so4609594edv.6 for ; Fri, 10 Jul 2020 06:07:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IhjbyydRkafatOFYJUQWB8jqmQKoDEwVSOznMMqxhFo=; b=EeegNkhW7xyXcrfco6xQ++dCf718FtGXM47wDZ0VpNKrKhxDfjus6taCPD56t88QqV qfbDz4QKRlN0WjHpFdJ3bDAy3RG1Q7vAEWbcYcNCMGIrpTMjA+itQrWN5P/OOpzuPUXc eWNh1EOGTg6Beih2BQgpzMksZ9Jfepb46RZ/NpIUEiPJlnCrYzCfhJMqJbefNo3rm12U qsZNofjd/E9mJj1+936J1Lw51gzH966nbBsTr0zBxcAaNL1HzEiZ8HdsPIiZ8jK0e39U YrRUIQswYjMERxt59Eu99gQPZLen76RDcjbKcD2Nd15UnOB7TLkxXOmiboAF1LdEGWl5 c6Eg== X-Gm-Message-State: AOAM5300nOcE9+tOT6El59gwcP5a7T1K80yHLA4Ce6PZSR+446tQdu4C h84eoSbERyARnbXA3rdFHk0Yu+G+ X-Google-Smtp-Source: ABdhPJy7GvB0YGcvjriG0PCDBYS91figVPtXSFiWz8TRbw35P+rdTnGn8EDvM7zDY0obC6Fi35h29w== X-Received: by 2002:aa7:da8d:: with SMTP id q13mr73846957eds.339.1594386450284; Fri, 10 Jul 2020 06:07:30 -0700 (PDT) Received: from pi3 ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id lj18sm3602276ejb.43.2020.07.10.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 06:07:29 -0700 (PDT) Date: Fri, 10 Jul 2020 15:07:27 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Message-ID: <20200710130727.GA22991@pi3> References: <20200708153420.29484-1-lukasz.luba@arm.com> <20200708153420.29484-2-lukasz.luba@arm.com> <20200710124503.GB22897@pi3> <0bfb4332-9a2e-9ff9-1a86-d9875a8f34bb@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0bfb4332-9a2e-9ff9-1a86-d9875a8f34bb@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_090732_556693_84135153 X-CRM114-Status: GOOD ( 29.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, s.nawrocki@samsung.com, linux-pm@vger.kernel.org, k.konieczny@samsung.com, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, willy.mh.wolff.ml@gmail.com, myungjoo.ham@samsung.com, chanwoo@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 01:56:33PM +0100, Lukasz Luba wrote: > > > On 7/10/20 1:45 PM, Krzysztof Kozlowski wrote: > > On Fri, Jul 10, 2020 at 09:34:45AM +0100, Lukasz Luba wrote: > > > Hi Chanwoo, > > > > > > On 7/9/20 5:08 AM, Chanwoo Choi wrote: > > > > Hi Lukasz, > > > > > > > > On 7/9/20 12:34 AM, Lukasz Luba wrote: > > > > > In order to react faster and make better decisions under some workloads, > > > > > benchmarking the memory subsystem behavior, adjust the polling interval > > > > > and upthreshold value used by the simple_ondemand governor. > > > > > > > > > > Reported-by: Willy Wolff > > > > > Signed-off-by: Lukasz Luba > > > > > --- > > > > > drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > > > > > index 93e9c2429c0d..e03ee35f0ab5 100644 > > > > > --- a/drivers/memory/samsung/exynos5422-dmc.c > > > > > +++ b/drivers/memory/samsung/exynos5422-dmc.c > > > > > @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev) > > > > > * Setup default thresholds for the devfreq governor. > > > > > * The values are chosen based on experiments. > > > > > */ > > > > > - dmc->gov_data.upthreshold = 30; > > > > > + dmc->gov_data.upthreshold = 10; > > > > > dmc->gov_data.downdifferential = 5; > > > > > - exynos5_dmc_df_profile.polling_ms = 500; > > > > > + exynos5_dmc_df_profile.polling_ms = 100; > > > > > } > > > > > > > > > > > > > Reviewed-by: Chanwoo Choi > > > > > > > > > > Thank you for the review. Do you think this patch could go through > > > your tree together with your patches? > > > > > > I don't know Krzysztof's opinion about the patch 2/2, but > > > I would expect, assuming the patch itself is correct, he would > > > like to take it into his next/dt branch. > > > > In the cover letter you mentioned that this is a follow up for the > > Chanwoo's patchset. But are these patches really depending on it? Can > > they be picked up independently? > > > They are not heavily dependent on Chanwoo's patches. > Yes, they can be picked up independently. > I just wanted to mention that the patch 1/2 was produced on the > code base which had already applied Chanwoo's patch for DMC. > If you like to take both 1/2 and 2/2 into your tree, it's good. Then let me take them. If there is more development ongoing, it would create unnecessary merges between trees. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel