From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA02C433DF for ; Fri, 10 Jul 2020 13:39:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39B8A20578 for ; Fri, 10 Jul 2020 13:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LnfpzXQg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iTjMYTTY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39B8A20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YIOYc8fphM5t7ey4VgyKiQPq/XBZV2GFkMAuZj6A7PQ=; b=LnfpzXQgCPGT1uSqg1PbUC6P6 KMYsZF9T+fcjWDjEPT8ublgtyFLTASKsAtDu3HdqDX9fvsQUwuMSYVmQlPuVJIMb5aGEjmyOxrsqv IsMiFmNo2pom8fcNpB1zOVIN7Z4Dxt8Fjunv1A80Pc27+Kd9rIm4EQr3eIUjmXlByiN4Ag5yZs4n3 sP8kuSueXu7Rk2zVo4MFtyF3oDXo7QFhqAobfWk8EMAU8vF63Py7dO7cTrxwhbd6nzPTvRVm5nICA n+8a96enU+XKtTr/qCUit4BTa6HCH4ctpvXXYiztnhEx+RrkBDEqhR3965k1ItRm8/at98j0rUzl9 QIoVtlESQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttEL-0007g6-91; Fri, 10 Jul 2020 13:38:21 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttEH-0007eq-Cr for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 13:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594388296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fs+hXal+E9h+xSmSn1WDSBw3YxCqs2UgsXPkscEMfts=; b=iTjMYTTYdSgq7qqassriqelPO6fQ8zpxvbx171J88m7hc1nUONbn0HyAr0mpoFniEidApZ gv8henWLCBv19qQmvPddqoQS1r9sVbCsju/ALImpxfX0SeRruEiN/NS2GgFKMeJtrnwg1G YBtfqn9kkGPVXHzyij83wAQa8Lz8/mU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-i73u9pw3PQ6KRcJSC0gsrg-1; Fri, 10 Jul 2020 09:38:15 -0400 X-MC-Unique: i73u9pw3PQ6KRcJSC0gsrg-1 Received: by mail-qt1-f198.google.com with SMTP id e4so4123878qtd.13 for ; Fri, 10 Jul 2020 06:38:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fs+hXal+E9h+xSmSn1WDSBw3YxCqs2UgsXPkscEMfts=; b=YhETcwg4j19k/KFJi9xcPrlwfLKXEKW+beYSU+OoJH2KOPK2IH+bAj/HEL82PUiCjf rXzXbSC62KPvb65aCVa9qsWvtfOV95G5c1VDNkeQ3fVpzhPaPizbAciezuMoR8LPo5ZY 96Z6TE68j0J0af1HlMW6I5J/jqr8PT9ucq2jRdyPcHeYq44cbRPO1krPsE4I4KaRLIuG ZaJVBwW8kvVyGOejWoJNwwXhwzoTj5t0J8SaMuL+N9z95aOaWHEo+6acTnI/pEn1mbbd ssfUMn/aJAJLyE9aX7dINPX77P7oGvsFZCHAYAl5Ce0fHqG9kgGQFGyslSlywBoejD04 lnvQ== X-Gm-Message-State: AOAM530e5pjVolRMliNmLmmhy4t/uYoQWxJM3qucUSksh/9RU5gcrKsr fkUrIq7g86NzmZezgVWRNtSGlWii+B80Q7J8W2SdlY5cFUN6vcI1RYxUMCeCgPdD28Kk0ACHnoQ MtVlyLZaWoNBvpKPqbC78PhyFxDOIbxATz+I= X-Received: by 2002:a05:6214:13c6:: with SMTP id cg6mr68870821qvb.160.1594388294094; Fri, 10 Jul 2020 06:38:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx94pAjTCneB10Vm7hL/5f34lU0p1/JC54i6Ailssrju73hfAlT7p+WskPvc1OHKAsqE2lwYw== X-Received: by 2002:a05:6214:13c6:: with SMTP id cg6mr68870802qvb.160.1594388293870; Fri, 10 Jul 2020 06:38:13 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c8:6f::1f4f]) by smtp.gmail.com with ESMTPSA id h197sm7530332qke.51.2020.07.10.06.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 06:38:13 -0700 (PDT) Date: Fri, 10 Jul 2020 09:38:11 -0400 From: Peter Xu To: Mark Brown , Andrew Morton Subject: Re: Build failure in -next with get_user_pages_remote() API change Message-ID: <20200710133811.GM199122@xz-x1> References: <20200710113201.GC5653@sirena.org.uk> <20200710122457.GK199122@xz-x1> MIME-Version: 1.0 In-Reply-To: <20200710122457.GK199122@xz-x1> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_093817_500226_26AA62DC X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Hubbard , Steven Price , linux-next@vger.kernel.org, Catalin Marinas , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 08:24:57AM -0400, Peter Xu wrote: > On Fri, Jul 10, 2020 at 12:32:01PM +0100, Mark Brown wrote: > > Today's -next fails to build in various arm64 configs with: > > > > arch/arm64/kernel/mte.c:225:23: error: too many arguments to function call, expected 7, have 8 > > &page, &vma, NULL); > > ^~~~ > > ./include/linux/stddef.h:8:14: note: expanded from macro 'NULL' > > #define NULL ((void *)0) > > ^~~~~~~~~~~ > > ./include/linux/mm.h:1705:6: note: 'get_user_pages_remote' declared here > > long get_user_pages_remote(struct mm_struct *mm, > > ^ > > 1 error generated. > > > > caused by b7363b0ab88d66d3c (mm/gup: remove task_struct pointer for all > > gup code) which updated the signature of get_user_pages_remote() without > > updating the caller in mte.c. > > We should need to squash into "mm/gup: remove task_struct pointer for all gup > code" with: > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 934639ab225d..11e558b02a05 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -221,7 +221,7 @@ static int __access_remote_tags(struct task_struct *tsk, struct mm_struct *mm, > void *maddr; > struct page *page = NULL; > > - ret = get_user_pages_remote(tsk, mm, addr, 1, gup_flags, > + ret = get_user_pages_remote(mm, addr, 1, gup_flags, > &page, &vma, NULL); > if (ret <= 0) > break; > > Seems to be a new caller merged recently, so it got left behind during the > rebases... Sorry for not noticing that. Andrew, IIUC this can still have its chance to be squashed into existing commit, or please let me know if there's anything I can do (resend the affected last patch, or send a fixup patch, ...). Thanks! -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel