From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CDAC433E1 for ; Fri, 10 Jul 2020 16:31:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 710F720657 for ; Fri, 10 Jul 2020 16:31:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gHxrXX2r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 710F720657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ndwW4BCyCRRc7h2ka9nlDFveamUyVxsfYznHcGUjfw=; b=gHxrXX2rgF6RAP4BwfKMEfIab hxYVsON1eQJLb8apOfM3mvslwIhkEfoC2pIpl2x3QjpT64IZVtedNtgx+PZLskDudOf0mG6l9oHAE o4IeLugsCcRMthngPNPeJ0jOi1Vo2S81qkiY17Q2nTQr1pl6G/HZOC2ETQSbHII0QXZEGvXcOqGuV VsWMIfNs1A6tP7Qu2taMjMVLY9L+zSsw5Yu/BpJb1lo+KZ0YlmvQQYXVUZV9T5DU45f28eebFDpX2 En9ZjAT6TLsv8NTmwlE7NKEHNhwNTxGBbqejoOsHX2H6Y5WlMzZKqlSiRbkDMnx+i/dQUxhMdmmBI Dm7KPyQiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtvuw-0002wZ-Ap; Fri, 10 Jul 2020 16:30:30 +0000 Received: from mga06.intel.com ([134.134.136.31]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtvus-0002va-U7; Fri, 10 Jul 2020 16:30:28 +0000 IronPort-SDR: QJDbRMI9kHVQo6eoJjr1rydgFpFak11GR48ODqeLYw8RYvj8klyvNgfFESZ7alcUwCiu3P7FVf 71ioiPkN33xA== X-IronPort-AV: E=McAfee;i="6000,8403,9678"; a="209766042" X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="209766042" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 09:30:24 -0700 IronPort-SDR: Bu+5xxTAogr6Qt9XOPyehtNn9fg/iuQTF9n2tDXiNLJVDnikQ3AGeb47w6O4F+a0qG9QJneOBO DD3RAqgq/ppA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="316651372" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 10 Jul 2020 09:30:22 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jtvuo-0015OA-Qu; Fri, 10 Jul 2020 19:30:22 +0300 Date: Fri, 10 Jul 2020 19:30:22 +0300 From: Andy Shevchenko To: Cristian Ciocaltea Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port Message-ID: <20200710163022.GT3703480@smile.fi.intel.com> References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <20200710120549.GA11293@BV030612LT> <20200710133542.GA2172832@kroah.com> <20200710155806.GA10457@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710155806.GA10457@BV030612LT> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_123027_403446_3DCC71F4 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 06:58:06PM +0300, Cristian Ciocaltea wrote: > On Fri, Jul 10, 2020 at 03:35:42PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 10, 2020 at 03:05:49PM +0300, Cristian Ciocaltea wrote: ... > > But I think we now have a core fix for this, no need to do this in any > > individual driver, right? Can you test my tty-linus branch to see if > > your change is still needed or not? > > I was not aware of the alternative approach, at that time Andy > confirmed the expected behaviour is to have a proper initialization > of the spinlock in the driver: > https://lore.kernel.org/lkml/CAHp75Vcz0a87LSnb6Ubt5_bSF3wUcs21GbP119trXER5KBDxbQ@mail.gmail.com/ > https://lore.kernel.org/lkml/CAHp75Vf8xJ2yX-11JsTDnRvZQOK+16aePcB1AUzq=5oO-mFCGQ@mail.gmail.com/ > > I have just checked the tty-linus tree and the only related change > seems to be f743061a85f5 > ("serial: core: Initialise spin lock before use in uart_configure_port()") > > I tested it on top of 5.8.0-rc4 and I confirm it fixes the splat, Thank you for the testing! > however I'm a bit confused now regarding the recommended approach since > there is at least one more commit in the tty-linux tree that still > handles a similar issue in the driver specific code: > f38278e9b810 ("serial: sh-sci: Initialize spinlock for uart console") They now should be reverted. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel