From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16320C433DF for ; Fri, 10 Jul 2020 17:16:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7DF020674 for ; Fri, 10 Jul 2020 17:16:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vr1WUoRD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ODn+wBX8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7DF020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9WTETmHKbdvaGyNViRgY2bRxwFGShUN2vaL9zBEZfKg=; b=vr1WUoRDvJtGbe+bkAjm5xZDP lCbVdlAUw8hYNkpLMRdJzO+S+46BjqE6YSGsZDVS+JLBQfLnrr2wQIgo8LcHGcDJTJBAGM+IoHh2X S43dHmqJV/pQssm0OOykOgkyKQtKqWtR9wiNXy6sPAA9zuB6csZIpZJtkHp6Ax/kaJSSMlrp3mh+7 W99/Lblnha+5pRMhVxsWsgpkhun79HqJHNaVpoVdv9YXE2TrxLW/I86lUTiUyI8IilMP5JekBDtZ4 mvJ/QAvA0dRXtJB3jtIyqBqyk0aCFESqPrvT3s1doC11vhgN6GgNse291YovP8Jnp0hPkDA4N35iv jWSBrjT2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtwcK-0003UD-6z; Fri, 10 Jul 2020 17:15:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtwcG-0003TW-W8 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 17:15:18 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D19C020674; Fri, 10 Jul 2020 17:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594401316; bh=L7/tSb+Pse5aLWVxH/CLIrVK11DXAitXfSjGWiPzMUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODn+wBX8HVqj1KZ2HGIGv/MORKu3ZZn1aHWKKfff8Ba+oqIUoNxRgomJHmFYKPNHS P1MuJ6OVVATCam7HY3GwWvnyCmD9TLL59R8ZtNw8xhnMxMpwg3QAynx9yvsiNN5Ud7 r7lMVIb3kVpC3xRWR0p0fhp6Z1rXKg0F4ZE4sIz8= Date: Fri, 10 Jul 2020 18:15:09 +0100 From: Will Deacon To: Nick Desaulniers Subject: Re: [PATCH v3 06/19] asm/rwonce: Don't pull into 'asm-generic/rwonce.h' Message-ID: <20200710171508.GA31366@willie-the-truck> References: <20200710165203.31284-1-will@kernel.org> <20200710165203.31284-7-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_131517_189697_5EB73A05 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joel Fernandes , Mark Rutland , Marco Elver , Kees Cook , "Paul E. McKenney" , "Michael S. Tsirkin" , Peter Zijlstra , Catalin Marinas , Jason Wang , LKML , virtualization@lists.linux-foundation.org, Ivan Kokshaysky , Linux ARM , Sami Tolvanen , linux-alpha@vger.kernel.org, Alan Stern , Matt Turner , kernel-team , Boqun Feng , Arnd Bergmann , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 10:06:12AM -0700, Nick Desaulniers wrote: > On Fri, Jul 10, 2020 at 9:52 AM Will Deacon wrote: > > diff --git a/include/linux/nospec.h b/include/linux/nospec.h > > index 0c5ef54fd416..c1e79f72cd89 100644 > > --- a/include/linux/nospec.h > > +++ b/include/linux/nospec.h > > @@ -5,6 +5,8 @@ > > > > #ifndef _LINUX_NOSPEC_H > > #define _LINUX_NOSPEC_H > > + > > +#include > > The other hunks LGTM, but this one is a little more curious to me. Can > you walk me through this addition? Sure. Without it, the build breaks on riscv because it includes this header without first including , and this header relies on OPTIMIZER_HIDE_VAR() being to defined as it is used in static inline functions. Perhaps I should squash this hunk into "compiler.h: Split {READ,WRITE}_ONCE definitions out into rwonce.h" instead, as that is where I remove the include of from 'asm-generic/barrier.h'. I'll check the bisection on riscv... Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel