From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A775C433DF for ; Sat, 11 Jul 2020 18:46:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 598C520720 for ; Sat, 11 Jul 2020 18:46:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2x2Z650t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LUUoqlHW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 598C520720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gpyicJ35Wj0aXdJov7JPffRa+Kzx91vKkqcEQz7eQLA=; b=2x2Z650twj+N7Q0eQqvGJUnFq 2kYFnya8hleKeJdWwQlkq0vCxbHI971Ck47jiG0c5T3Ab80oOy240diQB7ZgL62FgoUXhvN1Lut0s 921T5Z8kocq5KcBUOlssaqdzFrDjrthtzHJWhOY0LnQLoj6PdaE3UX5c3YJWhNpfboiKXHXPjlF4e 5jYltKRIXmd3pgzZ/BTvl4AbhxOFJWmre4Fb+6m2x+R7fssJdhknCRR6YQux/e5h+QFqVMRWhlglb 0pCYGl2lTTSy356en1RIharelN6ncjuQSLH0CXrNGv4mkrEYj5gPjhIUfbyglpgje4r8gH6I3x2Bb ANGLwCwmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juKUQ-00036t-TK; Sat, 11 Jul 2020 18:44:46 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juKUO-00035r-Tl for linux-arm-kernel@lists.infradead.org; Sat, 11 Jul 2020 18:44:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594493083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bS19/wWScaoigC28WtauFL/l6Ha+uxblMLUn/Mypy1E=; b=LUUoqlHWdEdqWIFPbe6aezWDRE8tg56W/l3P9CiayVL6L0HJxUcKQ12Er481lgZaYNu03s BJYOew+hMi9QTit/vP/isJfKujfRCGsCKanRYN3R9tOnd0fscWWT+f0oBl6oekpBOsBOhG Th7HJp5SLN2N2rhIXtbTzInotMXTvFk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-Rp0As29vOrOPwsSshaM_Iw-1; Sat, 11 Jul 2020 14:44:40 -0400 X-MC-Unique: Rp0As29vOrOPwsSshaM_Iw-1 Received: by mail-wr1-f71.google.com with SMTP id i12so10771230wrx.11 for ; Sat, 11 Jul 2020 11:44:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bS19/wWScaoigC28WtauFL/l6Ha+uxblMLUn/Mypy1E=; b=FAcaeAErm+QlTuXD5SZQT2HVyVjG9Ul8qghXrnjDxBE4Y2uXDNF9nqhsH0tflamM2m AxQeOAr0ED81PoDYjM5QjOAeQD1wBSB3XtVF6Tvfe994onQvOpHu/l/KASS4HtU/3wQT EUypiVXezE2PmQoT8YhWAMqwvzQtHXxAM6xKD4y9wk99hgaHYvU+JXCgU8Xtcw25DXB9 VFiGVH2eT4D+LDEKSFxclXD6ZaBNUT+IQsb6uDvvbJxvMxr3yeGfW2wT6summu7FpKOs bGzkjebxHfLf12/ZF2drtDuEU2lWCN/5TffXJFEj01ij/MMMJoDQ5X7vFIFu0gOm1JbM 3+mQ== X-Gm-Message-State: AOAM5311Mjr15LXambAJw8uHj2HmVKxodG3wfs3CeS3CDnw3vaTJeHM7 FUpfMVv5nRaAN0flDM9I+dgjL0/uKc4eP+RhvgqENJaNUpbvfUhcJxwubFP0ETC44Y5OF2mRRY5 GR5uoQrtc734ssZMV3AySmSnSmy+KnRo8Zbc= X-Received: by 2002:a1c:4d11:: with SMTP id o17mr10838352wmh.134.1594493079781; Sat, 11 Jul 2020 11:44:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygwQmxPTGDCpKObOVAAUSmALBrwy00qKV5C2K74YeE+tRXIP/JRrrSaIMIkdPE6mekfNCtDg== X-Received: by 2002:a1c:4d11:: with SMTP id o17mr10838336wmh.134.1594493079525; Sat, 11 Jul 2020 11:44:39 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id a84sm4541096wmh.47.2020.07.11.11.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 11:44:38 -0700 (PDT) Date: Sat, 11 Jul 2020 14:44:34 -0400 From: "Michael S. Tsirkin" To: Stefano Stabellini Subject: Re: [PATCH] xen: introduce xen_vring_use_dma Message-ID: <20200711144334-mutt-send-email-mst@kernel.org> References: <20200624163940-mutt-send-email-mst@kernel.org> <20200624181026-mutt-send-email-mst@kernel.org> <20200626110629-mutt-send-email-mst@kernel.org> <20200701133456.GA23888@infradead.org> <20200701172219-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200711_144444_993554_CA38C04B X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, Peng Fan , konrad.wilk@oracle.com, jasowang@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Christoph Hellwig , iommu@lists.linux-foundation.org, linux-imx@nxp.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 10:23:22AM -0700, Stefano Stabellini wrote: > Sorry for the late reply -- a couple of conferences kept me busy. > > > On Wed, 1 Jul 2020, Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 10:34:53AM -0700, Stefano Stabellini wrote: > > > Would you be in favor of a more flexible check along the lines of the > > > one proposed in the patch that started this thread: > > > > > > if (xen_vring_use_dma()) > > > return true; > > > > > > > > > xen_vring_use_dma would be implemented so that it returns true when > > > xen_swiotlb is required and false otherwise. > > > > Just to stress - with a patch like this virtio can *still* use DMA API > > if PLATFORM_ACCESS is set. So if DMA API is broken on some platforms > > as you seem to be saying, you guys should fix it before doing something > > like this.. > > Yes, DMA API is broken with some interfaces (specifically: rpmesg and > trusty), but for them PLATFORM_ACCESS is never set. That is why the > errors weren't reported before. Xen special case aside, there is no > problem under normal circumstances. So why not fix DMA API? Then this patch is not needed. > > If you are OK with this patch (after a little bit of clean-up), Peng, > are you OK with sending an update or do you want me to? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel