Re: [PATCH v29 13/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function

Jacek Anaszewski
2020-07-12T15:33:40Z

On 7/11/20 10:24 PM, Pavel Machek wrote:
> On Sat 2020-07-11 19:19:22, Jacek Anaszewski wrote:
>> On 7/11/20 5:57 PM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> Add the multicolor brightness call back to support the multicolor
>>>> framework. This call back allows setting brightness on grouped channels
>>>
>>> Extra space before "brightness".
>>
>> And before "This".
>
> That one is intentional, I believe.
>
> https://www.independent.co.uk/life-style/gadgets-and-tech/news/one-space-or-two-spaces-after-a-full-stop-scientists-have-finally-found-the-answer-a8337646.html
>
> We are using fixed width fonts, so typewriter rules still apply here.

But see the article [0].
Also, in [1], in the section "Computer era" you can find opposite
examples in the modern systems.

And grep returns following numbers for kernel Documentation folder:

$ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l
18449
$ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l
63067

I prefer single space but will not fight for that too hard.
Nonetheless, it would be good to use one style consistently,
since most files I've looked at had problem with that.

Both DT and LED documentation in this set is not consistent
in this regard as well.

[0]
https://www.instructionalsolutions.com/blog/one-space-vs-two-after-period
[1] https://en.wikipedia.org/wiki/Sentence_spacing

--
Best regards,
Jacek Anaszewski