From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C9CC433DF for ; Sun, 12 Jul 2020 13:37:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA0D8206B6 for ; Sun, 12 Jul 2020 13:37:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cifBPdpk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G6zXdmu7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA0D8206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UFMxYn0vxN73FwYiDVUbjrH7aEkPfOCTioPeJG0uDR8=; b=cifBPdpkW5elTsYOSwBf1ErwY Do0d4nj4YRxaQvGS0ZqmI9HKujK6klEB6WXnXQwoAyGgtc+y5xznBTmy/I+svYIWWhP6nCO38TEy8 qXfxqK8rRm/Cb4T+0MJhD9dnuYL3Bm3E1lJ/PDKNQvG69rpMEtfBLYQmk0IXd+KQHbgtCTMkpnWsG LKrGQC+x9hUSjNqChdidXe7bqK0engwGx/h8jnpgBcdsBYyXaZvKd5L0EZTa7ETMrYV0odCrEQBP0 Ij2oIBPCK1Qsh7DjapcMT3wBsj78UI/XFRlWloZMKFRqqTFZeWw/H3IKJQyudj8aoKwjbEtDSbsKj lhufXWLcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juc8s-0003dT-9p; Sun, 12 Jul 2020 13:35:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juc8q-0003cy-2q for linux-arm-kernel@lists.infradead.org; Sun, 12 Jul 2020 13:35:41 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C37D206B6; Sun, 12 Jul 2020 13:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594560939; bh=tA6inrUVMBbNMdDUv0sGKtGU7BZNsriyMOePDmhGwc8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G6zXdmu7qxU3Vgk93hqW3Jio/U+fyHYjuZ6eECAXysS9JNbx54qgm+1xOPFkY3CvE sAO9eEiWzoS7n0Z/bM2n5DGcqGeaYpYoG/b6YMyWqDk/d0GCdKy7MdMNkM6IOnVlvN 1SxelAHXAGoVB/7aFwu7rmzvQfBKPvaWeBQBt72Y= Date: Sun, 12 Jul 2020 14:35:34 +0100 From: Jonathan Cameron To: Kamel Bouhara Subject: Re: [PATCH v6 0/5] Microchip TCB Capture driver Message-ID: <20200712143534.278ea3c7@archlinux> In-Reply-To: <20200706114347.174452-1-kamel.bouhara@bootlin.com> References: <20200706114347.174452-1-kamel.bouhara@bootlin.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_093540_271039_2302F6F9 X-CRM114-Status: GOOD ( 27.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Alexandre Belloni , linux-iio@vger.kernel.org, William Breathitt Gray , Ludovic Desroches , Rob Herring , Thomas Petazzoni , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 6 Jul 2020 13:43:42 +0200 Kamel Bouhara wrote: > Hello, > > Here is a new counter driver to support Microchip TCB capture devices. > > Each SoC has two TCB blocks, each one including three independent > channels.The following series adds support for two counter modes: > increase and quadrature decoder. > > As for the atmel clocksource and pwm, the counter driver needs to fill > some tcb capabilities in order to operate with the right configuration. > This is achieved in first patch of this series. > > Please feel free to comment. As far as I can see we have all the necessary acks etc and it looks good to me as well. Shall I do an immutable branch with the whole lot or should we split it up? Patches 1 and 5 need to go through the same tree, but bindings could go via another route. I'm also fine if the whole lot goes via the appropriate soc tree if that is easier. Jonathan > > Cheers, > > Changes in v6: > - Rebased on top of v5.8-rc3 > - Added Alexandre's ack > - Added Rob's ack > > Changes in v5: > - Fix duplicate keys errors in yaml dt-schema > > Changes in v4: > - Use existing binding to document capture mode of the Microchip TCBs. > > Changes in v3: > - Updated the brand name: s/atmel/microchip/. > - Added missing kernel doc for new elements introduced in structure > atmel_tcb_config. > - Removed useless blank line > - Added an explicit clock removing path using devm_add_action_or_reset > > Changes in v2: > - Fixed first patch not applying on mainline > - Updated return code to -EINVAL when user is requesting qdec mode on > a counter device not supporting it. > - Added an error case returning -EINVAL when action edge is performed > in > qdec mode. > - Removed no need to explicity setting ops to NULL from static struct > as > it is the default value. > - Changed confusing code by using snprintf for the sake of clarity. > - Changed code to use ARRAY_SIZE so that future reviewers will know > that num_counts matches what's in the atmel_tc_count array without > having to check so themselves. > - Fixed errors reported by dt_binding_check > > Alexandre Belloni (2): > dt-bindings: atmel-tcb: convert bindings to json-schema > dt-bindings: microchip: atmel,at91rm9200-tcb: add sama5d2 compatible > > Kamel Bouhara (3): > ARM: at91: add atmel tcb capabilities > dt-bindings: counter: microchip-tcb-capture counter > counter: Add microchip TCB capture counter > > .../devicetree/bindings/mfd/atmel-tcb.txt | 56 --- > .../soc/microchip/atmel,at91rm9200-tcb.yaml | 181 ++++++++ > drivers/counter/Kconfig | 11 + > drivers/counter/Makefile | 1 + > drivers/counter/microchip-tcb-capture.c | 397 ++++++++++++++++++ > include/soc/at91/atmel_tcb.h | 5 + > 6 files changed, 595 insertions(+), 56 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-tcb.txt > create mode 100644 Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml > create mode 100644 drivers/counter/microchip-tcb-capture.c > > -- > 2.26.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel