Re: [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions,s700-mmc

Manivannan Sadhasivam
2020-07-12T17:27:57Z

On Thu, Jul 02, 2020 at 08:22:54PM +0530, Amit Singh Tomar wrote:
> The commit adds a new SoC specific compatible string "actions,s700-mmc"
> in combination with more generic string "actions,owl-mmc".
>
> Placement order of these strings should abide by the principle of
> "from most specific to most general".
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
> Changes since v4:
> * No change.
> Changes since v3:
> * No change.
> Changes since v2:
> * Added Rob's Reviewed-by tag
> ---
> Documentation/devicetree/bindings/mmc/owl-mmc.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/owl-mmc.yaml b/Documentation/devicetree/bindings/mmc/owl-mmc.yaml
> index 1380501fb8f0..5eab25ccf7ae 100644
> --- a/Documentation/devicetree/bindings/mmc/owl-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/owl-mmc.yaml
> @@ -14,7 +14,11 @@ maintainers:
>
> properties:
> compatible:
> - const: actions,owl-mmc
> + oneOf:
> + - const: actions,owl-mmc
> + - items:
> + - const: actions,s700-mmc
> + - const: actions,owl-mmc
>
> reg:
> maxItems: 1
> --
> 2.7.4