From: Pavel Machek <pavel@ucw.cz>
To: Marek Behun <marek.behun@nic.cz>
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com
Subject: Re: [PATCH v29 00/16] Multicolor Framework v29
Date: Sun, 12 Jul 2020 21:55:44 +0200 [thread overview]
Message-ID: <20200712195544.GC20592@amd> (raw)
In-Reply-To: <20200712191315.5dab10a6@nic.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1532 bytes --]
Hi!
> > > This is the multi color LED framework. This framework presents clustered
> > > colored LEDs into an array and allows the user space to adjust the brightness
> > > of the cluster using a single file write. The individual colored LEDs
> > > intensities are controlled via a single file that is an array of LEDs
> > >
> > > Change to the LEDs Kconfig to fix dependencies on the LP55XX_COMMON.
> > > Added update to the u8500_defconfig
> >
> > Marek, would you be willing to look over this series?
>
> Overall this series looks good to me. I wanted to apply version 29 of
> the patches, but I didn't receive all patches in v29 (some are
> missing), so I had to search for previous versions of selected patches.
>
> I have seen some typos in documentation, but that can be solved
> afterwards.
>
> One thing I don't like much is that in the sysfs multi_index and
> multi_intensity files there is a trailing space after the last color.
> This is not true for example for the trigger file. It is trivial to fix
> this, so again maybe a will send a follow-up patch after this series is
> accepted.
Yes, I noticed that one, too, and expect it to be fixed before the
merge.
I believe you'll get next version of the patches... If not that one
will likely appear in -next, so will be available using git.
Thank you for the review,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-12 19:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200622185919.2131-1-dmurphy@ti.com>
2020-07-04 12:47 ` [PATCH v29 00/16] Multicolor Framework v29 Pavel Machek
2020-07-06 12:31 ` Dan Murphy
2020-07-07 15:36 ` Dan Murphy
2020-07-11 20:29 ` Pavel Machek
2020-07-12 17:13 ` Marek Behun
2020-07-12 19:55 ` Pavel Machek [this message]
[not found] ` <20200622185919.2131-2-dmurphy@ti.com>
2020-07-04 12:48 ` [PATCH v29 01/16] dt: bindings: Add multicolor class dt bindings documention Pavel Machek
2020-07-09 19:24 ` Rob Herring
2020-07-12 19:52 ` Pavel Machek
[not found] ` <20200622185919.2131-5-dmurphy@ti.com>
2020-07-09 19:25 ` [PATCH v29 04/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Rob Herring
[not found] ` <20200622185919.2131-7-dmurphy@ti.com>
2020-07-09 19:25 ` [PATCH v29 06/16] dt-bindings: leds: Convert leds-lp55xx to yaml Rob Herring
[not found] ` <20200622185919.2131-4-dmurphy@ti.com>
2020-07-11 15:57 ` [PATCH v29 03/16] leds: multicolor: Introduce a multicolor class definition Pavel Machek
2020-07-13 13:34 ` Dan Murphy
[not found] ` <20200622185919.2131-13-dmurphy@ti.com>
2020-07-11 15:57 ` [PATCH v29 12/16] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Pavel Machek
[not found] ` <20200622185919.2131-14-dmurphy@ti.com>
2020-07-11 15:57 ` [PATCH v29 13/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Pavel Machek
2020-07-11 17:19 ` Jacek Anaszewski
2020-07-11 20:24 ` Pavel Machek
2020-07-12 15:31 ` Jacek Anaszewski
[not found] ` <20200622185919.2131-6-dmurphy@ti.com>
2020-07-12 17:21 ` [PATCH v29 05/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Marek Behun
2020-07-13 12:36 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712195544.GC20592@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).