From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D94C433DF for ; Sun, 12 Jul 2020 19:57:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AED662067D for ; Sun, 12 Jul 2020 19:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aMO1w+RJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AED662067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HMXjKtr1Jw6cGIalkg+One4p0ykR+hoYMnOMnBZ0iqg=; b=aMO1w+RJKSVH5eRSZUFr2+8U3 QA0Os93GJ7RyGPdEObAJE7ah6KdUHA7qWfzTgHv6RRTdiSEkOKw/ikNahzQhy8183Owl5rCTGI/fq jVzVklI5L9o5ODyuoD/b+GA4sv4RMXWsTXuf9Ca4kRbFNAQY+sbiSaS3hDHWc01O0PtnC3Jz9vakK NiZOiwgDvd/xhSxCA54hDkLAosC5Jx/tE2P4ZxZEg6rBQC2tf1AlCBOExi/l+hh3k/9aa8qHobJ7C +M5kGE0BhOBLCFrwqVPzLdIZTmbI3664F//L3OxWO95yHXsVMivj1oYPrGy710zMRfJofZK/g89L/ I3Kt6XfMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jui4j-0007OK-FP; Sun, 12 Jul 2020 19:55:49 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jui4g-0007Nr-KL for linux-arm-kernel@lists.infradead.org; Sun, 12 Jul 2020 19:55:47 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 8E9471C0BDD; Sun, 12 Jul 2020 21:55:44 +0200 (CEST) Date: Sun, 12 Jul 2020 21:55:44 +0200 From: Pavel Machek To: Marek Behun Subject: Re: [PATCH v29 00/16] Multicolor Framework v29 Message-ID: <20200712195544.GC20592@amd> References: <20200622185919.2131-1-dmurphy@ti.com> <20200704124729.GA20088@amd> <20200712191315.5dab10a6@nic.cz> MIME-Version: 1.0 In-Reply-To: <20200712191315.5dab10a6@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_155546_791233_0F50F7FD X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com Content-Type: multipart/mixed; boundary="===============0308093657447962592==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0308093657447962592== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f0KYrhQ4vYSV2aJu" Content-Disposition: inline --f0KYrhQ4vYSV2aJu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > This is the multi color LED framework. This framework presents clus= tered > > > colored LEDs into an array and allows the user space to adjust the br= ightness > > > of the cluster using a single file write. The individual colored LEDs > > > intensities are controlled via a single file that is an array of LEDs > > >=20 > > > Change to the LEDs Kconfig to fix dependencies on the LP55XX_COMMON. > > > Added update to the u8500_defconfig =20 > >=20 > > Marek, would you be willing to look over this series? >=20 > Overall this series looks good to me. I wanted to apply version 29 of > the patches, but I didn't receive all patches in v29 (some are > missing), so I had to search for previous versions of selected patches. >=20 > I have seen some typos in documentation, but that can be solved > afterwards. >=20 > One thing I don't like much is that in the sysfs multi_index and > multi_intensity files there is a trailing space after the last color. > This is not true for example for the trigger file. It is trivial to fix > this, so again maybe a will send a follow-up patch after this series is > accepted. Yes, I noticed that one, too, and expect it to be fixed before the merge. I believe you'll get next version of the patches... If not that one will likely appear in -next, so will be available using git. Thank you for the review, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --f0KYrhQ4vYSV2aJu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8LasAACgkQMOfwapXb+vIB3wCgunzoVWqliii9lNc24fOaIt3+ 2PkAn10TYib5AulKavO98SWIeoUXvOtM =LdeN -----END PGP SIGNATURE----- --f0KYrhQ4vYSV2aJu-- --===============0308093657447962592== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0308093657447962592==--