From: Shawn Guo <shawnguo@kernel.org>
To: Soeren Moch <smoch@web.de>
Cc: Fabio Estevam <festevam@gmail.com>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6q-tbs2910: Pass phy-reset-duration
Date: Mon, 13 Jul 2020 09:19:30 +0800 [thread overview]
Message-ID: <20200713011929.GR21277@dragon> (raw)
In-Reply-To: <8a75a153-4337-0890-3828-06ee6f1275a5@web.de>
On Thu, Jun 25, 2020 at 06:29:22PM +0200, Soeren Moch wrote:
> Hi Fabio,
>
> On 25.06.20 13:18, Fabio Estevam wrote:
> > According to the AR8035 datasheet:
> >
> > "When using crystal, the clock is generated internally after power is
> > stable. For a reliable power on reset, suggest to keep asserting the reset
> > low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms
> > requirement is satisfied."
> >
> > Pass the 'phy-reset-duration' property to meet such requirement.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> "phy-reset-duration" is listed as deprecated in
> Documentation/devicetree/bindings/net/fsl-fec.txt .
Good point. There must be some new way we should do this properly.
Shawn
> So maybe it is not the best option, but it should work.
>
> Reviewed-by: Soeren Moch <smoch@web.de>
>
> Thanks,
> Soeren
> > ---
> > Changes since v1:
> > - None.
> >
> > arch/arm/boot/dts/imx6q-tbs2910.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts
> > index bfff87ce2e1f..7b03b2787430 100644
> > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts
> > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts
> > @@ -100,6 +100,7 @@
> > pinctrl-0 = <&pinctrl_enet>;
> > phy-mode = "rgmii-id";
> > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> > + phy-reset-duration = <10>;
> > status = "okay";
> > };
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 11:18 [PATCH v2 1/2] ARM: dts: imx6q-tbs2910: Pass phy-reset-duration Fabio Estevam
2020-06-25 11:18 ` [PATCH v2 2/2] ARM: dts: imx6q-tbs2910: Add an mdio node Fabio Estevam
2020-06-25 16:29 ` Soeren Moch
2020-07-13 1:18 ` Shawn Guo
2020-06-25 16:29 ` [PATCH v2 1/2] ARM: dts: imx6q-tbs2910: Pass phy-reset-duration Soeren Moch
2020-07-13 1:19 ` Shawn Guo [this message]
2020-07-13 13:10 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713011929.GR21277@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=smoch@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).