* [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm [not found] <20200710154935.697190-1-philippe.schenker@toradex.com> @ 2020-07-10 15:49 ` Philippe Schenker 2020-07-13 2:49 ` Peter Chen 2020-07-10 15:49 ` [PATCH 3/3] ARM: dts: colibri-imx6ull: disable runtime pm Philippe Schenker 1 sibling, 1 reply; 3+ messages in thread From: Philippe Schenker @ 2020-07-10 15:49 UTC (permalink / raw) To: Rob Herring, devicetree, linux-usb, Peter Chen, Shawn Guo Cc: Greg Kroah-Hartman, Sascha Hauer, linux-kernel, Philippe Schenker, NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel Chipidea depends on some hardware signals to be there in order for runtime-pm to work well. Add the possibility to disable runtime power management that is necessary for certain boards. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 5ae16368a0c7..5078d0695eb7 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) usb_phy_init(pdata.usb_phy); } + if (of_property_read_bool(np, "disable-runtime-pm")) + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM; + if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM) data->supports_runtime_pm = true; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm 2020-07-10 15:49 ` [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker @ 2020-07-13 2:49 ` Peter Chen 0 siblings, 0 replies; 3+ messages in thread From: Peter Chen @ 2020-07-13 2:49 UTC (permalink / raw) To: Philippe Schenker Cc: devicetree@vger.kernel.org, Fabio Estevam, Sascha Hauer, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring, dl-linux-imx, Pengutronix Kernel Team, Greg Kroah-Hartman, Shawn Guo, linux-arm-kernel@lists.infradead.org On 20-07-10 17:49:33, Philippe Schenker wrote: > Chipidea depends on some hardware signals to be there in order > for runtime-pm to work well. Add the possibility to disable runtime > power management that is necessary for certain boards. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > --- > > drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > index 5ae16368a0c7..5078d0695eb7 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) > usb_phy_init(pdata.usb_phy); > } > > + if (of_property_read_bool(np, "disable-runtime-pm")) > + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM; > + > if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM) > data->supports_runtime_pm = true; > The changes are OK, you may add some descriptions like Fabio suggested, eg, your use cases. -- Thanks, Peter Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] ARM: dts: colibri-imx6ull: disable runtime pm [not found] <20200710154935.697190-1-philippe.schenker@toradex.com> 2020-07-10 15:49 ` [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker @ 2020-07-10 15:49 ` Philippe Schenker 1 sibling, 0 replies; 3+ messages in thread From: Philippe Schenker @ 2020-07-10 15:49 UTC (permalink / raw) To: Rob Herring, devicetree, linux-usb, Peter Chen, Shawn Guo Cc: Sascha Hauer, linux-kernel, Philippe Schenker, NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel The Colibri iMX6ULL has a somewhat special hardware design due to some legacy decisions regarding USB OTG. This leads to different issues when runtime PM is enabled. Disable runtime power management on colibri-imx6ull USB. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- arch/arm/boot/dts/imx6ull-colibri.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi index 9145c536d71a..1c6692237506 100644 --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi @@ -195,6 +195,7 @@ &uart5 { }; &usbotg1 { + disable-runtime-pm; dr_mode = "otg"; srp-disable; hnp-disable; @@ -202,6 +203,7 @@ &usbotg1 { }; &usbotg2 { + disable-runtime-pm; dr_mode = "host"; }; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200710154935.697190-1-philippe.schenker@toradex.com>
2020-07-10 15:49 ` [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker
2020-07-13 2:49 ` Peter Chen
2020-07-10 15:49 ` [PATCH 3/3] ARM: dts: colibri-imx6ull: disable runtime pm Philippe Schenker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).