From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C895C433E2 for ; Mon, 13 Jul 2020 03:02:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1ADA2074F for ; Mon, 13 Jul 2020 03:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B5HJu/If"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AG4m+3cV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1ADA2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6e7MzbbdCNWY+/hauvV+MvWbktNSVWm/F6yhbAUdNT0=; b=B5HJu/IfvJoBTxN9hh3rG1vFy 1cxruLM8e8GXgp2SFLWZk2XhRTq6m9nSaGKc1IrV7aMtQPFOeZPt27rQfyRmhUP0kSWzRgKcC9O7A 8EiCT2tI3XWuxLHCuwZecGI146MT7a9J1d6csPekuH4QJlFb1LsKj1pU0gWX1Fmv4t6S0eCJb79kp U6vN1skY4TFvwyhYvqlUXPYL+tUa9Fp6jDaL/lCGp1fgY7c/y9MrsYmBEpnXadzDmlBCpXapMTGKG TPw4VvAn4JbCIfqdMN0XE7akt/TsuuXMnepI+qevPcB2rtF0ZY0jwtFGvSVtlBHaG8KpFjoz2SyfZ 1zIj2W08g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juoiK-0008Aq-Lw; Mon, 13 Jul 2020 03:01:08 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juoiH-00089l-4G for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 03:01:06 +0000 Received: by mail-pg1-x542.google.com with SMTP id j19so5398329pgm.11 for ; Sun, 12 Jul 2020 20:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GV4IomG6qj4F1GMNLsaNJW9pUDWfsK4KtOliKaa9r4M=; b=AG4m+3cVsDUZHrXHV7Dg997rQayoox9XRupkxW5sz3TXp1nMng3UKLPXZxaL9cvZUg WRGwnE0EQkpAm7E2PQHh7TGOMcrfswpGcx3ai4Vma1rkZ+CQsBLNa0GxwWCRJxqY7DL5 fwKVtyZaY0IJVisG8EOAq6xLLp931xNoBm+0+h1qZ/F01pydZ2hIAJM7QTK34uCBY0hM OLlSAbuiGqapTUjqJJOm1WE5MJr8o2V/xYiiVgIHCVKALHnGPz6xBXvHsxw62dqtVor/ OyxPXIXMc0p09EvsK5sA+zicimEm+TMI34/RgbC6r2AQ+OAb6JWSUaNkoFBVueHH6tlA MeAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GV4IomG6qj4F1GMNLsaNJW9pUDWfsK4KtOliKaa9r4M=; b=o+bEPB91f0dFznoGrr7f1A+NE35/MUny2Kt3NbAWWwTdGgPvVJ7CVudkBxGw1k+XXr 8pGcbcEVaxDHBi2eg7kvp0tOIIqkbzZ/0wD32oP5uldlkF5uwar66imPYffXjKcDgWet jXdNxVAtgsPTaQc1SQfio7BOTNwtO9uD7H/CW72FllvWv9gQjXRyoU7QT+oCo2Vdh0JE a2+N7sQ8eoX9GAWx01OX1xMsz8m/xb0Ky9MINEKxoM2CQ47GFOUolwhDuyrCc17fKsQa bk3cSIC4uv6ZTEKobw08MF702Va/uxpKagBOj4/MshmctOMdfJR3qFqL8ORFYsi5hAAO pF3A== X-Gm-Message-State: AOAM533h98JAo110aY9v1Hy60WqfPhXIb+bNuch5prOipEjFtH+cVBcK IZmyKNP+XEf/L1JvlsodNvzI X-Google-Smtp-Source: ABdhPJy+HlXUxaa/u4zIP4jzIn73PFiw/wD7SgvPDfi3JVrz26O53QmdcVR5DxpZn5oiTEhi+yyPug== X-Received: by 2002:a63:7246:: with SMTP id c6mr67503848pgn.422.1594609262825; Sun, 12 Jul 2020 20:01:02 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:985:5688:92a:5a4d:636b:c45f]) by smtp.gmail.com with ESMTPSA id b128sm11834488pfg.114.2020.07.12.20.00.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Jul 2020 20:01:01 -0700 (PDT) Date: Mon, 13 Jul 2020 08:30:56 +0530 From: Manivannan Sadhasivam To: Amit Tomer Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7 Message-ID: <20200713030055.GA2978@Mani-XPS-13-9360> References: <1593701576-28580-1-git-send-email-amittomer25@gmail.com> <1593701576-28580-11-git-send-email-amittomer25@gmail.com> <20200712173044.GL6110@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_230105_223415_278458CE X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Andre Przywara , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, cristian.ciocaltea@gmail.com, Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 12:15:28AM +0530, Amit Tomer wrote: > Hi, > > On Sun, Jul 12, 2020 at 11:00 PM Manivannan Sadhasivam > wrote: > > > > On Thu, Jul 02, 2020 at 08:22:56PM +0530, Amit Singh Tomar wrote: > > > This commit adds uSD support for Cubieboard7 board based on Actions Semi > > > S700 SoC. SD0 is connected to uSD slot. Since there is no PMIC support > > > added yet, fixed regulator has been used as a regulator node. > > > > > > Signed-off-by: Amit Singh Tomar > > > --- > > > Changes since v4: > > > * No change. > > > Changes since v3: > > > * No change. > > > Changes since v2: > > > * No change. > > > Changes since v1: > > > * No change. > > > Changes since RFC: > > > * No change. > > > --- > > > arch/arm64/boot/dts/actions/s700-cubieboard7.dts | 41 ++++++++++++++++++++++++ > > > arch/arm64/boot/dts/actions/s700.dtsi | 1 + > > > 2 files changed, 42 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > > index 63e375cd9eb4..ec117eb12f3a 100644 > > > --- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > > +++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > > @@ -13,6 +13,7 @@ > > > > > > aliases { > > > serial3 = &uart3; > > > + mmc0 = &mmc0; > > > }; > > > > > > chosen { > > > @@ -28,6 +29,23 @@ > > > device_type = "memory"; > > > reg = <0x1 0xe0000000 0x0 0x0>; > > > }; > > > + > > > + /* Fixed regulator used in the absence of PMIC */ > > > + vcc_3v1: vcc-3v1 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "fixed-3.1V"; > > > + regulator-min-microvolt = <3100000>; > > > + regulator-max-microvolt = <3100000>; > > > + }; > > > > Is this regulator used somewhere? > > This is something I copied from bubblegum dts as I wasn't sure what is right way > to include these regulators. > > Also, another day tested it without having these regulators in , and > still it seems to > work. So should these be removed ? > Fixed regulators are used to nicely model the regulators which aren't tied to any PMIC. But for some cases we use them to represent supplies when there is no support for the specific PMIC present in the kernel and they are turned on/configured by the bootloader (this is what happening here). And there is no use of declaring fixed regulators when there is no consumer. Even if you don't define these, the corresponding supplies in the board will always be in the same state configured by the bootloader. So I'd suggest you to remove this for now. Since I don't have the schematics to check, please make sure you name the regulators as mentioned in the schematics (this could vary from board to board, so don't just copy from others). Thanks, Mani > Thanks > -Amit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel