From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646F2C433E0 for ; Mon, 13 Jul 2020 06:20:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E87E2065F for ; Mon, 13 Jul 2020 06:20:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AVk+8K/W"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="D4+1yQRp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E87E2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=44zo9ewCM2D/QyWzs+WDirrOB+a6cHdYNQvdsXDEtO0=; b=AVk+8K/W3CU6metRxpYBmbEkd wlrtNeqPsLpqEWkUQO9geyJUD/d2fMMculayl1jnIC15UFH5XJ4eHrJ98zqaufRTKyqYd34CCCHWQ zW6O1E4IQ/IZnfPT1lWrBpB/RjEdcE+J819X49iHTthk7U9Wjva3hcVTjOedW1/AfD4V2BFkMUtOC 0Gd2L1DMuWcnHkavmABiTEhBm5+YAyT8Q8GCsZsfeBgv0UsLHi7e5BGIMVJJzN/JvQEGjFEPndPaE d751dqN86W7sqJoPK3r1sg/ESQwui2tZp1QLo50gsSyT1PB8GM+Zk60+5r7kQ8KUUUa4yJ4BqIdzQ UNG0iMnNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jurnh-0001qN-Rj; Mon, 13 Jul 2020 06:18:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jurnf-0001pX-DF for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 06:18:52 +0000 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFA412065F; Mon, 13 Jul 2020 06:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594621130; bh=hXHCtXD4RJbWVedvu6u9jHc3/dLrfcFLZ/u3QlppIXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D4+1yQRpJHH7xk0Cxq1yFppBnw2P2siD6Fzor2gxKeAFxi53s93i5mZcjFqw03GK3 XI701noqf23ekCWpTOHfNvzG8mnJs4jcwYhibApH1a/ihUdzjkoLKqEQ5QoD/XZoWL m33wml+mnE9hAMxIm2IMTy3LpfxOxOdzFliyFl10= Date: Mon, 13 Jul 2020 11:48:46 +0530 From: Vinod Koul To: Russell King - ARM Linux admin Subject: Re: [PATCH 2/2] phy: armada-38x: fix NETA lockup when repeatedly switching speeds Message-ID: <20200713061846.GE34333@vkoul-mobl> References: <20200630160452.GD1551@shell.armlinux.org.uk> <20200701065727.GY2599@vkoul-mobl> <20200710151921.GJ1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710151921.GJ1551@shell.armlinux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_021851_926070_D94ED69E X-CRM114-Status: GOOD ( 35.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Gregory Clement , Kishon Vijay Abraham I , Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10-07-20, 16:19, Russell King - ARM Linux admin wrote: > On Wed, Jul 01, 2020 at 12:27:27PM +0530, Vinod Koul wrote: > > On 30-06-20, 17:05, Russell King wrote: > > > The mvneta hardware appears to lock up in various random ways when > > > repeatedly switching speeds between 1G and 2.5G, which involves > > > reprogramming the COMPHY. It is not entirely clear why this happens, > > > but best guess is that reprogramming the COMPHY glitches mvneta clocks > > > causing the hardware to fail. It seems that rebooting resolves the > > > failure, but not down/up cycling the interface alone. > > > > > > Various other approaches have been tried, such as trying to cleanly > > > power down the COMPHY and then take it back through the power up > > > initialisation, but this does not seem to help. > > > > > > It was finally noticed that u-boot's last step when configuring a > > > COMPHY for "SGMII" mode was to poke at a register described as > > > "GBE_CONFIGURATION_REG", which is undocumented in any external > > > documentation. All that we have is the fact that u-boot sets a bit > > > corresponding to the "SGMII" lane at the end of COMPHY initialisation. > > > > > > Experimentation shows that if we clear this bit prior to changing the > > > speed, and then set it afterwards, mvneta does not suffer this problem > > > on the SolidRun Clearfog when switching speeds between 1G and 2.5G. > > > > > > This problem was found while script-testing phylink. > > > > > > Signed-off-by: Russell King > > > --- > > > arch/arm/boot/dts/armada-38x.dtsi | 3 +- > > > > lgtm, i need ack for dts parts before I can apply this > > I'm not sure what the situation is for Bootlin, but they don't seem to > be very responsive right now (covid related?) > > What I know from what I've been party to on netdev is that Bootlin > sent a patch for the MVPP2 driver, and the very next day someone > reported that the patch caused a bug. Unfortunately, the patch got > picked up anyway, but there was no response from Bootlin. After a > month or so, -final was released containing this patch, so now it > had become a regression - and still no response from Bootlin. > > Eventually the bug got fixed - not because Bootlin fixed it, but > because I ended up spending the time researching how that part of > the network driver worked, diagnosing what was going on, and > eventually fixing it in the most obvious way - but it's not clear > that the fix was the right approach. Bootlin never commented. See > 3138a07ce219 ("net: mvpp2: fix RX hashing for non-10G ports"). > > So, I think we have to assume that Bootlin are struggling right now, > and as it's been over a week, it's unlikely that they are going to > respond soon. What do you think we should do? > > I also note that Rob has not responded to the DT binding change > either, despite me gently prodding, and Rob processing a whole raft > of DT binding stuff yesterday. > > I can split the DTS change from the rest of the patch, but I don't > think that really helps without at least the binding change being > agreed. I would prefer splitting, you may sent the DTS to arm arch folks if no response from subarch folks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel