From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40846C433DF for ; Mon, 13 Jul 2020 10:53:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08AD620758 for ; Mon, 13 Jul 2020 10:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MFSsAfwQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IpC2uSQJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08AD620758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BZgvt1SHeyLU8AZ8T0UrHeMyn3jqZI40IhTi4gnXhrk=; b=MFSsAfwQCaW2K4ANtKioComgL h52JSCe+t0qiJgMrrcEonfVz8PSv1KZ071OSavMA5UTsuTrDMtojNHoDsLqKkHP1xBm2tLokz1tI9 3ySPVhzgTcZjK4FZXjiR2V9NrhIYmS+OBTywJr5UURAeSYtjYnr0Jy/YRO4TvcQ4jgZOXwe+Hfs8R xVGe/CKNzqnlqOlD49PLPJGLmC7b2v9GmwdbtV2iI4zIVaNE6E0JIwEWb6ks3LgPResxrwYkTCgv4 fFZRjYTa9s+PUocruFtsmD0niR4fjTrY14EFZpNk/ss7r4cTdek/YxWYx8ExsYqf2saNwCshDX1R4 HJG53PGNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juw4W-0002b9-1Q; Mon, 13 Jul 2020 10:52:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juw4T-0002aW-Lg for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 10:52:30 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4933020773; Mon, 13 Jul 2020 10:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594637546; bh=ADqVZRWZ/51fjjRPcMqetiQetPZ84+yWUeey/gb/nUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IpC2uSQJRwoNT6hkjWdSmS6Qn5EDAzTySC6hz2Sj0WilIDu3UOC7m1U2k2p8l2DcV adnQd6KIIyxKLh52sebskcVgxdGfQzuo3gqnKMHSSMdVaw6UFodxwXuEwND/keqv1y krEFqpxgDguMEYS3qRh3XxHN0YzdgYGdeWzExU6I= Date: Mon, 13 Jul 2020 18:52:20 +0800 From: Shawn Guo To: Ahmad Fatoum Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Message-ID: <20200713105219.GN15718@dragon> References: <20200710132423.497230-1-philippe.schenker@toradex.com> <20200710132423.497230-3-philippe.schenker@toradex.com> <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_065229_858431_E15DAAD1 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Philippe Schenker , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 11:46:04AM +0200, Ahmad Fatoum wrote: > Hello Philippe, > > On 7/10/20 3:24 PM, Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > > drivers/usb/chipidea/core.c usb dual-role host/device switching is > > working. So make use of it. > > > > Signed-off-by: Philippe Schenker > > > > --- > > > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 9 +++++++++ > > arch/arm/boot/dts/imx7-colibri.dtsi | 4 ++-- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > index 97601375f264..db56a532a34a 100644 > > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > @@ -20,6 +20,14 @@ clk16m: clk16m { > > clock-frequency = <16000000>; > > }; > > > > + extcon_usbc_det: usbc_det { > > + compatible = "linux,extcon-usb-gpio"; > > According to 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver"): > "the old way using extcon to support USB Dual-Role switch is now deprecated > when use Type-B connector." > > Have you considered using a compatible = "gpio-usb-b-connector" child node instead? I dropped patch #2 and #3 for now. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel