From: Sudeep Holla <sudeep.holla@arm.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dien Pham <dien.pham.ry@renesas.com>
Subject: Re: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates
Date: Mon, 13 Jul 2020 14:21:53 +0100 [thread overview]
Message-ID: <20200713132153.GA30377@bogus> (raw)
In-Reply-To: <159442504011.1987609.3990897866011325023@swboyd.mtv.corp.google.com>
On Fri, Jul 10, 2020 at 04:50:40PM -0700, Stephen Boyd wrote:
> Quoting Sudeep Holla (2020-07-09 01:17:05)
> > Currently we are not initializing the scmi clock with discrete rates
> > correctly. We fetch the min_rate and max_rate value only for clocks with
> > ranges and ignore the ones with discrete rates. This will lead to wrong
> > initialization of rate range when clock supports discrete rate.
> >
> > Fix this by using the first and the last rate in the sorted list of the
> > discrete clock rates while registering the clock.
> >
> > Link: https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com
> > Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI")
> > Reported-by: Dien Pham <dien.pham.ry@renesas.com>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/clk/clk-scmi.c | 22 +++++++++++++++++++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > Hi Stephen,
> >
> > If you are fine, I can take this via ARM SoC along with the change in
> > firmware driver. However it is also fine if you want to merge this
> > independently as there is no strict dependency. Let me know either way.
>
> I don't mind either way. If you want to send it in along with the
> firmware change then that's fine.
>
OK I have now queued and will send it to arm-soc.
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for the review.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 13:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:17 [PATCH v2 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted Sudeep Holla
2020-07-09 8:17 ` [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Sudeep Holla
2020-07-09 8:26 ` Dien Pham
2020-07-09 8:39 ` Sudeep Holla
2020-07-09 8:55 ` Dien Pham
2020-07-10 23:50 ` Stephen Boyd
2020-07-13 13:21 ` Sudeep Holla [this message]
2020-07-13 13:00 ` [PATCH v2 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713132153.GA30377@bogus \
--to=sudeep.holla@arm.com \
--cc=dien.pham.ry@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).