From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AAD2C43619 for ; Mon, 13 Jul 2020 13:23:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68640206F4 for ; Mon, 13 Jul 2020 13:23:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sQh9FxsX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68640206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JZXTKfhyuzfWZ3JZ2ubKEUZlQTibKrmVliaMskIScGA=; b=sQh9FxsX6cHYqHWPUU8yjSABK h8ETrXLPpHc3Q6+fc+2+2FcFjnuj5E5QqaYKFyM4qL2PdRlLGbhX8gu+wXNk/uxWuF+dH7ij3tI/i 8coSePlKvxZPXiv/Al8nONu7ChwGwUbKBvTL5qHKCmbRB4GGhjrllmBJYT7Hht1gH3GiPFPg2+KTQ BhEQ0FC3QFiW2aTQMuBN3L7KDuzdkuR+faXtryAcKtLqE4OdmuGEzFrxj58gAaWvTRHZRp8moCTwN 1vQtZayKqFQbwMz3nGWHzn/JOfc7XD8n1xIH31Muw5rBIK00ithuRC5wbMSqRKlL9atLf6Nt8Wiz9 q2sK3ZskQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juyPJ-0006Ba-Qn; Mon, 13 Jul 2020 13:22:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juyPF-0006Am-Ue for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 13:22:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0D2130E; Mon, 13 Jul 2020 06:22:02 -0700 (PDT) Received: from bogus (unknown [10.37.8.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10A2F3F887; Mon, 13 Jul 2020 06:22:00 -0700 (PDT) Date: Mon, 13 Jul 2020 14:21:53 +0100 From: Sudeep Holla To: Stephen Boyd Subject: Re: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Message-ID: <20200713132153.GA30377@bogus> References: <20200709081705.46084-1-sudeep.holla@arm.com> <20200709081705.46084-2-sudeep.holla@arm.com> <159442504011.1987609.3990897866011325023@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <159442504011.1987609.3990897866011325023@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_092206_055455_8BBD5EFB X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dien Pham Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 04:50:40PM -0700, Stephen Boyd wrote: > Quoting Sudeep Holla (2020-07-09 01:17:05) > > Currently we are not initializing the scmi clock with discrete rates > > correctly. We fetch the min_rate and max_rate value only for clocks with > > ranges and ignore the ones with discrete rates. This will lead to wrong > > initialization of rate range when clock supports discrete rate. > > > > Fix this by using the first and the last rate in the sorted list of the > > discrete clock rates while registering the clock. > > > > Link: https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com > > Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") > > Reported-by: Dien Pham > > Signed-off-by: Sudeep Holla > > --- > > drivers/clk/clk-scmi.c | 22 +++++++++++++++++++--- > > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > Hi Stephen, > > > > If you are fine, I can take this via ARM SoC along with the change in > > firmware driver. However it is also fine if you want to merge this > > independently as there is no strict dependency. Let me know either way. > > I don't mind either way. If you want to send it in along with the > firmware change then that's fine. > OK I have now queued and will send it to arm-soc. > Reviewed-by: Stephen Boyd Thanks for the review. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel