* [PATCH] Staging: vc04_services: Fix code indent error
@ 2020-07-13 7:22 Baidyanath Kundu
2020-07-13 13:35 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Baidyanath Kundu @ 2020-07-13 7:22 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Greg Kroah-Hartman
Cc: devel, Baidyanath Kundu, linux-kernel, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
---
.../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
index a075cd63da7f..86c00b68f099 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
@@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
/* queue the bulk submission */
vchiq_use_service(instance->service_handle);
ret = vchiq_bulk_receive(instance->service_handle,
- msg_context->u.bulk.buffer->buffer,
- /* Actual receive needs to be a multiple
- * of 4 bytes
- */
- (len + 3) & ~3,
- msg_context,
- VCHIQ_BULK_MODE_CALLBACK);
+ msg_context->u.bulk.buffer->buffer,
+ /* Actual receive needs to be a multiple
+ * of 4 bytes
+ */
+ (len + 3) & ~3,
+ msg_context,
+ VCHIQ_BULK_MODE_CALLBACK);
vchiq_release_service(instance->service_handle);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: vc04_services: Fix code indent error
2020-07-13 7:22 [PATCH] Staging: vc04_services: Fix code indent error Baidyanath Kundu
@ 2020-07-13 13:35 ` Greg Kroah-Hartman
2020-07-13 13:38 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-13 13:35 UTC (permalink / raw)
To: Baidyanath Kundu
Cc: devel, linux-kernel, bcm-kernel-feedback-list,
Nicolas Saenz Julienne, linux-arm-kernel, linux-rpi-kernel
On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> ---
> .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index a075cd63da7f..86c00b68f099 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> /* queue the bulk submission */
> vchiq_use_service(instance->service_handle);
> ret = vchiq_bulk_receive(instance->service_handle,
> - msg_context->u.bulk.buffer->buffer,
> - /* Actual receive needs to be a multiple
> - * of 4 bytes
> - */
> - (len + 3) & ~3,
> - msg_context,
> - VCHIQ_BULK_MODE_CALLBACK);
> + msg_context->u.bulk.buffer->buffer,
> + /* Actual receive needs to be a multiple
> + * of 4 bytes
> + */
> + (len + 3) & ~3,
> + msg_context,
> + VCHIQ_BULK_MODE_CALLBACK);
Close, you need one more space for these lines, right?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: vc04_services: Fix code indent error
2020-07-13 13:35 ` Greg Kroah-Hartman
@ 2020-07-13 13:38 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-07-13 13:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Baidyanath Kundu, linux-kernel, bcm-kernel-feedback-list,
linux-arm-kernel, Nicolas Saenz Julienne, linux-rpi-kernel
On Mon, Jul 13, 2020 at 03:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: code indent should use tabs where possible
> >
> > Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> > ---
> > .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index a075cd63da7f..86c00b68f099 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> > /* queue the bulk submission */
> > vchiq_use_service(instance->service_handle);
> > ret = vchiq_bulk_receive(instance->service_handle,
> > - msg_context->u.bulk.buffer->buffer,
> > - /* Actual receive needs to be a multiple
> > - * of 4 bytes
> > - */
> > - (len + 3) & ~3,
> > - msg_context,
> > - VCHIQ_BULK_MODE_CALLBACK);
> > + msg_context->u.bulk.buffer->buffer,
> > + /* Actual receive needs to be a multiple
> > + * of 4 bytes
> > + */
> > + (len + 3) & ~3,
> > + msg_context,
> > + VCHIQ_BULK_MODE_CALLBACK);
>
> Close, you need one more space for these lines, right?
>
Yeah. The original has the space and looks correct.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 7:22 [PATCH] Staging: vc04_services: Fix code indent error Baidyanath Kundu
2020-07-13 13:35 ` Greg Kroah-Hartman
2020-07-13 13:38 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).