Re: [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

Will Deacon
2020-07-13T15:12:41Z

On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote:
> Add a new implementation hook to allow the implementation specific code
> to tweek the context bank configuration just before it gets written.
> The first user will be the Adreno GPU implementation to turn on
> SCTLR.HUPCF to ensure that a page fault doesn't terminating pending
> transactions. Doing so could hang the GPU if one of the terminated
> transactions is a CP read.
>
> This depends on the arm-smmu adreno SMMU implementation [1].
>
> [1] https://patchwork.kernel.org/patch/11600943/
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
>
> drivers/iommu/arm-smmu-qcom.c | 13 +++++++++++++
> drivers/iommu/arm-smmu.c | 28 +++++++++++++---------------
> drivers/iommu/arm-smmu.h | 11 +++++++++++
> 3 files changed, 37 insertions(+), 15 deletions(-)

This looks straightforward enough, but I don't want to merge this without
a user and Sai's series has open questions afaict.

Will