Re: [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

Will Deacon
2020-07-13T19:05:21Z

On Mon, Jul 13, 2020 at 11:00:32AM -0600, Jordan Crouse wrote:
> On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote:
> > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote:
> > > Add a new implementation hook to allow the implementation specific code
> > > to tweek the context bank configuration just before it gets written.
> > > The first user will be the Adreno GPU implementation to turn on
> > > SCTLR.HUPCF to ensure that a page fault doesn't terminating pending
> > > transactions. Doing so could hang the GPU if one of the terminated
> > > transactions is a CP read.
> > >
> > > This depends on the arm-smmu adreno SMMU implementation [1].
> > >
> > > [1] https://patchwork.kernel.org/patch/11600943/
> > >
> > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > > ---
> > >
> > > drivers/iommu/arm-smmu-qcom.c | 13 +++++++++++++
> > > drivers/iommu/arm-smmu.c | 28 +++++++++++++---------------
> > > drivers/iommu/arm-smmu.h | 11 +++++++++++
> > > 3 files changed, 37 insertions(+), 15 deletions(-)
> >
> > This looks straightforward enough, but I don't want to merge this without
> > a user and Sai's series has open questions afaict.
>
> Not sure what you mean by a user in this context?
> Are you referring to https://patchwork.kernel.org/patch/11628541/?

Right, this post was just a single patch in isolation, whereas it was
reposted over at:

https://lore.kernel.org/r/cdcc6a1c95a84e774790389dc8b3b7feeee490dc.1593344119.git.saiprakash.ranjan@codeaurora.org

so I'll ignore this one. Sorry, I'm just really struggling to keep track
of what is targetting 5.9, and I don't have tonnes of time to sift through
the backlog of duplicate postings :(

Will