From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1170FC433E0 for ; Mon, 13 Jul 2020 17:02:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D82AB20738 for ; Mon, 13 Jul 2020 17:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a99vtsZw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D82AB20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=04OElHWq0Nfw0pXBh17moaajqbrEV/FntiiLEKECrVI=; b=a99vtsZwDddecNbfBWXV/dxMc CbjYsj+iRBFbM1GVy0Kwnnp+XqUJW82uErqqTwKvg40+te/y/VgWAnwbxMCmJ1iQnlbYt6qjLIDcD JWkq4S5yOb3FaLfv769ewo6bCsd0WZW0oJvl+ukXnKj+hf5mXpW+scavDZ4IwJQ/otmTmR5PzXjQ5 5lCokLFTZLqO3vKuNat1q5vht++LH2V6SYm5/bmZleYPdnmpH00hyKcQA1AP8s5t3AhgH6C1joYNF noD+rGRxBJ6/UaWpOzZCYsn2qansu1TobZOoBMbYsDJ1jI65CagncZChSySS6TK22OaD1ABr5T+vm SUNOKQfnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv1pS-0004lK-Hj; Mon, 13 Jul 2020 17:01:22 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv1pO-0004kH-QV for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 17:01:19 +0000 Received: by mail-il1-f194.google.com with SMTP id r12so11804045ilh.4 for ; Mon, 13 Jul 2020 10:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u+ATDfebf9MV39yazJSR2REjUJRTM5Ietg8G+hjq9hs=; b=EEDQ441Rh3QowxbklW3/PqK9A2GDu8Sy8WpYKQbnOtZYz6b3IQHhSNUyZQwdepJ/PI I+b9UQRCOubLMrBxhGi7sMDEp7nmwriOgJ7wf8LwzrEUUJIy1BYkW9Qwz1enzLwcxxFf 3fYgH7w2z6upA08U3mSAIGVNrXFgQhtJjSRBYkGZJ9ydZG/kxHk/iZZvNk7bzVu8bf+Y g3fHUTMTtiLbwCL/+4OoQWh7u8LtJFGfP3ZlktIFKQ4Qkd5PjghOv3LJs+dd5bbqbUof kzahI6YG6sIL8kgFLtYGtLrJTU8fiaGx/273dZbtIcqsnPxvGSZpqo3rS4OE+PhMe3/M tLQQ== X-Gm-Message-State: AOAM532w0iXNiF38C0AgL3jwCVL8awii4Hb2NrJBiEX/Lf1NOCl3xMrL PbZQAr1oKCv/kTaqYp+q+w== X-Google-Smtp-Source: ABdhPJz8Xnzy5VMGLC1oVbharKqEmV8XouNZObzNUKUHDywbuYQ837jCWWk9uWJgtsZ2IZZCJw3hPw== X-Received: by 2002:a92:9892:: with SMTP id a18mr656663ill.60.1594659678061; Mon, 13 Jul 2020 10:01:18 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id w4sm7909214ioc.23.2020.07.13.10.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 10:01:17 -0700 (PDT) Received: (nullmailer pid 384200 invoked by uid 1000); Mon, 13 Jul 2020 17:01:16 -0000 Date: Mon, 13 Jul 2020 11:01:16 -0600 From: Rob Herring To: Benjamin Gaignard Subject: Re: [PATCH v4 1/5] dt-bindings: bus: Add firewall bindings Message-ID: <20200713170116.GA364356@bogus> References: <20200701132523.32533-1-benjamin.gaignard@st.com> <20200701132523.32533-2-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701132523.32533-2-benjamin.gaignard@st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_130118_871365_D17B0E15 X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.torgue@st.com, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, tomase@xilinx.com, mcoquelin.stm32@gmail.com, stefano.stabellini@xilinx.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2020 at 03:25:19PM +0200, Benjamin Gaignard wrote: > Add schemas for firewall consumer and provider. > > Signed-off-by: Benjamin Gaignard > Reviewed-by: Linus Walleij > --- > .../bindings/bus/stm32/firewall-consumer.yaml | 36 ++++++++++++++++++++++ > .../bindings/bus/stm32/firewall-provider.yaml | 18 +++++++++++ > 2 files changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml > create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml > > diff --git a/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml > new file mode 100644 > index 000000000000..d3d76f99b38d > --- /dev/null > +++ b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Bus Firewall consumer binding I'm all for common bindings, but I want to see more than 1 user before accepting this. There's been some other postings for similar h/w (AFAICT) recently. > + > +description: | > + Firewall properties provide the possible firewall bus controller > + configurations for a device. > + Bus firewall controllers are typically used to control if a hardware > + block can perform read or write operations on bus. > + The contents of the firewall bus configuration properties are defined by > + the binding for the individual firewall controller device. > + > + The first configuration 'firewall-0' or the one named 'default' is > + applied before probing the device itself. This is a Linux implementation detail and debatable whether the core should do this or drivers. > + > +maintainers: > + - Benjamin Gaignard > + > +# always select the core schema > +select: true > + > +properties: > + firewall-0: true > + > + firewall-names: true > + > +patternProperties: > + "firewall-[0-9]": > + $ref: "/schemas/types.yaml#/definitions/phandle-array" So I guess multiple properties is to encode all the modes into DT like pinctrl does. Is that really necessary? I don't think so as I wouldn't expect modes to be defined by the consumer, but by the provider in this case. To use pinctrl as a example, we could have pad setting per MMC speed. That has to be in the consumer side as the pinctrl knows nothing about MMC. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel