From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FBCC433E1 for ; Mon, 13 Jul 2020 18:25:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8568E20738 for ; Mon, 13 Jul 2020 18:25:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u6BUW8OG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8568E20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Is59+vpmr3fBFcaLEsL2Tkw3QZ/Y/QS8/x+mxAcS80=; b=u6BUW8OG2/syVQr2IBz2XVj5M ZZA6ye7LOwGrGbPhKNv3400IX9BUYHHg3+McSs5C3eQlF94U4e0v5MVXVhnCLr9uAOmLkWqsTQdVk G7EKX5RFLvu6fFdcGz+tuXZdSsjUe8cxghYDwzI5P9jWX3IFn4DpCbaj7e7E3RF5kBXE25aAbg4pZ M6d/rsbjnoahXHeyI0L4bIfRBk8gtdaBErrSCidiouIjFYPy0bL3fJfEbFZxG5iVAXoMXd7VCULKU kJwoJC1c/bIfQh2U9g3mTapvIO3ZYi90At+DamChaYzezaNT6XbQ/E4eETZSAU/WDRti25tmkdjxm gSnN/4XIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv37S-00050F-UN; Mon, 13 Jul 2020 18:24:02 +0000 Received: from mail-io1-f65.google.com ([209.85.166.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv37Q-0004zY-2O; Mon, 13 Jul 2020 18:24:00 +0000 Received: by mail-io1-f65.google.com with SMTP id c16so14532080ioi.9; Mon, 13 Jul 2020 11:23:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ifx3aALNuF7rKl8vX3SdTnNE70Q3qXp0lBlunsaf+O4=; b=dbDFoxK/MCEIGoyT3P+NAmjHQmNZD0g60C8i4R54Ixi8SeJa9sPMvUoaOYJWLQQM28 NuWKSfl53y229uWH3hEu0aWK4ovNeMkBspsTIDpFmUSGPGxc5rAhagrurgoLR3Y2HUHM cLyZiFotywsaDP6I0zjpib8FrnHwNrP5xH4lsiftZE2kFdC7deZP4mRUxcmZV4n30tUe /mZ+Tl66J4UAbhZxLYZ4+gCzdOe0s+CE+rrzGLSXYll28fm/qgzibD13arYIrBfVSgEn jcv8sdFdsWz9jYENtoK1cM+cniLn2lyu5zSA5IMA0QeOdOxrb8xZNEJ6Xz7+CDRmY/Ni 6t5w== X-Gm-Message-State: AOAM530rC4OiOL7CQwk1V5mGlj6+/ASBJ1udkN2aEhPGg0q1gW/APcGd S0afj8ME8UmOtkln4m9VyA== X-Google-Smtp-Source: ABdhPJya3sqMPQiW2H/b993RNfsrgt3J2EBCVEUsT+0P5mubEbH1CLbcW6JdVEJ2qL9zNx+NokQEPw== X-Received: by 2002:a5e:dd4c:: with SMTP id u12mr1090199iop.14.1594664638827; Mon, 13 Jul 2020 11:23:58 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id t1sm8159994iob.16.2020.07.13.11.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 11:23:58 -0700 (PDT) Received: (nullmailer pid 493759 invoked by uid 1000); Mon, 13 Jul 2020 18:23:56 -0000 Date: Mon, 13 Jul 2020 12:23:56 -0600 From: Rob Herring To: Nicolas Saenz Julienne Subject: Re: [PATCH v3 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller Message-ID: <20200713182356.GA413630@bogus> References: <20200612171334.26385-1-nsaenzjulienne@suse.de> <20200612171334.26385-2-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200612171334.26385-2-nsaenzjulienne@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_142400_145962_99AB8665 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com, mathias.nyman@linux.intel.com, Scott Branden , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Anholt , andy.shevchenko@gmail.com, tim.gover@raspberrypi.org, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, p.zabel@pengutronix.de, Ray Jui , helgaas@kernel.org, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2020 at 07:13:25PM +0200, Nicolas Saenz Julienne wrote: > The firmware running on the RPi VideoCore can be used to reset and > initialize HW controlled by the firmware. > > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > > --- > Changes since v2: > - Add include file for reset IDs > > Changes since v1: > - Correct cells binding as per Florian's comment > - Change compatible string to be more generic > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++ > .../reset/raspberrypi,firmware-reset.h | 13 ++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 include/dt-bindings/reset/raspberrypi,firmware-reset.h > > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > index b48ed875eb8e..23a885af3a28 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > @@ -39,6 +39,22 @@ properties: > - compatible > - "#clock-cells" > > + reset: I'm not really thrilled how this is evolving with a node per provider. There's no reason you can't just add #clock-cells and #reset-cells to the parent firmware node. I probably should have complained with the clocks node, but that's only pending for 5.9. The bigger issue is this stuff is just trickling in one bit at a time which gives no context for review. What's next? Is it really a mystery as to what functions the firmware provides? You don't have to have a driver in place for every function. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel