From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C164C433DF for ; Mon, 13 Jul 2020 18:56:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D53F2067D for ; Mon, 13 Jul 2020 18:56:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZbrHk9EX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D53F2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ds5/eIjK2Dh99z8678rpx+vW4Z4tQZdy9YU6zmbMYh4=; b=ZbrHk9EXnHJJBHtlSE1DvabgC /k0qGuUM2Zsr8gUACONKdUHf6QZG7/fqkxPomgfjG2xupJkVATZdRDLVlwfYOLNqv+XxHydp9rZxD 8DzzcwHXzQe4aiYG9g6o+Rf5yI4uaG7bRTA09wP5HmUhchQcH2YzZ/nP7DxO2ANhdWmTYgkJaWgxq uGKbEKxBk2xGz0gR1RBT28QNfgiv/wJP38ZkrMoeo929rWcTylYchufgCBP6SmMqlM93KxiegB/qN WkL7FselKPRMNNlkZc+iV9HKFCD5xv15Q0/JqiYXCbsYab4eF5duNfWS5ifqGrTvgvuYb8wzdzW98 QExSQIPIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv3bI-0002By-Pp; Mon, 13 Jul 2020 18:54:52 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv3bG-0002At-4U for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 18:54:51 +0000 Received: by mail-io1-f67.google.com with SMTP id l17so3134246iok.7 for ; Mon, 13 Jul 2020 11:54:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GpjldxV+7Jj2vT+IvkGpTu9C3cb82+6pyMRNKhGFrns=; b=AnQTKYyObwDJvSocCPIQwwWTewTx1iCnKrv7SmDGqZyDaDUoiFOIvcqCaFk4Ri4VXH RL2uzBRPgJs73xUXR3jiPwtA0r1JIGpKJJb9CtsvLP5h566dNYBheRiUH7WTm12Etaem qBg6AulqGJ+5L3y6AUd/vxlYGPG5KxYWhSvJW2cE0NGlaNTSzz4+LoD3HX1MnyQTkNSh m/qvRZwS9UvGoRin4PHuYJOtSIlw7SUlfZoqA3v7PYI+v877v66yy37KSgqIhELLOcx2 eL2YSXJ635j0mqWIFmVE/KZ/RMc6n1bcf2NF4klj0XBj/I3eke9gExKakT8oAF/JIvro B4yQ== X-Gm-Message-State: AOAM530+BNfmfiL6wvngA3NeIM/aLfq5QS6lHmoKH7E6WtZaCH5MLjPO atCJ3Kj/Tvj3GsE2mN7C4g== X-Google-Smtp-Source: ABdhPJwfBTESnW9A9BK0215CPEqL1tvb5pOJfUAQ5J+a1D83Ui/ogMwIHTrR/fSKXGi3VJ9a15EbAg== X-Received: by 2002:a6b:ba8b:: with SMTP id k133mr1207385iof.204.1594666489080; Mon, 13 Jul 2020 11:54:49 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id a24sm8109070ioe.46.2020.07.13.11.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 11:54:48 -0700 (PDT) Received: (nullmailer pid 536032 invoked by uid 1000); Mon, 13 Jul 2020 18:54:47 -0000 Date: Mon, 13 Jul 2020 12:54:47 -0600 From: Rob Herring To: Vishal Sagar Subject: Re: [PATCH v3 2/3] media: dt-bindings: media: xilinx: Add Xilinx UHD-SDI Receiver Subsystem Message-ID: <20200713185447.GA531731@bogus> References: <20200618053304.14551-1-vishal.sagar@xilinx.com> <20200618053304.14551-3-vishal.sagar@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618053304.14551-3-vishal.sagar@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_145450_191341_C0CD03BE X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, dineshk@xilinx.com, hyunk@xilinx.com, sandipk@xilinx.com, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, michals@xilinx.com, laurent.pinchart@ideasonboard.com, joe@perches.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 18, 2020 at 11:03:03AM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx UHD-SDI Receiver Subsystem. > > The Xilinx UHD-SDI Receiver Subsystem consists of SMPTE UHD-SDI (RX) IP > core, an SDI RX to Video Bridge IP core to convert SDI video to native > video and a Video In to AXI4-Stream IP core to convert native video to > AXI4-Stream. > > Signed-off-by: Vishal Sagar > --- > v3 > - bpc instead of bpp > - removed bpc as required property (default to 10 bpc) > - add dt-bindings/media/xilinx-sdi.h > - made line-rate as u32 instead of string > - fixed reg > - fixed s/upto/up to/ > > v2 > - Removed references to xlnx,video* > - Fixed as per Sakari Ailus and Rob Herring's comments > - Converted to yaml format > > .../bindings/media/xilinx/xlnx,sdirxss.yaml | 132 ++++++++++++++++++ > include/dt-bindings/media/xilinx-sdi.h | 20 +++ > 2 files changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > create mode 100644 include/dt-bindings/media/xilinx-sdi.h > > diff --git a/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > new file mode 100644 > index 000000000000..6cfc18ca435f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/xilinx/xlnx,sdirxss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > + > +title: Xilinx SMPTE UHD-SDI Receiver Subsystem > + > +maintainers: > + - Vishal Sagar > + > +description: | > + The SMPTE UHD-SDI Receiver (RX) Subsystem allows you to quickly create systems > + based on SMPTE SDI protocols. It receives unaligned native SDI streams from > + the SDI GT PHY and outputs an AXI4-Stream video stream, native video, or > + native SDI using Xilinx transceivers as the physical layer. > + > + The subsystem consists of > + 1 - SMPTE UHD-SDI Rx > + 2 - SDI Rx to Native Video Bridge > + 3 - Video In to AXI4-Stream Bridge > + > + The subsystem can capture SDI streams in up to 12G mode 8 data streams and output > + a dual pixel per clock RGB/YUV444,422/420 10/12 bits per component AXI4-Stream. > + > +properties: > + compatible: > + items: > + - enum: > + - xlnx,v-smpte-uhdsdi-rx-ss-2.0 Should be indented 2 more spaces. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: List of clock specifiers Drop. That's every 'clocks' property. > + items: > + - description: AXI4-Lite clock > + - description: SMPTE UHD-SDI Rx core clock > + - description: Video clock > + > + clock-names: > + items: > + - const: s_axi_aclk > + - const: sdi_rx_clk > + - const: video_out_clk > + > + xlnx,bpc: > + description: Bits per component supported. Can be 10 or 12 bits per component only. > + allOf: You can drop the 'allOf' now. > + - $ref: "/schemas/types.yaml#/definitions/uint32" > + - enum: [10, 12] Seems like this should be a standard property? > + > + xlnx,line-rate: > + description: | > + The maximum mode supported by the design. Possible values are as below > + 0 - XSDI_STD_3G - 3G mode > + 1 - XSDI_STD_6G - 6G mode > + 2 - XSDI_STD_12G_8DS - 12G mode with 8 data streams > + allOf: > + - $ref: "/schemas/types.yaml#/definitions/uint32" > + - enum: [0, 1, 2] Standard? > + > + xlnx,include-edh: > + type: boolean > + description: | > + This is present when the Error Detection and Handling processor is > + enabled in design. > + > + ports: > + type: object > + description: | > + Generally the SDI port is connected to a device like SDI Broadcast camera > + which is independently controlled. Hence port@0 is a source port which can be > + connected to downstream IP which can work with AXI4 Stream data. > + properties: > + port@0: > + type: object > + description: Source port > + properties: > + reg: > + const: 0 > + endpoint: > + type: object > + properties: > + remote-endpoint: true > + required: > + - remote-endpoint > + additionalProperties: false > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - xlnx,line-rate > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + uhdsdirxss: v-smpte-uhdsdi-rxss@80000000 { > + compatible = "xlnx,v-smpte-uhdsdi-rx-ss-2.0"; > + interrupt-parent = <&gic>; > + interrupts = <0 89 4>; > + reg = <0x80000000 0x10000>; > + xlnx,include-edh; > + xlnx,line-rate = ; > + clocks = <&clk_1>, <&si570_1>, <&clk_2>; > + clock-names = "s_axi_aclk", "sdi_rx_clk", "video_out_clk"; > + xlnx,bpc = <10>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + sdirx_out: endpoint { > + remote-endpoint = <&vcap_sdirx_in>; > + }; > + }; > + }; > + }; > +... > diff --git a/include/dt-bindings/media/xilinx-sdi.h b/include/dt-bindings/media/xilinx-sdi.h > new file mode 100644 > index 000000000000..11938fade041 > --- /dev/null > +++ b/include/dt-bindings/media/xilinx-sdi.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Xilinx SDI device tree bindings > + * > + * Copyright (C) 2020 Xilinx, Inc. > + * > + * Contacts: Vishal Sagar > + */ > + > +#ifndef __DT_BINDINGS_MEDIA_XILINX_SDI_H__ > +#define __DT_BINDINGS_MEDIA_XILINX_SDI_H__ > + > +/* > + * SDI Configurations > + */ > +#define XSDI_STD_3G 0 > +#define XSDI_STD_6G 1 > +#define XSDI_STD_12G_8DS 2 > + > +#endif /* __DT_BINDINGS_MEDIA_XILINX_SDI_H__ */ > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel