From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158D8C433E4 for ; Mon, 13 Jul 2020 19:24:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D933D20663 for ; Mon, 13 Jul 2020 19:24:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KwN+MzuQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D933D20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fz9WCxgx2wCy0PvxhlcRf9kTWcMEqZT+l+UjIs282Zg=; b=KwN+MzuQKQ/pQ87gRuk3ZwrUQ wPa1eFuZCobvzPVHfDz+kn/NxzsbSxR9nwkIVseD/biU+WHyZL1BP/HOQlGEoV1kz7M6iUzK09dt9 rM4DpbHqcvx0wgiCS+XYfGFk+BJKI7iHMO6eywTifqYPOaMUIAQt5u9T4Ex3YJYUaw9+Gj8MJPts3 pl6D/ZIXXQPu5kh4Ttj9UleKgRmJTJccvbxR3IKZoK2GNKPtiNYkCcmCF8W0nSxrB+No3pi0Pznrn 8mB5wKTs0gOWZiSIDenGl6fgahr08lO1/FNenoZRswnUtIyoijYcNUV+iqanF/Sx+cKO5h8kAdO39 NDT/B5hMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv42b-0005p7-0p; Mon, 13 Jul 2020 19:23:05 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv42Y-0005og-JZ for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 19:23:03 +0000 Received: by mail-il1-f196.google.com with SMTP id s21so12186501ilk.5 for ; Mon, 13 Jul 2020 12:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z6l2qI+K33ZIyGh2iAzifK0EJmgah4onXsJ9iJQsL6k=; b=M+JIDL6F2pfqoHYYCmo8ABA/iaS61LBO2xTyzwrxoXkb4X7Nq7Pz1NwVxdz7fYIQ12 ONLnizu7kPvg9pl+56GgVKi9awlINW5LC+zT0jfEsogM+u4BFkiCNBKXuEMUT3NuGZgM kO8yTG/JXKT+jdxlyYwIbTiXXncZtwgrCV7ybRwl6ThZFlFavW883Eugy0NWIVHrD+IM qyLJqRVNC3ubqcN4EtqVKdoocBiuF9L6n24yZGNF2SozcF1nIzeuhnByuJTAGL7n2kHg 4fnvUPgbKs78p+oeIYz8X4mebjNR79HmVcYGrOtf0H+0gsGESOzxUR/bZp8oml1Zs2Lh SYsA== X-Gm-Message-State: AOAM531KupmHPU99p2oQUrl/5/2IiPnizA3+F8dPoD/BUlMNTsM/Z2SH yZNLoR+7AOAlbjE6AFdLWw== X-Google-Smtp-Source: ABdhPJx0fZoesFoSttNLhXIu0D/sCw48OSjyG1jR+wcDMT2daIoZuFNpeOuvHXA+lPdlxwrrbVB15Q== X-Received: by 2002:a92:4049:: with SMTP id n70mr1292900ila.161.1594668181506; Mon, 13 Jul 2020 12:23:01 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id y12sm8649031ilm.38.2020.07.13.12.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 12:23:00 -0700 (PDT) Received: (nullmailer pid 586277 invoked by uid 1000); Mon, 13 Jul 2020 19:22:59 -0000 Date: Mon, 13 Jul 2020 13:22:59 -0600 From: Rob Herring To: Lars Povlsen Subject: Re: [PATCH v3 5/8] dt-bindings: snps, dw-apb-ssi: Add sparx5 support, plus snps,rx-sample-delay-ns property Message-ID: <20200713192259.GA553903@bogus> References: <20200702101331.26375-1-lars.povlsen@microchip.com> <20200702101331.26375-6-lars.povlsen@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702101331.26375-6-lars.povlsen@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_152302_705309_A6AB654E X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , linux-spi@vger.kernel.org, Serge Semin , Mark Brown , Microchip Linux Driver Support , Peter Rosin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 02, 2020 at 12:13:28PM +0200, Lars Povlsen wrote: > This has the following changes for the snps,dw-apb-ss DT bindings: > > - Add "microchip,sparx5-spi" as the compatible for the Sparx5 SoC > controller > > - Add the property "mux-controls" for the above compatible string > > - Add the property "snps,rx-sample-delay-ns" for SPI slaves > > Signed-off-by: Lars Povlsen > --- > .../bindings/spi/snps,dw-apb-ssi.yaml | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index c62cbe79f00dd..9d9208391fae3 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -36,6 +36,8 @@ properties: > - mscc,ocelot-spi > - mscc,jaguar2-spi > - const: snps,dw-apb-ssi > + - description: Microchip Sparx5 SoC SPI Controller > + const: microchip,sparx5-spi > - description: Amazon Alpine SPI Controller > const: amazon,alpine-dw-apb-ssi > - description: Renesas RZ/N1 SPI Controller > @@ -93,6 +95,19 @@ properties: > - const: tx > - const: rx > > +if: > + properties: > + compatible: > + contains: > + const: microchip,sparx5-spi > + > +then: > + properties: > + mux-controls: > + description: A mux controller node for selecting SPI bus interface. > + maxItems: 1 > + $ref: '/schemas/types.yaml#/definitions/phandle' Can drop the type. You can assume common properties already have a defined type. > + > patternProperties: > "^.*@[0-9a-f]+$": > type: object > @@ -107,6 +122,14 @@ patternProperties: > spi-tx-bus-width: > const: 1 > > + snps,rx-sample-delay-ns: We already have 'rx-sample-delay-ns' from Rockchip SPI, so use that. But note that it applies to the SPI node. Does this need to be per SPI child? BTW, the Rockchip controller appears to be a version of the DW controller. > + description: SPI Rx sample delay offset, unit is nanoseconds. > + The delay from the default sample time before the actual > + sample of the rxd input signal occurs. The "rx_sample_delay" > + is an optional feature of the designware controller, and the > + upper limit is also subject to controller configuration. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > unevaluatedProperties: false > > required: > @@ -129,5 +152,10 @@ examples: > num-cs = <2>; > cs-gpios = <&gpio0 13 0>, > <&gpio0 14 0>; > + spi-flash@1 { > + compatible = "spi-nand"; > + reg = <1>; > + snps,rx-sample-delay-ns = <7>; > + }; > }; > ... > -- > 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel