From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB588C433E1 for ; Tue, 14 Jul 2020 02:44:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E88208FE for ; Tue, 14 Jul 2020 02:44:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oa6yRkpi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E88208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ozIazvXd4E47wuJjwgD7dU9vKew245jJFa3lFaWpDIw=; b=oa6yRkpiBCaSI+fKGVMK8H11R WExkE/V9SBGU/9kABg4o4CmnGaHbEiftTNgrv7rrS7fXnetVL6NApnuUEAG8WJkRH6M609sZDUOpc 5IEb/353/iWDkw++7+IyQQg3VRUt81ZttCvWc0Cr2wPEsEt2sDsGwu9gIyFUNpTEdHB89Iho+grtM sOfrIzXCCHJgIKPnQLHsHnvjKg5ZTaJLRfhFcEgktlmuTqfFgbosv7zY/LmGc5kHDvY20EYO6Tmu6 sVTmP38xV99kzySiZ4ufvJJoDUEVi4tP9V2pdi9jb0A9YwFaTYeA4nUW6n37d3vmu26RU2khUxCKE yuR3aFIfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvAuW-0002Te-2g; Tue, 14 Jul 2020 02:43:12 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvAuT-0002T4-3G; Tue, 14 Jul 2020 02:43:09 +0000 Received: by mail-il1-f196.google.com with SMTP id r12so13023233ilh.4; Mon, 13 Jul 2020 19:43:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xqtDm2mhhrQr4POykVjXpWXd6bdcMg+HFqdOsT5mp4s=; b=OjpmRbgCU8KmzT+C4Ozxt7zWQ2rKjS9kKt4N+VG5ZtygtdK3zJ+g+LGpE4ftjCt6cP gzdGfApYbs1/EmFkJRIMGYyoCWdxWiw2KnpWXch6raOFpdGrSRmvfQr1n2BMZEvpVD2q W97JZbWMi9EcY2d6V7R7GJhXW5EAI/Qki63uI3YM99cOOVuzVeoynZ455PkuEVX/nYPi h5Q8ybXUDVAsH5QqyzcihQ0JDZai6MqqelFhdj3+0ybuPUwC/4v7CgDmRaWpqA96RfxD cKrrUomYspiYDKnuiXVSZiUX9K7TyAtrbySMLrYJA0ogbbGv2V8FV+VoAwjRYR9cGs4T 4FTw== X-Gm-Message-State: AOAM533EyQMPoln3JaHjNotcNIp65LGcr9RgdUyJ7c8zr+Pkr+xDD7Ej 4+8ANUyPpdPExxV7f8xd+w== X-Google-Smtp-Source: ABdhPJwP7oyW5vo0EP1nShAgwRfmyppCEeoygTDpvF7Z3GyAh6grDk8GD7NYUcoOANS6Zg6ngUJgQg== X-Received: by 2002:a92:4856:: with SMTP id v83mr2661419ila.125.1594694588463; Mon, 13 Jul 2020 19:43:08 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id e1sm9272037ilr.23.2020.07.13.19.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 19:43:07 -0700 (PDT) Received: (nullmailer pid 1178708 invoked by uid 1000); Tue, 14 Jul 2020 02:43:07 -0000 Date: Mon, 13 Jul 2020 20:43:07 -0600 From: Rob Herring To: Katsuhiro Suzuki Subject: Re: [PATCH v2] dt-bindings: sound: convert rk3328 codec binding to yaml Message-ID: <20200714024307.GA1175068@bogus> References: <20200630135412.718447-1-katsuhiro@katsuster.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200630135412.718447-1-katsuhiro@katsuster.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_224309_171768_2D5EA3CC X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2020 at 10:54:12PM +0900, Katsuhiro Suzuki wrote: > This patch converts Rockchip rk3328 audio codec binding to DT schema. > And adds description about "mclk" clock and fixes some errors in > original example. > > Signed-off-by: Katsuhiro Suzuki > --- > .../bindings/sound/rockchip,rk3328-codec.txt | 28 -------- > .../bindings/sound/rockchip,rk3328-codec.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.txt > create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml Need to Cc Mark Brown... > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.txt > deleted file mode 100644 > index 1ecd75d2032a..000000000000 > --- a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -* Rockchip Rk3328 internal codec > - > -Required properties: > - > -- compatible: "rockchip,rk3328-codec" > -- reg: physical base address of the controller and length of memory mapped > - region. > -- rockchip,grf: the phandle of the syscon node for GRF register. > -- clocks: a list of phandle + clock-specifer pairs, one for each entry in clock-names. > -- clock-names: should be "pclk". > -- spk-depop-time-ms: speak depop time msec. > - > -Optional properties: > - > -- mute-gpios: GPIO specifier for external line driver control (typically the > - dedicated GPIO_MUTE pin) > - > -Example for rk3328 internal codec: > - > -codec: codec@ff410000 { > - compatible = "rockchip,rk3328-codec"; > - reg = <0x0 0xff410000 0x0 0x1000>; > - rockchip,grf = <&grf>; > - clocks = <&cru PCLK_ACODEC>; > - clock-names = "pclk"; > - mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>; > - spk-depop-time-ms = 100; > -}; > diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml > new file mode 100644 > index 000000000000..525b48c2f5de > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/rockchip,rk3328-codec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip rk3328 internal codec > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + const: rockchip,rk3328-codec > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock for audio codec > + - description: clock for I2S master clock > + > + clock-names: > + items: > + - const: pclk > + - const: mclk > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + The phandle of the syscon node for the GRF register. > + > + spk-depop-time-ms: > + $ref: /schemas/types.yaml#/definitions/uint32 Don't need a type with standard unit suffixes. > + default: 200 Is there a range of values? Surely 2^32 would be too long. Otherwise, Reviewed-by: Rob Herring > + description: > + Speaker depop time in msec. > + > + mute-gpios: > + maxItems: 1 > + description: > + GPIO specifier for external line driver control (typically the > + dedicated GPIO_MUTE pin) > + > + "#sound-dai-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - rockchip,grf > + - "#sound-dai-cells" > + > +examples: > + - | > + #include > + #include > + codec: codec@ff410000 { > + compatible = "rockchip,rk3328-codec"; > + reg = <0xff410000 0x1000>; > + clocks = <&cru PCLK_ACODECPHY>, <&cru SCLK_I2S1>; > + clock-names = "pclk", "mclk"; > + rockchip,grf = <&grf>; > + mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>; > + spk-depop-time-ms = <100>; > + #sound-dai-cells = <0>; > + }; > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel