From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D1DC433E0 for ; Tue, 14 Jul 2020 03:01:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5F3321974 for ; Tue, 14 Jul 2020 03:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="olqG1kTC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5F3321974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fzkk4Z4GsSKy/TXo65E+BmkedrpztBvKC//ns4ttpZk=; b=olqG1kTCAp++47owdAmX4caip hy+vvnmLdSZqvyxYykfHKv40++cnMpFfh+bOexoXA8HXeH0VxJ6612ThOZdVXNEmKnuj++JufxsX+ x3lscCVL+Z1zsq7AJNJbX/NJ5r4nMr9R7fd6YQkY8J6hE/V0GDy/tfcPHsiwBqmOb50frKAaL1i69 8/sxMin5s+nNReHBVu0WQbUoV+3/6rWEZhr3KEsTv+w/oHU5k5UObcZq1EUtISoaGnfVOH7CULaXN edzOV24gIXTXeHwE8Xslm5rNd9NRNSfzpQFWRD4sU81Uxh7xAOfCI53/wer6Lb/H9l1lSxMv1/d5y VnhFhPHLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvBAt-0004JM-0m; Tue, 14 Jul 2020 03:00:07 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvBAq-0004Ik-7Q for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 03:00:05 +0000 Received: by mail-io1-f68.google.com with SMTP id i4so15753027iov.11 for ; Mon, 13 Jul 2020 20:00:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wSXghTdlLAieEFZ39iyyxrFmCFgGzVBzq1RNCvrRwsw=; b=VLv5lq2Dh0WsueSU9tC9X0hs8o3M/NWxdDHSqOotai7uRwarExkGF5kXdwoF5lEuGA MEc0+Ake6MUX5Xr6IzK08SnMa+vvGUUeROzxpKf/EW/OqLv+6KI8TB35Z+pM+vBlCBEd qY+2mRa6dQi7LGpUwApSSO2jNpJOaT9oKrosl9TeFZeAgeYoiYzP/yc7jdb/pEPqjMXO Xpi7aaThgC8ToUYS74vQ6Il/u0MOnvwagiEaDpUTCPWo3ZTY/06uCT64yMXoUp+o3+As SkSS0i96rIo6xnNU6zy5szJY+vqjk2uyEkfia7Ma4LinLxR7hRYuOuDH2MsaH1tH9FFM 2Q+A== X-Gm-Message-State: AOAM531lVcBEQ0L1ng0AUUYq7XjczCBYboruAG0D9/BFvQOhTkY7/dWW ok2phpmxubGGd26TJTAllQ== X-Google-Smtp-Source: ABdhPJyYgsLrR7GdjWOSNztbmbu/GfZF0NPf4tc2WGYT9ElsoeWfIqN7HC5bGrGWEOd8HcW+Cgvzew== X-Received: by 2002:a02:6514:: with SMTP id u20mr3442335jab.94.1594695603704; Mon, 13 Jul 2020 20:00:03 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id u62sm9418029ilc.87.2020.07.13.20.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 20:00:03 -0700 (PDT) Received: (nullmailer pid 1201871 invoked by uid 1000); Tue, 14 Jul 2020 03:00:01 -0000 Date: Mon, 13 Jul 2020 21:00:01 -0600 From: Rob Herring To: Li Jun Subject: Re: [PATCH v2 5/5] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 glue bindings Message-ID: <20200714030001.GA1196828@bogus> References: <1594028699-1055-1-git-send-email-jun.li@nxp.com> <1594028699-1055-6-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1594028699-1055-6-git-send-email-jun.li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_230004_314156_B3BB1CE4 X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, peng.fan@nxp.com, horia.geanta@nxp.com, Anson.Huang@nxp.com, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-usb@vger.kernel.org, peter.chen@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de, gregkh@linuxfoundation.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2020 at 05:44:59PM +0800, Li Jun wrote: > NXP imx8mp integrates 2 dwc3 3.30b IP and add some wakeup logic > to support low power mode, the glue layer is for this wakeup > functionality, which has a separated interrupt, can support > wakeup from U3 and connect events for host, and vbus wakeup for > device. > > Signed-off-by: Li Jun > --- > .../devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 87 ++++++++++++++++++++++ > 1 file changed, 87 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > new file mode 100644 > index 0000000..823db058 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP iMX8MP Soc USB Controller > + > +maintainers: > + - Li Jun > + > +properties: > + compatible: > + items: > + - const: fsl,imx8mp-dwc3 > + > + reg: > + maxItems: 1 > + description: Address and length of the register set for the wrapper of > + dwc3 core on the SOC. > + > + "#address-cells": > + enum: [ 1, 2 ] > + > + "#size-cells": > + enum: [ 1, 2 ] > + > + interrupts: > + maxItems: 1 > + description: The interrupt that is asserted when a wakeup event is > + received. > + > + clocks: > + description: > + A list of phandle and clock-specifier pairs for the clocks > + listed in clock-names. > + items: > + - description: system hsio root clock. > + - description: system bus AXI clock. > + - description: suspend clock, used for wakeup logic. > + > + clock-names: > + items: > + - const: hsio > + - const: bus > + - const: suspend > + > +# Required child node: > + > + dwc3: Needs to be a pattern with the unit-address. > + description: This is the node representing the DWC3 controller instance > + Documentation/devicetree/bindings/usb/dwc3.txt > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks Pretty sure you need a few more properties here... Add: additionalProperties: false > + > +examples: > + - | > + #include > + #include > + usb3_0: usb@32f10100 { > + compatible = "fsl,imx8mp-dwc3"; > + reg = <0x32f10100 0x8>; > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, > + <&clk IMX8MP_CLK_HSIO_AXI_DIV>, > + <&clk IMX8MP_CLK_USB_ROOT>; > + clock-names = "hsio", "bus", "suspend"; > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI_SRC>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > + assigned-clock-rates = <500000000>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + dwc3@38100000 { > + compatible = "snps,dwc3"; > + reg = <0x38100000 0x10000>; > + interrupts = ; > + phys = <&usb3_phy0>, <&usb3_phy0>; > + phy-names = "usb2-phy", "usb3-phy"; > + }; > + }; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel