Re: [PATCH 09/10] misc: habanalabs: irq: Add missing struct identifier for 'struct hl_eqe_work'

Oded Gabbay
2020-06-26T13:47:24Z

On Fri, Jun 26, 2020 at 4:05 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> In kerneldoc format, data structures have to start with 'struct'
> else the kerneldoc tooling/parsers/validators get confused.
>
> Squashes the following W=1 warning:
>
> drivers/misc/habanalabs/irq.c:19: warning: cannot understand function prototype: 'struct hl_eqe_work '
>
> Cc: Oded Gabbay <oded.gabbay@gmail.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/misc/habanalabs/irq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/irq.c b/drivers/misc/habanalabs/irq.c
> index fac65fbd70e81..4e77a73857793 100644
> --- a/drivers/misc/habanalabs/irq.c
> +++ b/drivers/misc/habanalabs/irq.c
> @@ -10,7 +10,8 @@
> #include <linux/slab.h>
>
> /**
> - * This structure is used to schedule work of EQ entry and armcp_reset event
> + * struct hl_eqe_work - This structure is used to schedule work of EQ
> + * entry and armcp_reset event
> *
> * @eq_work - workqueue object to run when EQ entry is received
> * @hdev - pointer to device structure
> --
> 2.25.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>

Applied to my -fixes tree.
Oded