Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT()

Arnd Bergmann
2020-06-26T14:39:45Z

On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> lkdtm_DOUBLE_FAULT() already has internal logic to handle
> !CONFIG_X86_32. Compiling out the prototype actually prevents
> that logic from being useful.
>
> Fixes the following W=1 warning:
>
> drivers/misc/lkdtm/bugs.c: At top level:
> drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes]
> 420 | void lkdtm_DOUBLE_FAULT(void)
> | ^~~~~~~~~~~~~~~~~~
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>