From: Will Deacon <will@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
robin.murphy@arm.com, Jay Chen <jkchen@linux.alibaba.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 0/2] perf/smmuv3: dts get opt and simplify code
Date: Tue, 14 Jul 2020 08:48:02 +0100 [thread overview]
Message-ID: <20200714074801.GB4277@willie-the-truck> (raw)
In-Reply-To: <20200713231555.GA899100@bogus>
Hi Rob,
On Mon, Jul 13, 2020 at 05:15:55PM -0600, Rob Herring wrote:
> On Mon, Jul 13, 2020 at 09:46:58PM +0100, Will Deacon wrote:
> > On Mon, 6 Jul 2020 19:22:44 +0800, Jay Chen wrote:
> > > This patch set firstly to simplify the code in smmu pmu probe,
> > > and then support to get options in dts
> > >
> > > Jay Chen (2):
> > > perf/smmuv3: To simplify code for ioremap page in pmcg
> > > perf/smmuv3: To support the dts to get options
> > >
> > > [...]
> >
> > Applied to will (for-next/perf), thanks!
>
> Without a binding document for the undocumented property and
> compatible string!?
No, I only took the second patch ("To simplify code...")! It would be nice
if b4 was a big clearer about that when cherry-picking, but I'm not sure
exactly what it could do. Maybe if it only replied to the patch being
picked, rather than the cover letter?
I'm usually pretty careful about avoiding DT changes without your ack.
> Is the 'arm-smmu-v3-pmcg' actually a separate block from the SMMU? Or is
> this just an add a compatible to instantiate a driver?
Not quite sure how to answer that one... afaik, the PMCG is a bunch of
distributed counter blocks that may or may not be present and are driven
entirely independently of the rest of the SMMU, which is a lot more
standardised. In fact, I'm not sure why ARM_SMMU_V3_PMU depends on
ARM_SMMU_V3, it builds perfectly fine without that (and with the main
driver disabled).
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-14 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 11:22 [RFC PATCH v1 0/2] perf/smmuv3: dts get opt and simplify code Jay Chen
2020-07-06 11:22 ` [RFC PATCH v1 1/2] perf/smmuv3: To simplify code for ioremap page in pmcg Jay Chen
2020-07-06 11:22 ` [RFC PATCH v1 2/2] perf/smmuv3: To support the dts to get options Jay Chen
2020-07-06 15:03 ` Robin Murphy
2020-07-07 15:01 ` Jean-Philippe Brucker
2020-07-13 23:25 ` Rob Herring
2020-07-14 9:35 ` Robin Murphy
2020-07-13 20:46 ` [RFC PATCH v1 0/2] perf/smmuv3: dts get opt and simplify code Will Deacon
2020-07-13 23:15 ` Rob Herring
2020-07-14 7:48 ` Will Deacon [this message]
2020-07-14 7:49 ` Will Deacon
2020-07-14 22:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714074801.GB4277@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jkchen@linux.alibaba.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox