From: Will Deacon <will@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: robh@kernel.org, linux-kernel@vger.kernel.org,
tomeu.vizoso@collabora.com, airlied@linux.ie,
linux-arm-msm@vger.kernel.org, joro@8bytes.org,
iommu@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
baolin.wang7@gmail.com, robdclark@gmail.com, agross@kernel.org,
linux-mediatek@lists.infradead.org,
alyssa.rosenzweig@collabora.com, daniel@ffwll.ch,
matthias.bgg@gmail.com, steven.price@arm.com,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] iommu: Add gfp parameter to io_pgtable_ops->map()
Date: Tue, 14 Jul 2020 09:28:21 +0100 [thread overview]
Message-ID: <20200714082821.GC4516@willie-the-truck> (raw)
In-Reply-To: <3093df4cb95497aaf713fca623ce4ecebb197c2e.1591930156.git.baolin.wang@linux.alibaba.com>
On Fri, Jun 12, 2020 at 11:39:55AM +0800, Baolin Wang wrote:
> Now the ARM page tables are always allocated by GFP_ATOMIC parameter,
> but the iommu_ops->map() function has been added a gfp_t parameter by
> commit 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map"),
> thus io_pgtable_ops->map() should use the gfp parameter passed from
> iommu_ops->map() to allocate page pages, which can avoid wasting the
> memory allocators atomic pools for some non-atomic contexts.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +-
> drivers/iommu/arm-smmu-v3.c | 2 +-
> drivers/iommu/arm-smmu.c | 2 +-
> drivers/iommu/io-pgtable-arm-v7s.c | 18 +++++++++---------
> drivers/iommu/io-pgtable-arm.c | 18 +++++++++---------
> drivers/iommu/ipmmu-vmsa.c | 2 +-
> drivers/iommu/msm_iommu.c | 2 +-
> drivers/iommu/mtk_iommu.c | 2 +-
> drivers/iommu/qcom_iommu.c | 2 +-
> include/linux/io-pgtable.h | 2 +-
> 10 files changed, 26 insertions(+), 26 deletions(-)
I was a bit nervous about us passing GFP_KERNEL with a spinlock held, but
it looks like you've checked all the callsites and it looks fine to me, so:
Acked-by: Will Deacon <will@kernel.org>
Joerg -- not sure what you want to do with this one, as it's likely to
conflict (trivially) with unrelated driver changes.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-14 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 3:39 [PATCH v2 0/2] Some improvements for iommu Baolin Wang
2020-06-12 3:39 ` [PATCH v2 1/2] iommu: Mark __iommu_map/__iommu_map_sg as static Baolin Wang
2020-07-14 8:26 ` Will Deacon
2020-06-12 3:39 ` [PATCH v2 2/2] iommu: Add gfp parameter to io_pgtable_ops->map() Baolin Wang
2020-07-14 8:28 ` Will Deacon [this message]
2020-07-23 11:36 ` Baolin Wang
2020-07-24 12:30 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714082821.GC4516@willie-the-truck \
--to=will@kernel.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox