From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8828C433E6 for ; Tue, 14 Jul 2020 14:22:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 719F122365 for ; Tue, 14 Jul 2020 14:22:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R9ZBi3gk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="DWNWxUgZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 719F122365 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LmcfFYMDVoSKdmKucQMHZNw5UTXpm2RBI424YpDdJlg=; b=R9ZBi3gkSrBtZ9YIQYEXs6nzE 6o/sWtV76lbONkIxZjHWqeRyfePCQmb8MVgHFKfNZ0jkpYtMX2WCIsIPch8Wk2RFzmfKJmxWijEmq CyXuOgI+7T3K9u65gOb61e3DU5SjjhYrxAeVQ9DGQqVO058v0nRnNpS84/a6pnOCTNQCEDn4cBjlP HTggToGlT8ztH/l8OJcn+vhQ/tVG4tSOPYjr5u4bxy0eCvGO911wHb1DMIYNkVnzbxsUNEypFgiDW LvoigWE5uspmyY+TXl36mYDWK2S9PfMfZbTfSOnRwdtSrYnvqw5neavJMiPDB5bkzS6+vUttPclGY MtoV7Mr6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvLne-0007lC-3o; Tue, 14 Jul 2020 14:20:50 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvLnb-0007kp-48 for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 14:20:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GGLKpCtfXp/dDb1UvrqAQzlGazNkOez+UKhWUdeID5s=; b=DWNWxUgZw2EnrikGzLBm4DibM dE64C8ZhfJiv77FVfZWzkw77t9+8Zqratqic90C93rVUO0yzprBYxD71jGZFCVQuBiq0ZManmhWMz e7CU0Y5m4EU85VCIfDX643Ip34UgyKdYJ3tSPdc+m8jHIxf1A2WihrmkzBC0cM9HqAdhihVsUhGMW PIkDr+T86g8M6v2rV6h1gGUXXSWZv5Qy+2NIBs0bxdpyH77VKCOXOsZtzM/EtUMfFB1dPIjzHO1OE kcZJBMAgM7QtvK0caos5ooGz3EAv6e2kV8UsVItFfXf2UKzBC5TtEwCrb/ocsK4U6J3ZE3zjiYGtw 6BaNfM9BA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39428) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvLnX-0005Lx-45; Tue, 14 Jul 2020 15:20:43 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jvLnV-0007N1-1H; Tue, 14 Jul 2020 15:20:41 +0100 Date: Tue, 14 Jul 2020 15:20:41 +0100 From: Russell King - ARM Linux admin To: paul@mawsonlakes.org Subject: Re: [PATCH] Changes blacklist to blocklist in ecode.c file Message-ID: <20200714142040.GD1551@shell.armlinux.org.uk> References: <20200714140557.401403-1-paul@mawsonlakes.org> <20200714140557.401403-2-paul@mawsonlakes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714140557.401403-2-paul@mawsonlakes.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_102047_386527_A52EA23F X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: soc@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 14, 2020 at 11:35:57PM +0930, paul@mawsonlakes.org wrote: > From: Paul Schulz > > --- > arch/arm/mach-rpc/ecard.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c > index 75cfad2cb143..b3d70389ac9a 100644 > --- a/arch/arm/mach-rpc/ecard.c > +++ b/arch/arm/mach-rpc/ecard.c > @@ -63,7 +63,7 @@ struct ecard_request { > struct completion *complete; > }; > > -struct expcard_blacklist { > +struct expcard_blocklist { I don't like this change - this is not about "blocking" anything, so this change results in nonsense. expcard_quirklist would be better. > unsigned short manufacturer; > unsigned short product; > const char *type; > @@ -79,7 +79,7 @@ static void atomwide_3p_quirk(ecard_t *ec); > /* List of descriptions of cards which don't have an extended > * identification, or chunk directories containing a description. > */ > -static struct expcard_blacklist __initdata blacklist[] = { > +static struct expcard_blocklist __initdata blocklist[] = { Reading the comment above illustrates my point above; this list is not about blocking anything, so calling it a "block" list is just rediculous. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel