From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: ohad@wizery.com, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues
Date: Wed, 15 Jul 2020 12:21:38 -0700 [thread overview]
Message-ID: <20200715192138.GA2922385@builder.lan> (raw)
In-Reply-To: <20200715123551.4011154-2-lee.jones@linaro.org>
On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote:
> Looks as though 'name' has now been moved into 'struct sysmod_event'
> which is passed in instead. However, the parameter descriptions were
> not updated at the same time. Let's do that now.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event'
> drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event'
> drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event'
> drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Thanks Lee, both patches applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_sysmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 8d8996d714f07..9eb2f6bccea63 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list);
> /**
> * sysmon_send_event() - send notification of other remote's SSR event
> * @sysmon: sysmon context
> - * @name: other remote's name
> + * @event: sysmon event context
> */
> static void sysmon_send_event(struct qcom_sysmon *sysmon,
> const struct sysmon_event *event)
> @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon)
> /**
> * ssctl_send_event() - send notification of other remote's SSR event
> * @sysmon: sysmon context
> - * @name: other remote's name
> + * @event: sysmon event context
> */
> static void ssctl_send_event(struct qcom_sysmon *sysmon,
> const struct sysmon_event *event)
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-15 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 12:35 [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation Lee Jones
2020-07-15 12:35 ` [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Lee Jones
2020-07-15 19:21 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715192138.GA2922385@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).